[jira] [Comment Edited] (STORM-3759) Additional Trident Kafka Spout Metrics

["Jonathan Poholarz (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-3759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306553#comment-17306553 ] 

Jonathan Poholarz edited comment on STORM-3759 at 3/22/21, 8:22 PM:
--------------------------------------------------------------------

Related PR: https://github.com/apache/storm/pull/3385

 

Ethan pointed out there is a builtin ___emit-count_ metric which might be sufficient for the *Event emit rate* metric proposed.

 
{code:java}
Is the builtin emitted metric not sufficient for this purpose? https://github.com/apache/storm/blob/master/docs/Metrics.md#__emit-count
{code}
However, is spout/stream renaming supported for Trident topologies?  For our trident storm topologies, we get metrics with names like "__emit-count-s87";  we have about 200 of them in our metric list which is too many to distinguish without proper names.

 

The TridentTopologyBuilder seems like it might be assigning names using only ID numbers, but I am not certain about this. [https://github.com/apache/storm/blob/7bef73a6faa14558ef254efe74cbe4bfef81c2e2/storm-client/src/jvm/org/apache/storm/trident/topology/TridentTopologyBuilder.java#L142-L143]

 


was (Author: jmpoholarz):
Ethan pointed out there is a builtin ___emit-count_ metric which might be sufficient for the *Event emit rate* metric proposed.

 
{code:java}
Is the builtin emitted metric not sufficient for this purpose? https://github.com/apache/storm/blob/master/docs/Metrics.md#__emit-count
{code}
However, is spout/stream renaming supported for Trident topologies?  For our trident storm topologies, we get metrics with names like "__emit-count-s87";  we have about 200 of them in our metric list which is too many to distinguish without proper names.

 

The TridentTopologyBuilder seems like it might be assigning names using only ID numbers, but I am not certain about this. [https://github.com/apache/storm/blob/7bef73a6faa14558ef254efe74cbe4bfef81c2e2/storm-client/src/jvm/org/apache/storm/trident/topology/TridentTopologyBuilder.java#L142-L143]

 

> Additional Trident Kafka Spout Metrics
> --------------------------------------
>
>                 Key: STORM-3759
>                 URL: https://issues.apache.org/jira/browse/STORM-3759
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-kafka-client
>            Reporter: Jonathan Poholarz
>            Priority: Major
>
> The Trident Kafka Spout/Emitter does not seem to measure a couple metrics that my team has found useful over the years using the spout.
> *Event emit rate*
>  Having a count of how many events are being emitted by the spout can track the rate at which the spout is consuming from the kafka topic(s). If this rate decreases, it signals performance issues to investigate.  This metric has helped my team track the overall health of our Kafka spouts.
> *Kafka Spout Max Lag*
>  This gauge value monitors the backlog of events.  It helps determine if:
>  * a. the spout is not emitting fast enough to keep up with the incoming data, or
>  * b. the spout is current and Kafka topic delayed.
> This metric can be used to distinguish between these two cases and determine the source of the slowdown.  It has helped my team better understand delays.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)