You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by br...@apache.org on 2005/09/29 13:34:06 UTC
svn commit: r292419 -
/maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/ProjectSorter.java
Author: brett
Date: Thu Sep 29 04:34:02 2005
New Revision: 292419
URL: http://svn.apache.org/viewcvs?rev=292419&view=rev
Log:
don't need to depend on parent, it no longer needs to execute first due to reactor handling. can avoid cycles.
Modified:
maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/ProjectSorter.java
Modified: maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/ProjectSorter.java
URL: http://svn.apache.org/viewcvs/maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/ProjectSorter.java?rev=292419&r1=292418&r2=292419&view=diff
==============================================================================
--- maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/ProjectSorter.java (original)
+++ maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/ProjectSorter.java Thu Sep 29 04:34:02 2005
@@ -27,7 +27,6 @@
import java.util.ArrayList;
import java.util.Collections;
-import java.util.Comparator;
import java.util.HashMap;
import java.util.Iterator;
import java.util.List;
@@ -97,6 +96,7 @@
}
}
+/* TODO: can this be removed?
MavenProject parent = project.getParent();
if ( parent != null )
{
@@ -106,6 +106,7 @@
dag.addEdge( id, parentId );
}
}
+*/
List buildPlugins = project.getBuildPlugins();
if ( buildPlugins != null )
@@ -196,34 +197,4 @@
{
return dag.getParentLabels( id );
}
-
- private static class ByProjectFileComparator
- implements Comparator
- {
-
- public int compare( Object first, Object second )
- {
- MavenProject p1 = (MavenProject) first;
- MavenProject p2 = (MavenProject) second;
-
- String p1Path = p1.getFile().getAbsolutePath();
- String p2Path = p2.getFile().getAbsolutePath();
-
- int comparison = p1Path.length() - p2Path.length();
-
- if ( comparison > 0 )
- {
- return 1;
- }
- else if ( comparison < 0 )
- {
- return -1;
- }
- else
- {
- return 0;
- }
- }
- }
-
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org