You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by gu...@apache.org on 2019/05/21 17:54:42 UTC
[kafka] branch trunk updated: KAFKA-8315: fix the JoinWindows
retention deprecation doc (#6664)
This is an automated email from the ASF dual-hosted git repository.
guozhang pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 3b5d7ae KAFKA-8315: fix the JoinWindows retention deprecation doc (#6664)
3b5d7ae is described below
commit 3b5d7aee6cb9f191eaf647576ae39d3d8ebc941f
Author: John Roesler <vv...@users.noreply.github.com>
AuthorDate: Tue May 21 12:54:26 2019 -0500
KAFKA-8315: fix the JoinWindows retention deprecation doc (#6664)
Fix a javadoc mistake introduced in https://github.com/apache/kafka/pull/5911/files#diff-35e3523474fa277a63e36a3fe9e22af8.
Reviewers: Matthias J. Sax <ma...@confluent.io>, Guozhang Wang <wa...@gmail.com>
---
.../src/main/java/org/apache/kafka/streams/kstream/JoinWindows.java | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/streams/src/main/java/org/apache/kafka/streams/kstream/JoinWindows.java b/streams/src/main/java/org/apache/kafka/streams/kstream/JoinWindows.java
index 6331877..4798183 100644
--- a/streams/src/main/java/org/apache/kafka/streams/kstream/JoinWindows.java
+++ b/streams/src/main/java/org/apache/kafka/streams/kstream/JoinWindows.java
@@ -246,7 +246,7 @@ public final class JoinWindows extends Windows<Window> {
* @param durationMs the window retention time in milliseconds
* @return itself
* @throws IllegalArgumentException if {@code durationMs} is smaller than the window size
- * @deprecated since 2.1. Use {@link Materialized#withRetention(Duration)} instead.
+ * @deprecated since 2.1. Use {@link JoinWindows#grace(Duration)} instead.
*/
@Override
@Deprecated
@@ -263,7 +263,8 @@ public final class JoinWindows extends Windows<Window> {
* For {@link TimeWindows} the maintain duration is at least as small as the window size.
*
* @return the window maintain duration
- * @deprecated since 2.1. This function should not be used anymore as retention period can be specified via {@link Materialized#withRetention(Duration)}.
+ * @deprecated since 2.1. This function should not be used anymore, since {@link JoinWindows#until(long)}
+ * is deprecated in favor of {@link JoinWindows#grace(Duration)}.
*/
@Override
@Deprecated