You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kylin.apache.org by GitBox <gi...@apache.org> on 2018/08/24 01:16:38 UTC

[GitHub] shaofengshi commented on issue #198: KYLIN-3499 Update HBaseResourceStore.java

shaofengshi commented on issue #198: KYLIN-3499 Update HBaseResourceStore.java
URL: https://github.com/apache/kylin/pull/198#issuecomment-415620951
 
 
   Hi Momoxixi,
   
   Sorry for the late response. So you mean, the invocation of "table.checkAndPut" may throw a "RetriesExhaustedException" but actually, the change has been taken effectively in the HBase server side, right?
   
   If so, two comments here:
   1) This change adds a "try-catch" embedded in the original "try-catch", the embedded try-catch should be avoided.
   2) Besides the "RetriesExhaustedException", are there other similar cases? Can it be generalized to "IOException"?
   
   Thanks for your contribution to Kylin! 
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services