You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/07/03 22:47:42 UTC

[GitHub] [guacamole-client] echu2013 opened a new pull request #545: GUACAMOLE-1125: Fix Ctrl+Alt+End ( =>Supr)

echu2013 opened a new pull request #545:
URL: https://github.com/apache/guacamole-client/pull/545


   Issue which evidenced starting with guacamole-server version 1.2.0. Send guacSyntheticKeyup (DEL key here) BEFORE deleting it for proper behavior.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-client] echu2013 closed pull request #545: GUACAMOLE-1125: Fix Ctrl+Alt+End ( =>Supr)

Posted by GitBox <gi...@apache.org>.
echu2013 closed pull request #545:
URL: https://github.com/apache/guacamole-client/pull/545


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-client] echu2013 commented on pull request #545: GUACAMOLE-1125: Quick-Fix for substituteKeysPressed handler to proper release keys on guacKeyup events

Posted by GitBox <gi...@apache.org>.
echu2013 commented on pull request #545:
URL: https://github.com/apache/guacamole-client/pull/545#issuecomment-654318216


   > @echu2013: Much better - one more request - can you adjust the commit message so that it isn't cut off? I think a single line for this one will be okay :-).
   
   Is it better now?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-client] echu2013 commented on pull request #545: GUACAMOLE-1125: Quick-Fix for substituteKeysPressed handler to proper release keys on guacKeyup events

Posted by GitBox <gi...@apache.org>.
echu2013 commented on pull request #545:
URL: https://github.com/apache/guacamole-client/pull/545#issuecomment-653904909


   > @echu2013: Thanks for the quick-fix - I think it looks fine. My only request is that you tweak the commit message and PR title a bit to be less-specific to keys/key sequences and somewhat more generic. While you're seeing this in Ctrl-Alt-End, the issue actually fixes any/all substitute key presses that might be present.
   
   Does now make sense???


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-client] necouchman merged pull request #545: GUACAMOLE-1125: Fix substituteKeysPressed handler on guacKeyup events

Posted by GitBox <gi...@apache.org>.
necouchman merged pull request #545:
URL: https://github.com/apache/guacamole-client/pull/545


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-client] necouchman commented on pull request #545: GUACAMOLE-1125: Quick-Fix for substituteKeysPressed handler to proper release keys on guacKeyup events

Posted by GitBox <gi...@apache.org>.
necouchman commented on pull request #545:
URL: https://github.com/apache/guacamole-client/pull/545#issuecomment-653923904


   @echu2013: Much better - one more request - can you adjust the commit message so that it isn't cut off?  I think a single line for this one will be okay :-).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org