You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by cammckenzie <gi...@git.apache.org> on 2014/06/25 07:27:38 UTC

[GitHub] curator pull request: CURATOR-116 - Modified sorting of children t...

GitHub user cammckenzie opened a pull request:

    https://github.com/apache/curator/pull/13

    CURATOR-116 - Modified sorting of children to be deterministic.

    Modified sorting of children to be deterministic.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cammckenzie/curator CURATOR-116

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13
    
----
commit 1103f476d84a53784377a96f8661bd9219e7412d
Author: Cameron McKenzie <ca...@unico.com.au>
Date:   2014-06-25T01:53:00Z

    CURATOR-116 - Modified sorting of children to be deterministic.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator pull request: CURATOR-116 - Modified sorting of children t...

Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/13#discussion_r14185554
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/queue/DistributedDelayQueue.java ---
    @@ -77,14 +77,22 @@
                 finalFlushMs
             )
             {
    +            @Override
                 protected long getDelay(String itemNode)
                 {
    +                return getDelay(itemNode, System.currentTimeMillis());
    +            }
    +            
    +            protected long getDelay(String itemNode, long sortTime)
    --- End diff --
    
    This can be private, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator pull request: CURATOR-116 - Modified sorting of children t...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/curator/pull/13


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---