You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/11/30 18:05:52 UTC
Review Request 40797: Filtered non-whitelisted and deactivated agents
once per allocation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40797/
-----------------------------------------------------------
Review request for mesos and Joris Van Remoortere.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp 31ed62efb5b1a2edb567f43d37559c5914e0665e
Diff: https://reviews.apache.org/r/40797/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 40797: Filtered non-whitelisted and deactivated
agents once per allocation.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40797/#review108439
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 十一月 30, 2015, 5:14 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40797/
> -----------------------------------------------------------
>
> (Updated 十一月 30, 2015, 5:14 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 31ed62efb5b1a2edb567f43d37559c5914e0665e
>
> Diff: https://reviews.apache.org/r/40797/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40797: Filtered non-whitelisted and deactivated
agents once per allocation.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40797/
-----------------------------------------------------------
(Updated Dec. 4, 2015, 9:38 a.m.)
Review request for mesos and Joris Van Remoortere.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp a8f65b72488505afd3677ecdeb9b821ea27af7e0
Diff: https://reviews.apache.org/r/40797/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 40797: Filtered non-whitelisted and deactivated
agents once per allocation.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40797/
-----------------------------------------------------------
(Updated Dec. 3, 2015, 9:11 p.m.)
Review request for mesos and Joris Van Remoortere.
Changes
-------
Removed unnecessary include.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp a8f65b72488505afd3677ecdeb9b821ea27af7e0
Diff: https://reviews.apache.org/r/40797/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 40797: Filtered non-whitelisted and deactivated
agents once per allocation.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40797/
-----------------------------------------------------------
(Updated Dec. 3, 2015, 8:25 p.m.)
Review request for mesos and Joris Van Remoortere.
Changes
-------
Joris' comments.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp a8f65b72488505afd3677ecdeb9b821ea27af7e0
Diff: https://reviews.apache.org/r/40797/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 40797: Filtered non-whitelisted and deactivated
agents once per allocation.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40797/#review108434
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40586, 40551, 40332, 40795, 39450, 40797]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Nov. 30, 2015, 5:14 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40797/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2015, 5:14 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 31ed62efb5b1a2edb567f43d37559c5914e0665e
>
> Diff: https://reviews.apache.org/r/40797/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40797: Filtered non-whitelisted and deactivated
agents once per allocation.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40797/#review108875
-----------------------------------------------------------
Ship it!
src/master/allocator/mesos/hierarchical.cpp (lines 1086 - 1097)
<https://reviews.apache.org/r/40797/#comment168340>
Let's simplify this to a basic for loop with a condition.
We can add an abstraction to stout to do something like filter later.
- Joris Van Remoortere
On Nov. 30, 2015, 5:14 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40797/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2015, 5:14 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 31ed62efb5b1a2edb567f43d37559c5914e0665e
>
> Diff: https://reviews.apache.org/r/40797/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40797: Filtered non-whitelisted and deactivated
agents once per allocation.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40797/
-----------------------------------------------------------
(Updated Nov. 30, 2015, 5:14 p.m.)
Review request for mesos and Joris Van Remoortere.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp 31ed62efb5b1a2edb567f43d37559c5914e0665e
Diff: https://reviews.apache.org/r/40797/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov