[GitHub] [pulsar] BewareMyPower commented on issue #13429: Release procedure: Building OSX packages is broken, at least in 2.9.1

[GitBox <gi...@apache.org>]

BewareMyPower commented on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-999577477


   Could you try this patch? At this moment I cannot test in my local env because it takes much time to install vagrant.
   
   ```diff
   xuyunze@xuyunzedeMacBook-Pro pulsar % git diff
   diff --git a/pulsar-client-cpp/CMakeLists.txt b/pulsar-client-cpp/CMakeLists.txt
   index 3c43aa5ede8..b93b1bfc1d7 100644
   --- a/pulsar-client-cpp/CMakeLists.txt
   +++ b/pulsar-client-cpp/CMakeLists.txt
   @@ -95,7 +95,7 @@ else() # GCC or Clang are mostly compatible:
        # Turn on warnings and enable warnings-as-errors:
        add_compile_options(-Wall -Wformat-security -Wvla -Werror) 
        # Turn off certain warnings that are too much pain for too little gain:
   -    add_compile_options(-Wno-sign-compare -Wno-deprecated-declarations -Wno-error=cpp)
   +    add_compile_options(-Wno-sign-compare -Wno-deprecated-declarations)
        if (CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64")
            add_compile_options(-msse4.2 -mpclmul)
        endif()
   @@ -103,7 +103,7 @@ else() # GCC or Clang are mostly compatible:
        if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
            add_compile_options(-Qunused-arguments) 
        elseif (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.9))
   -        add_compile_options(-Wno-stringop-truncation)
   +        add_compile_options(-Wno-stringop-truncation -Wno-error=cpp)
        endif()
    endif()
   ```
   
   If it doesn't work, you can just try to remove the `-Wno-error=cpp` option.
   
   BTW, /cc @oversearch please take a look when you have time. It looks like to be caused by https://github.com/apache/pulsar/pull/11668.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org