You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "jocelynmass (via GitHub)" <gi...@apache.org> on 2023/05/30 13:52:38 UTC
[GitHub] [mynewt-newt] jocelynmass opened a new pull request, #520: Add a way to set linker flags --whole-archive and --no-whole-archive per pkg
jocelynmass opened a new pull request, #520:
URL: https://github.com/apache/mynewt-newt/pull/520
Depending on the project, it might be useful to have the ability to link a package surrounded by "--whole-archive" and "--no-whole-archive" flags.
I tweaked the code to allow pkg.whole_archive option to be set to true or false. I'm completely new to Goland so the code I made is most likely garbage. I just submit this PR with the hope that someone with more skills would take over this and fully make it to the next newt release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a way to set linker flags --whole-archive and --no-whole-archive per pkg [mynewt-newt]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on PR #520:
URL: https://github.com/apache/mynewt-newt/pull/520#issuecomment-2041979025
sorry for late reply, looks OK to me!
@m-gorecki could you look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a way to set linker flags --whole-archive and --no-whole-archive per pkg [mynewt-newt]
Posted by "jocelynmass (via GitHub)" <gi...@apache.org>.
jocelynmass commented on PR #520:
URL: https://github.com/apache/mynewt-newt/pull/520#issuecomment-2047440215
@kasjer thanks just fixed the merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a way to set linker flags --whole-archive and --no-whole-archive per pkg [mynewt-newt]
Posted by "m-gorecki (via GitHub)" <gi...@apache.org>.
m-gorecki commented on PR #520:
URL: https://github.com/apache/mynewt-newt/pull/520#issuecomment-2042265673
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a way to set linker flags --whole-archive and --no-whole-archive per pkg [mynewt-newt]
Posted by "kasjer (via GitHub)" <gi...@apache.org>.
kasjer commented on PR #520:
URL: https://github.com/apache/mynewt-newt/pull/520#issuecomment-2046853921
@jocelynmass hi Jocelyn, your change seems ok and useful there are some conflicts due to late review. Would you care to rebase is it removing conflicts? If you don't have time I can do it. In this case I will force push resolved conflicts and it will be merged soon.
Thanks for contribution and I apologize for late review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a way to set linker flags --whole-archive and --no-whole-archive per pkg [mynewt-newt]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc merged PR #520:
URL: https://github.com/apache/mynewt-newt/pull/520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org