You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2018/03/21 01:02:19 UTC
[kudu-CR] [spark] improve log message to warn users to pass keytab/principal
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9730
Change subject: [spark] improve log message to warn users to pass keytab/principal
......................................................................
[spark] improve log message to warn users to pass keytab/principal
This patch improves the log message in KuduContext to warn user if
keytab and/or principal options are not passed when the job is running
in cluster mode.
Change-Id: I305494d6c10d73523fa65ef25faf90c5d86919c8
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/9730/1
--
To view, visit http://gerrit.cloudera.org:8080/9730
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I305494d6c10d73523fa65ef25faf90c5d86919c8
Gerrit-Change-Number: 9730
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] [spark] improve log message to warn users to pass keytab/principal
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9730 )
Change subject: [spark] improve log message to warn users to pass keytab/principal
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9730/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala:
http://gerrit.cloudera.org:8080/#/c/9730/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@376
PS1, Line 376: Log.warn(s"Please pass principal and keytab options for jobs running in cluster mode!")
We should only be logging in the case that the Kudu cluster is secure. Unfortunately I don't think we can know that until we failed to connect.
I think what we need to do for this is to make Kudu throw a more specific exception in the case that it can't connect due to lacking credentials, and then if we get that exception when we first connect to the cluster, we can issue the log?
--
To view, visit http://gerrit.cloudera.org:8080/9730
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I305494d6c10d73523fa65ef25faf90c5d86919c8
Gerrit-Change-Number: 9730
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 21 Mar 2018 22:53:10 +0000
Gerrit-HasComments: Yes
[kudu-CR] [spark] improve log message to warn users to pass keytab/principal
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has abandoned this change. ( http://gerrit.cloudera.org:8080/9730 )
Change subject: [spark] improve log message to warn users to pass keytab/principal
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/9730
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I305494d6c10d73523fa65ef25faf90c5d86919c8
Gerrit-Change-Number: 9730
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>