You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/20 03:04:47 UTC

[GitHub] [pulsar] congbobo184 commented on a diff in pull request #18981: [improve][client]PIP-230 Throw exception when MessageIdImpl and BatchMessageIdImpl compare with each other

congbobo184 commented on code in PR #18981:
URL: https://github.com/apache/pulsar/pull/18981#discussion_r1052827107


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageIdImpl.java:
##########
@@ -204,11 +204,13 @@ public byte[] toByteArray() {
     @Override
     public int compareTo(@Nonnull MessageId o) {
         if (o instanceof MessageIdImpl) {
+            if (o instanceof BatchMessageIdImpl) {
+                throw new UnsupportedOperationException(this.getClass().getName()

Review Comment:
   We should prohibit comparing the two types. This is not the correct behavior for users. In what scenario will they compare BatchMessageId and MessageId? Now that you have decided to throw an exception, why not just forbid it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org