You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/07/12 08:10:18 UTC
[GitHub] [zeppelin] rickchengx opened a new pull request #4172: [ZEPPELIN-5444] Allow users to set service account for interpreter
rickchengx opened a new pull request #4172:
URL: https://github.com/apache/zeppelin/pull/4172
### What is this PR for?
Currently, users cannot set the service account for the interpreter pod under k8s mode. And there is no service account defined in the pod `spec` in `k8s/interpreter/100-interpreter-spec.yaml`. According to the documentation of Kubernetes (<https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/>):
> When you create a pod, if you do not specify a service account, it is automatically assigned the **default** service account in the same namespace.
, which means that currently the interpreter pod can only use the default service account.
In order to allow users to directly set the service account for the interpreter pod in the interpreter settings, this PR adds a k8s template property, named `zeppelin.k8s.interpreter.serviceAccount`.
Example usage:
```
%spark.conf
zeppelin.k8s.interpreter.serviceAccount yourServiceAccount
```
Note that the `k8s/interpreter/100-interpreter-spec.yaml` creates a **role binding** when using the spark interpreter. It was originally directly bound to the default service account. This PR makes it bind to the service account set by user.
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
* <https://issues.apache.org/jira/browse/ZEPPELIN-5444>
### How should this be tested?
* CI pass and manually tested
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] rickchengx commented on pull request #4172: [ZEPPELIN-5444] Allow users to set service account for interpreter
Posted by GitBox <gi...@apache.org>.
rickchengx commented on pull request #4172:
URL: https://github.com/apache/zeppelin/pull/4172#issuecomment-879557464
> I have merged #4170. Please rebase and add the documentation part.
Thanks, I have rebased and added the documentation part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #4172: [ZEPPELIN-5444] Allow users to set service account for interpreter
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4172:
URL: https://github.com/apache/zeppelin/pull/4172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4172: [ZEPPELIN-5444] Allow users to set service account for interpreter
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4172:
URL: https://github.com/apache/zeppelin/pull/4172#issuecomment-879139817
I have merged #4170. Please rebase and add the documentation part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4172: [ZEPPELIN-5444] Allow users to set service account for interpreter
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4172:
URL: https://github.com/apache/zeppelin/pull/4172#issuecomment-914261464
Thanks @rickchengx for your good code contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4172: [ZEPPELIN-5444] Allow users to set service account for interpreter
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4172:
URL: https://github.com/apache/zeppelin/pull/4172#issuecomment-878285741
Please a documentation.
Missing parts:
- How to create the service account
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4172: [ZEPPELIN-5444] Allow users to set service account for interpreter
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4172:
URL: https://github.com/apache/zeppelin/pull/4172#issuecomment-878789869
Please expand the [documentation](https://github.com/apache/zeppelin/blob/master/docs/quickstart/kubernetes.md) about this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] rickchengx commented on pull request #4172: [ZEPPELIN-5444] Allow users to set service account for interpreter
Posted by GitBox <gi...@apache.org>.
rickchengx commented on pull request #4172:
URL: https://github.com/apache/zeppelin/pull/4172#issuecomment-878735434
> Please add documentation.
> Missing parts:
>
> * How to create the service account
If user needs to set a specific service account (rather than default), he needs to create the account in advance.
For example, user can create a service account through `kubectl`:
```
kubectl create serviceaccount my-service-account
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer edited a comment on pull request #4172: [ZEPPELIN-5444] Allow users to set service account for interpreter
Posted by GitBox <gi...@apache.org>.
Reamer edited a comment on pull request #4172:
URL: https://github.com/apache/zeppelin/pull/4172#issuecomment-878285741
Please add documentation.
Missing parts:
- How to create the service account
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org