You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/02/07 18:02:21 UTC

[GitHub] [kafka] hachikuji opened a new pull request #11737: MINOR: Fix 3.1 upgrade notes for idempotence bug

hachikuji opened a new pull request #11737:
URL: https://github.com/apache/kafka/pull/11737


   I accidentally pulled in the 3.2 notes into the 3.1 branch after cherry-picking https://github.com/apache/kafka/pull/11691. 
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji commented on a change in pull request #11737: MINOR: Fix 3.1 upgrade notes for idempotence bug

Posted by GitBox <gi...@apache.org>.
hachikuji commented on a change in pull request #11737:
URL: https://github.com/apache/kafka/pull/11737#discussion_r801974824



##########
File path: docs/upgrade.html
##########
@@ -19,56 +19,6 @@
 
 <script id="upgrade-template" type="text/x-handlebars-template">
 
-<h5><a id="upgrade_320_notable" href="#upgrade_320_notable">Notable changes in 3.2.0</a></h5>
-    <ul>
-        <li>Idempotence for the producer is enabled by default. In 3.0.0 and 3.1.0, a bug prevented this default from being applied,
-            which meant that idempotence remained disabled unless the user had explicitly set <code>enable.idempotence</code> to true
-            (See <a href="https://issues.apache.org/jira/browse/KAFKA-13598">KAFKA-13598</a>for more details).
-            This issue was fixed and the default is properly applied in 3.0.1, 3.1.1, and 3.2.0.</li>
-    </ul>
-
-<h4><a id="upgrade_3_1_0" href="#upgrade_3_1_0">Upgrading to 3.1.0 from any version 0.8.x through 3.0.x</a></h4>

Review comment:
       Thanks for catching!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji merged pull request #11737: MINOR: Fix 3.1 upgrade notes for idempotence bug

Posted by GitBox <gi...@apache.org>.
hachikuji merged pull request #11737:
URL: https://github.com/apache/kafka/pull/11737


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on a change in pull request #11737: MINOR: Fix 3.1 upgrade notes for idempotence bug

Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #11737:
URL: https://github.com/apache/kafka/pull/11737#discussion_r801230532



##########
File path: docs/upgrade.html
##########
@@ -19,56 +19,6 @@
 
 <script id="upgrade-template" type="text/x-handlebars-template">
 
-<h5><a id="upgrade_320_notable" href="#upgrade_320_notable">Notable changes in 3.2.0</a></h5>
-    <ul>
-        <li>Idempotence for the producer is enabled by default. In 3.0.0 and 3.1.0, a bug prevented this default from being applied,
-            which meant that idempotence remained disabled unless the user had explicitly set <code>enable.idempotence</code> to true
-            (See <a href="https://issues.apache.org/jira/browse/KAFKA-13598">KAFKA-13598</a>for more details).
-            This issue was fixed and the default is properly applied in 3.0.1, 3.1.1, and 3.2.0.</li>
-    </ul>
-
-<h4><a id="upgrade_3_1_0" href="#upgrade_3_1_0">Upgrading to 3.1.0 from any version 0.8.x through 3.0.x</a></h4>

Review comment:
       I think this section should still be kept: `Upgrading to 3.1.0 from any version 0.8.x through 3.0.x`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org