You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2017/01/06 15:16:14 UTC

Review Request 55268: Avoided use of CHECK macros in libprocess.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55268/
-----------------------------------------------------------

Review request for mesos and Kapil Arya.


Bugs: MESOS-6860
    https://issues.apache.org/jira/browse/MESOS-6860


Repository: mesos


Description
-------

Avoided use of CHECK macros in libprocess.


Diffs
-----

  3rdparty/libprocess/src/tests/http_tests.cpp d168ad15da4706fb9c3aa11a125b7dfb5987570d 

Diff: https://reviews.apache.org/r/55268/diff/


Testing
-------

Tested on various Linux configurations in internal CI.


Thanks,

Benjamin Bannier

Re: Review Request 55268: Avoided use of CHECK macros in libprocess.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55268/
-----------------------------------------------------------

(Updated Jan. 10, 2017, 2:19 p.m.)


Review request for mesos and Kapil Arya.


Changes
-------

Rebased.


Bugs: MESOS-6860
    https://issues.apache.org/jira/browse/MESOS-6860


Repository: mesos


Description
-------

Avoided use of CHECK macros in libprocess.


Diffs (updated)
-----

  3rdparty/libprocess/src/tests/http_tests.cpp 96ade15b36c3140bc1c6d8b230f0e26ff979e921 

Diff: https://reviews.apache.org/r/55268/diff/


Testing
-------

Tested on various Linux configurations in internal CI.


Thanks,

Benjamin Bannier

Re: Review Request 55268: Avoided use of CHECK macros in libprocess.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55268/#review160789
-----------------------------------------------------------


Ship it!




Ship It!

- Kapil Arya


On Jan. 6, 2017, 10:16 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55268/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2017, 10:16 a.m.)
> 
> 
> Review request for mesos and Kapil Arya.
> 
> 
> Bugs: MESOS-6860
>     https://issues.apache.org/jira/browse/MESOS-6860
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Avoided use of CHECK macros in libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/http_tests.cpp d168ad15da4706fb9c3aa11a125b7dfb5987570d 
> 
> Diff: https://reviews.apache.org/r/55268/diff/
> 
> 
> Testing
> -------
> 
> Tested on various Linux configurations in internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>