You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2014/09/02 15:41:25 UTC

svn commit: r1621990 - /tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java

Author: markt
Date: Tue Sep  2 13:41:25 2014
New Revision: 1621990

URL: http://svn.apache.org/r1621990
Log:
RFC2109 parser that passes the tests - still several TODOs.

Modified:
    tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java

Modified: tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java?rev=1621990&r1=1621989&r2=1621990&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java (original)
+++ tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java Tue Sep  2 13:41:25 2014
@@ -33,6 +33,7 @@ public class TestCookies {
     private final Cookie BAR_EMPTY = new Cookie("bar", "");
     private final Cookie A = new Cookie("a", "b");
     private final Cookie HASH_EMPTY = new Cookie("#", "");
+    private final Cookie $PORT = new Cookie("$Port", "8080");
 
     @Test
     public void testBasicCookieOld() {
@@ -342,19 +343,19 @@ public class TestCookies {
 
     @Test
     public void v1PortIsIgnoredOld() {
-        doV1PortIsIgnored(false);
+        FOO.setVersion(1);
+        FOO.setDomain("apache.org");
+        A.setVersion(1);
+        test(false, "$Version=1;foo=\"bar\";$Domain=apache.org;$Port=8080;a=b", FOO, A);
     }
 
     @Test
     public void v1PortIsIgnoredRfc6265() {
-        doV1PortIsIgnored(true);
-    }
-
-    private void doV1PortIsIgnored(boolean useRfc6265) {
         FOO.setVersion(1);
         FOO.setDomain("apache.org");
+        $PORT.setVersion(1);
         A.setVersion(1);
-        test(useRfc6265, "$Version=1;foo=\"bar\";$Domain=apache.org;$Port=8080;a=b", FOO, A);
+        test(true, "$Version=1;foo=\"bar\";$Domain=apache.org;$Port=8080;a=b", FOO, $PORT, A);
     }
 
     @Test



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org