You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/18 03:09:28 UTC

[GitHub] [pulsar] yaalsn opened a new pull request, #18081: [improve][ci] Add schedule trigger to get master branch code coverage daily

yaalsn opened a new pull request, #18081:
URL: https://github.com/apache/pulsar/pull/18081

   ### Motivation
   
   To improve code coverage accuracy and have a view of comparing PR and master branch, we need to run master branch CI daily and except flaky tests. The best way is to run master branch CI after PRs merged, but pulsar's Github action runners have few resource, running daily is a trade-off between cost and accuracy.
   
   ### Modifications
   
   - Pulsar CI workflow run daily (12:00, lunch time or sleeping time)
   - Except flaky test group to run code coverage, otherwise we cannot get an accurate base coverage.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: https://github.com/yaalsn/pulsar/pull/14


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] yaalsn commented on pull request #18081: [improve][ci] Add schedule trigger to get master branch code coverage daily

Posted by GitBox <gi...@apache.org>.
yaalsn commented on PR #18081:
URL: https://github.com/apache/pulsar/pull/18081#issuecomment-1283297088

   > I wonder if it makes sense. The use of CI resources should be minimized.
   
   I think running daily is minimized.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] yaalsn commented on pull request #18081: [improve][ci] Add schedule trigger to get master branch code coverage daily

Posted by GitBox <gi...@apache.org>.
yaalsn commented on PR #18081:
URL: https://github.com/apache/pulsar/pull/18081#issuecomment-1290240216

   @lhotari Could you help to take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nodece commented on pull request #18081: [improve][ci] Add schedule trigger to get master branch code coverage daily

Posted by GitBox <gi...@apache.org>.
nodece commented on PR #18081:
URL: https://github.com/apache/pulsar/pull/18081#issuecomment-1281789764

   I wonder if it makes sense. The use of CI resources should be minimized.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #18081: [improve][ci] Add schedule trigger to get master branch code coverage daily

Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #18081:
URL: https://github.com/apache/pulsar/pull/18081#issuecomment-1311651808

   After this PR, the scheduled build gets run on all forks. There's PR #18411 by @tisonkun  to fix this issue. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codecov-commenter commented on pull request #18081: [improve][ci] Add schedule trigger to get master branch code coverage daily

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18081:
URL: https://github.com/apache/pulsar/pull/18081#issuecomment-1281789847

   # [Codecov](https://codecov.io/gh/apache/pulsar/pull/18081?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > :exclamation: No coverage uploaded for pull request base (`master@240ca43`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/pulsar/pull/18081/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/pulsar/pull/18081?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #18081   +/-   ##
   =========================================
     Coverage          ?   70.74%           
     Complexity        ?      437           
   =========================================
     Files             ?       26           
     Lines             ?     2246           
     Branches          ?      245           
   =========================================
     Hits              ?     1589           
     Misses            ?      484           
     Partials          ?      173           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | unittests | `70.74% <0.00%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] yaalsn commented on pull request #18081: [improve][ci] Add schedule trigger to get master branch code coverage daily

Posted by GitBox <gi...@apache.org>.
yaalsn commented on PR #18081:
URL: https://github.com/apache/pulsar/pull/18081#issuecomment-1281897924

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #18081: [improve][ci] Add schedule trigger to get master branch code coverage daily

Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #18081:
URL: https://github.com/apache/pulsar/pull/18081


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Technoboy- closed pull request #18081: [improve][ci] Add schedule trigger to get master branch code coverage daily

Posted by GitBox <gi...@apache.org>.
Technoboy- closed pull request #18081: [improve][ci] Add schedule trigger to get master branch code coverage daily
URL: https://github.com/apache/pulsar/pull/18081


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #18081: [improve][ci] Add schedule trigger to get master branch code coverage daily

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on PR #18081:
URL: https://github.com/apache/pulsar/pull/18081#issuecomment-1292853651

   > I wonder if it makes sense. The use of CI resources should be minimized.
   
   It should be ok. We just update the new code coverage for the master branch per day.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org