You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Yash Sharma <ya...@gmail.com> on 2015/05/12 15:38:47 UTC
Review Request 34105: add jar should be able to take regex path and
should be able to add multiple jars
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/
-----------------------------------------------------------
Review request for lens.
Repository: lens
Description
-------
Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
Jira: https://issues.apache.org/jira/browse/LENS-513
Diffs
-----
lens-cli/pom.xml 7b98523
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java d727ecc
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
Diff: https://reviews.apache.org/r/34105/diff/
Testing
-------
Yes.
Testcases:
New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
Old testcase modified: TestLensConnectionCliCommands#testJarCommands
Test on CLI:
1. -ve test scenario:
lens-shell>add jar /home/yash/Desktop/rt.jarr
No Jars found in the specified path.
lens-shell>add jar /home/yash/Desktop/*.jarr
No Jars found in the specified path.
2. +ve test scenario:
lens-shell>add jar /home/yash/Desktop/*.jar
Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
lens-shell>list resources
type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
type=jar path=/home/yash/Desktop/rt.jar
Pending: Complete testsuite run.
Thanks,
Yash Sharma
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review84250
-----------------------------------------------------------
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java
<https://reviews.apache.org/r/34105/#comment135417>
Ideally we should create these test files in the workspace(i.e. target direcory). We need to fix this behavior for all the tests cases as well. I think we have a seaparate jira for the same.
- Raju Bairishetti
On May 18, 2015, 4:15 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 4:15 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On May 19, 2015, 1:49 a.m., Raju Bairishetti wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java, line 194
> > <https://reviews.apache.org/r/34105/diff/4/?file=962929#file962929line194>
> >
> > As of now we are not testing for hdfs files in unit tests. Can we remove this test method and can we remove getFilePathFromUri(String), createNewPathFromUri(String) and deletePathFromUri() methods as well?
The current tests look fine to me. One is done with file:/// and one without. They are testing two different ways of passing paths.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review84249
-----------------------------------------------------------
On May 18, 2015, 4:15 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 4:15 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review84249
-----------------------------------------------------------
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java
<https://reviews.apache.org/r/34105/#comment135408>
As of now we are not testing for hdfs files in unit tests. Can we remove this test method and can we remove getFilePathFromUri(String), createNewPathFromUri(String) and deletePathFromUri() methods as well?
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java
<https://reviews.apache.org/r/34105/#comment135412>
Can you take care of formatting for (numAdded/foundFiles.length))? Can we have (numAdded / foundFiles.length) like this?
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java
<https://reviews.apache.org/r/34105/#comment135416>
Can we inform the user about the failure in adding/deleting the resources?
This can happen
1) if the given file/dir path does not exist
2) If the given path is not having any matching files or if it is an empty dir
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java
<https://reviews.apache.org/r/34105/#comment135413>
Can we handle FileNotFoundException explicitly and log accordingly? Now it is handling FileNotFoundException as part of IOException.
- Raju Bairishetti
On May 18, 2015, 4:15 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 4:15 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review84248
-----------------------------------------------------------
Do we need to update the **help** section by saying it can accept regex for paths for addFile and addJar commands?
- Raju Bairishetti
On May 18, 2015, 4:15 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 4:15 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
> On May 25, 2015, 2:57 a.m., Raju Bairishetti wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java, line 164
> > <https://reviews.apache.org/r/34105/diff/5/?file=971183#file971183line164>
> >
> > Can we use workspace(i.e. target directory) for test files creation. In this way we are testing for relative paths also.
> >
> > We can have String filenameA = **"target/data_a";** instead of "/tmp/data_a";
Implemented.
> On May 25, 2015, 2:57 a.m., Raju Bairishetti wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java, line 199
> > <https://reviews.apache.org/r/34105/diff/5/?file=971183#file971183line199>
> >
> > I am thinking that we are passing the absolute paths in both tests. Can we pass relative paths in the **testFileCommandsWithRegex** in the method?
> >
> > Can we rename the testHdfsFileCommandsWithRegex method name also as we are not testing the hdfs files?
Makes sense. Implemented.
> On May 25, 2015, 2:57 a.m., Raju Bairishetti wrote:
> > lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java, line 69
> > <https://reviews.apache.org/r/34105/diff/5/?file=971185#file971185line69>
> >
> > Can we avoid uri parsing? Can we get fsPath and fs like this?
> >
> > fsPath = new Path(path);
> > fs = fsPath.getFileSystem(new Configuration());
> >
> > @amareshwari/@prongs any comments/suggestions?
Its basically the same thing - I can make changes based on suggestions.
Path#getFileSystem does the same thing-
public FileSystem getFileSystem(Configuration conf) throws IOException {
return FileSystem.get(this.toUri(), conf);
}
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review85106
-----------------------------------------------------------
On May 25, 2015, 6:09 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 25, 2015, 6:09 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review85106
-----------------------------------------------------------
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java
<https://reviews.apache.org/r/34105/#comment136582>
Can we use workspace(i.e. target directory) for test files creation. In this way we are testing for relative paths also.
We can have String filenameA = **"target/data_a";** instead of "/tmp/data_a";
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java
<https://reviews.apache.org/r/34105/#comment136581>
I am thinking that we are passing the absolute paths in both tests. Can we pass relative paths in the **testFileCommandsWithRegex** in the method?
Can we rename the testHdfsFileCommandsWithRegex method name also as we are not testing the hdfs files?
lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java
<https://reviews.apache.org/r/34105/#comment136583>
Can you take care of formatting? Space between **)** and **{**
lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java
<https://reviews.apache.org/r/34105/#comment136585>
Can we avoid uri parsing? Can we get fsPath and fs like this?
fsPath = new Path(path);
fs = fsPath.getFileSystem(new Configuration());
@amareshwari/@prongs any comments/suggestions?
lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java
<https://reviews.apache.org/r/34105/#comment136584>
Can we remvoe blank line?
- Raju Bairishetti
On May 24, 2015, 10:36 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 24, 2015, 10:36 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
> On May 25, 2015, 3:12 a.m., Raju Bairishetti wrote:
> > lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java, line 153
> > <https://reviews.apache.org/r/34105/diff/5/?file=971185#file971185line153>
> >
> > Can we take care of formatting? Seems formatting required in multiple places in this patch.
Fixed.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review85108
-----------------------------------------------------------
On May 25, 2015, 6:09 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 25, 2015, 6:09 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review85108
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java
<https://reviews.apache.org/r/34105/#comment136588>
Can we take care of formatting? Seems formatting required in multiple places in this patch.
lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java
<https://reviews.apache.org/r/34105/#comment136587>
Can we close the input stream? Seems we are not closing the inputstream
IOUtils.closeQuietly(inputstream)
- Raju Bairishetti
On May 24, 2015, 10:36 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 24, 2015, 10:36 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review85366
-----------------------------------------------------------
Ship it!
LGTM( non-binding)
- Raju Bairishetti
On May 26, 2015, 4:30 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 26, 2015, 4:30 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
> On June 2, 2015, 2 a.m., Raju Bairishetti wrote:
> > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java, line 49
> > <https://reviews.apache.org/r/34105/diff/9/?file=975201#file975201line49>
> >
> > Do we require all three **path**, **uri** and **fsPath**? Can you check whether we can have only one **path** variable(i.e. fsPath)?
Implemented. Merged code to extract required info out of fsPath.
> On June 2, 2015, 2 a.m., Raju Bairishetti wrote:
> > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java, line 60
> > <https://reviews.apache.org/r/34105/diff/9/?file=975201#file975201line60>
> >
> > Init() method actually initializes fs and finding the matching paths also. It would be better if we move finding matched files logic out of init() method.
Having path matching in init ensures that we have the final paths ready as soon as we have an instance of ScannedPaths. So we should be able to initialize the instance and use the iterator on the matched paths direcctly.
> On June 2, 2015, 2 a.m., Raju Bairishetti wrote:
> > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java, line 128
> > <https://reviews.apache.org/r/34105/diff/9/?file=975201#file975201line128>
> >
> > Name says filtering the files by **type** of resource. But it filters only by **jar** resource type. Can we have suitable method name?
Makes Sense. Implemented.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review86136
-----------------------------------------------------------
On June 2, 2015, 9:29 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 9:29 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
> lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> New build results -
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.332 s]
> [INFO] Lens ............................................... SUCCESS [ 3.057 s]
> [INFO] Lens API ........................................... SUCCESS [ 17.761 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.353 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:20 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 20.226 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 16.047 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:41 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.681 s]
> [INFO] Lens Server ........................................ SUCCESS [06:20 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.356 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:04 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.522 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.028 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:34 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.640 s]
> [INFO] Lens Regression .................................... SUCCESS [ 6.617 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:01 min
> [INFO] Finished at: 2015-06-02T14:11:56+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review86136
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java
<https://reviews.apache.org/r/34105/#comment138055>
Do we require all three **path**, **uri** and **fsPath**? Can you check whether we can have only one **path** variable(i.e. fsPath)?
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java
<https://reviews.apache.org/r/34105/#comment138057>
Init() method actually initializes fs and finding the matching paths also. It would be better if we move finding matched files logic out of init() method.
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java
<https://reviews.apache.org/r/34105/#comment138058>
Name says filtering the files by **type** of resource. But it filters only by **jar** resource type. Can we have suitable method name?
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java
<https://reviews.apache.org/r/34105/#comment138059>
Can we remove this blank line as per sun java conventions?
- Raju Bairishetti
On May 31, 2015, 6:26 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 31, 2015, 6:26 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
> lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review85931
-----------------------------------------------------------
lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java
<https://reviews.apache.org/r/34105/#comment137754>
Let's also test for `jar_order`.
lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java
<https://reviews.apache.org/r/34105/#comment137753>
the if and fail can be merged in single line.
`Assert.assertEquals(sc.getMatchedCounts(), 0, "Incorrect number of matches found");`. Similar for other such blocks
Please update the result of `mvn clean install` in testing done.
- Rajat Khandelwal
On May 31, 2015, 11:56 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 31, 2015, 11:56 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
> lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review86961
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On June 6, 2015, 12:48 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated June 6, 2015, 12:48 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
> lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> New build results -
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.332 s]
> [INFO] Lens ............................................... SUCCESS [ 3.057 s]
> [INFO] Lens API ........................................... SUCCESS [ 17.761 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.353 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:20 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 20.226 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 16.047 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:41 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.681 s]
> [INFO] Lens Server ........................................ SUCCESS [06:20 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.356 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:04 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.522 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.028 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:34 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.640 s]
> [INFO] Lens Regression .................................... SUCCESS [ 6.617 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:01 min
> [INFO] Finished at: 2015-06-02T14:11:56+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/
-----------------------------------------------------------
(Updated June 6, 2015, 7:18 a.m.)
Review request for lens.
Changes
-------
Implemented new review comments.
Build results-
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.234 s]
[INFO] Lens ............................................... SUCCESS [ 3.300 s]
[INFO] Lens API ........................................... SUCCESS [ 18.254 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 20.630 s]
[INFO] Lens Cube .......................................... SUCCESS [03:05 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.407 s]
[INFO] Lens Query Library ................................. SUCCESS [ 15.674 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:35 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 35.225 s]
[INFO] Lens Server ........................................ SUCCESS [04:49 min]
[INFO] Lens client ........................................ SUCCESS [ 36.588 s]
[INFO] Lens CLI ........................................... SUCCESS [02:06 min]
[INFO] Lens Examples ...................................... SUCCESS [ 10.305 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.286 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:14 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.495 s]
[INFO] Lens Regression .................................... SUCCESS [ 12.271 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 16:57 min
[INFO] Finished at: 2015-06-06T12:27:21+05:30
[INFO] Final Memory: 121M/393M
[INFO] ------------------------------------------------------------------------
Repository: lens
Description
-------
Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
Jira: https://issues.apache.org/jira/browse/LENS-513
Diffs (updated)
-----
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java PRE-CREATION
Diff: https://reviews.apache.org/r/34105/diff/
Testing
-------
New build results -
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.332 s]
[INFO] Lens ............................................... SUCCESS [ 3.057 s]
[INFO] Lens API ........................................... SUCCESS [ 17.761 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 21.353 s]
[INFO] Lens Cube .......................................... SUCCESS [03:20 min]
[INFO] Lens DB storage .................................... SUCCESS [ 20.226 s]
[INFO] Lens Query Library ................................. SUCCESS [ 16.047 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:41 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.681 s]
[INFO] Lens Server ........................................ SUCCESS [06:20 min]
[INFO] Lens client ........................................ SUCCESS [ 36.356 s]
[INFO] Lens CLI ........................................... SUCCESS [02:04 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.522 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.028 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:34 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.640 s]
[INFO] Lens Regression .................................... SUCCESS [ 6.617 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:01 min
[INFO] Finished at: 2015-06-02T14:11:56+05:30
[INFO] Final Memory: 120M/389M
[INFO] ------------------------------------------------------------------------
Yes.
Testcases:
New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
Old testcase modified: TestLensConnectionCliCommands#testJarCommands
Test on CLI:
1. -ve test scenario:
lens-shell>add jar /home/yash/Desktop/rt.jarr
No Jars found in the specified path.
lens-shell>add jar /home/yash/Desktop/*.jarr
No Jars found in the specified path.
2. +ve test scenario:
lens-shell>add jar /home/yash/Desktop/*.jar
Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
lens-shell>list resources
type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
type=jar path=/home/yash/Desktop/rt.jar
Complete build with testcases:
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
[INFO] Lens ............................................... SUCCESS [ 3.751 s]
[INFO] Lens API ........................................... SUCCESS [ 19.844 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
[INFO] Lens Cube .......................................... SUCCESS [03:06 min]
[INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
[INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
[INFO] Lens Server ........................................ SUCCESS [06:03 min]
[INFO] Lens client ........................................ SUCCESS [ 41.219 s]
[INFO] Lens CLI ........................................... SUCCESS [02:09 min]
[INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
[INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:46 min
[INFO] Finished at: 2015-05-12T19:44:01+05:30
[INFO] Final Memory: 120M/389M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review86397
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java
<https://reviews.apache.org/r/34105/#comment138365>
This line is common in both `if` and `else`. Can be taken out.
- Rajat Khandelwal
On June 3, 2015, 2:15 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 2:15 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
> lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> New build results -
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.332 s]
> [INFO] Lens ............................................... SUCCESS [ 3.057 s]
> [INFO] Lens API ........................................... SUCCESS [ 17.761 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.353 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:20 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 20.226 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 16.047 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:41 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.681 s]
> [INFO] Lens Server ........................................ SUCCESS [06:20 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.356 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:04 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.522 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.028 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:34 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.640 s]
> [INFO] Lens Regression .................................... SUCCESS [ 6.617 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:01 min
> [INFO] Finished at: 2015-06-02T14:11:56+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/
-----------------------------------------------------------
(Updated June 3, 2015, 8:45 a.m.)
Review request for lens.
Changes
-------
How about this new patch ?
- Moved all the heave weight path matching to iterator
- Added additional check so that we dont compute the matches if its been computed already
Build results-
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.048 s]
[INFO] Lens ............................................... SUCCESS [ 2.558 s]
[INFO] Lens API ........................................... SUCCESS [ 17.213 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 21.755 s]
[INFO] Lens Cube .......................................... SUCCESS [02:57 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.573 s]
[INFO] Lens Query Library ................................. SUCCESS [ 14.789 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:36 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.636 s]
[INFO] Lens Server ........................................ SUCCESS [05:23 min]
[INFO] Lens client ........................................ SUCCESS [ 35.120 s]
[INFO] Lens CLI ........................................... SUCCESS [02:04 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.753 s]
[INFO] Lens Distribution .................................. SUCCESS [ 7.412 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:35 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.742 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.437 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:36 min
[INFO] Finished at: 2015-06-03T14:11:23+05:30
[INFO] Final Memory: 121M/409M
[INFO] ------------------------------------------------------------------------
Repository: lens
Description
-------
Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
Jira: https://issues.apache.org/jira/browse/LENS-513
Diffs (updated)
-----
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java PRE-CREATION
Diff: https://reviews.apache.org/r/34105/diff/
Testing
-------
New build results -
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.332 s]
[INFO] Lens ............................................... SUCCESS [ 3.057 s]
[INFO] Lens API ........................................... SUCCESS [ 17.761 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 21.353 s]
[INFO] Lens Cube .......................................... SUCCESS [03:20 min]
[INFO] Lens DB storage .................................... SUCCESS [ 20.226 s]
[INFO] Lens Query Library ................................. SUCCESS [ 16.047 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:41 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.681 s]
[INFO] Lens Server ........................................ SUCCESS [06:20 min]
[INFO] Lens client ........................................ SUCCESS [ 36.356 s]
[INFO] Lens CLI ........................................... SUCCESS [02:04 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.522 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.028 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:34 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.640 s]
[INFO] Lens Regression .................................... SUCCESS [ 6.617 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:01 min
[INFO] Finished at: 2015-06-02T14:11:56+05:30
[INFO] Final Memory: 120M/389M
[INFO] ------------------------------------------------------------------------
Yes.
Testcases:
New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
Old testcase modified: TestLensConnectionCliCommands#testJarCommands
Test on CLI:
1. -ve test scenario:
lens-shell>add jar /home/yash/Desktop/rt.jarr
No Jars found in the specified path.
lens-shell>add jar /home/yash/Desktop/*.jarr
No Jars found in the specified path.
2. +ve test scenario:
lens-shell>add jar /home/yash/Desktop/*.jar
Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
lens-shell>list resources
type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
type=jar path=/home/yash/Desktop/rt.jar
Complete build with testcases:
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
[INFO] Lens ............................................... SUCCESS [ 3.751 s]
[INFO] Lens API ........................................... SUCCESS [ 19.844 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
[INFO] Lens Cube .......................................... SUCCESS [03:06 min]
[INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
[INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
[INFO] Lens Server ........................................ SUCCESS [06:03 min]
[INFO] Lens client ........................................ SUCCESS [ 41.219 s]
[INFO] Lens CLI ........................................... SUCCESS [02:09 min]
[INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
[INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:46 min
[INFO] Finished at: 2015-05-12T19:44:01+05:30
[INFO] Final Memory: 120M/389M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/
-----------------------------------------------------------
(Updated June 2, 2015, 9:29 a.m.)
Review request for lens.
Changes
-------
Adding build results.
Repository: lens
Description
-------
Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
Jira: https://issues.apache.org/jira/browse/LENS-513
Diffs
-----
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java PRE-CREATION
Diff: https://reviews.apache.org/r/34105/diff/
Testing (updated)
-------
New build results -
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.332 s]
[INFO] Lens ............................................... SUCCESS [ 3.057 s]
[INFO] Lens API ........................................... SUCCESS [ 17.761 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 21.353 s]
[INFO] Lens Cube .......................................... SUCCESS [03:20 min]
[INFO] Lens DB storage .................................... SUCCESS [ 20.226 s]
[INFO] Lens Query Library ................................. SUCCESS [ 16.047 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:41 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.681 s]
[INFO] Lens Server ........................................ SUCCESS [06:20 min]
[INFO] Lens client ........................................ SUCCESS [ 36.356 s]
[INFO] Lens CLI ........................................... SUCCESS [02:04 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.522 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.028 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:34 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.640 s]
[INFO] Lens Regression .................................... SUCCESS [ 6.617 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:01 min
[INFO] Finished at: 2015-06-02T14:11:56+05:30
[INFO] Final Memory: 120M/389M
[INFO] ------------------------------------------------------------------------
Yes.
Testcases:
New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
Old testcase modified: TestLensConnectionCliCommands#testJarCommands
Test on CLI:
1. -ve test scenario:
lens-shell>add jar /home/yash/Desktop/rt.jarr
No Jars found in the specified path.
lens-shell>add jar /home/yash/Desktop/*.jarr
No Jars found in the specified path.
2. +ve test scenario:
lens-shell>add jar /home/yash/Desktop/*.jar
Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
lens-shell>list resources
type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
type=jar path=/home/yash/Desktop/rt.jar
Complete build with testcases:
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
[INFO] Lens ............................................... SUCCESS [ 3.751 s]
[INFO] Lens API ........................................... SUCCESS [ 19.844 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
[INFO] Lens Cube .......................................... SUCCESS [03:06 min]
[INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
[INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
[INFO] Lens Server ........................................ SUCCESS [06:03 min]
[INFO] Lens client ........................................ SUCCESS [ 41.219 s]
[INFO] Lens CLI ........................................... SUCCESS [02:09 min]
[INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
[INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:46 min
[INFO] Finished at: 2015-05-12T19:44:01+05:30
[INFO] Final Memory: 120M/389M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/
-----------------------------------------------------------
(Updated June 2, 2015, 9:29 a.m.)
Review request for lens.
Changes
-------
Implemented new revieww comments.
Repository: lens
Description
-------
Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
Jira: https://issues.apache.org/jira/browse/LENS-513
Diffs (updated)
-----
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java PRE-CREATION
Diff: https://reviews.apache.org/r/34105/diff/
Testing
-------
Yes.
Testcases:
New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
Old testcase modified: TestLensConnectionCliCommands#testJarCommands
Test on CLI:
1. -ve test scenario:
lens-shell>add jar /home/yash/Desktop/rt.jarr
No Jars found in the specified path.
lens-shell>add jar /home/yash/Desktop/*.jarr
No Jars found in the specified path.
2. +ve test scenario:
lens-shell>add jar /home/yash/Desktop/*.jar
Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
lens-shell>list resources
type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
type=jar path=/home/yash/Desktop/rt.jar
Complete build with testcases:
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
[INFO] Lens ............................................... SUCCESS [ 3.751 s]
[INFO] Lens API ........................................... SUCCESS [ 19.844 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
[INFO] Lens Cube .......................................... SUCCESS [03:06 min]
[INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
[INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
[INFO] Lens Server ........................................ SUCCESS [06:03 min]
[INFO] Lens client ........................................ SUCCESS [ 41.219 s]
[INFO] Lens CLI ........................................... SUCCESS [02:09 min]
[INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
[INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:46 min
[INFO] Finished at: 2015-05-12T19:44:01+05:30
[INFO] Final Memory: 120M/389M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
> On June 2, 2015, 9:16 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java, line 49
> > <https://reviews.apache.org/r/34105/diff/9/?file=975201#file975201line49>
> >
> > I think what Raju is trying to say is, that member variables of a class should be the things the class consists of.
> >
> > It doesn't make sense that ScannedPaths should consist of two Strings, one URI, one FileSyste, one Path. Most of these things can be temporary and passed between methods while initializing.
> >
> > Another thing is, everything basically happens in constructor, so functions can be cut down.
> >
> > Also, should the exceptions be propagated?
>
> Yash Sharma wrote:
> - I have removed instance variables which can be derrived from other variable. Please have a look if we can cut it down further.
> - Are we talking of removing the init() entirely and to add the code to the constructor directly ?
>
> Raju Bairishetti wrote:
> @Yash It would be better if we do not include listing logic in the constructor.
>
> Yash Sharma wrote:
> Should we have a new method call that computes the matched paths and returns an iterator() ? Thoughts ?
>
> Rajat Khandelwal wrote:
> The current thing looks mostly okay to me.
>
> Rajat Khandelwal wrote:
> The design that you have implemented can be done using lombok's lazy getter. https://projectlombok.org/features/GetterLazy.html
Implemented. Let me know if everything looks good.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review86184
-----------------------------------------------------------
On June 6, 2015, 7:18 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated June 6, 2015, 7:18 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
> lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> New build results -
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.332 s]
> [INFO] Lens ............................................... SUCCESS [ 3.057 s]
> [INFO] Lens API ........................................... SUCCESS [ 17.761 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.353 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:20 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 20.226 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 16.047 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:41 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.681 s]
> [INFO] Lens Server ........................................ SUCCESS [06:20 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.356 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:04 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.522 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.028 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:34 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.640 s]
> [INFO] Lens Regression .................................... SUCCESS [ 6.617 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:01 min
> [INFO] Finished at: 2015-06-02T14:11:56+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Raju Bairishetti <ra...@gmail.com>.
> On June 2, 2015, 9:16 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java, line 49
> > <https://reviews.apache.org/r/34105/diff/9/?file=975201#file975201line49>
> >
> > I think what Raju is trying to say is, that member variables of a class should be the things the class consists of.
> >
> > It doesn't make sense that ScannedPaths should consist of two Strings, one URI, one FileSyste, one Path. Most of these things can be temporary and passed between methods while initializing.
> >
> > Another thing is, everything basically happens in constructor, so functions can be cut down.
> >
> > Also, should the exceptions be propagated?
>
> Yash Sharma wrote:
> - I have removed instance variables which can be derrived from other variable. Please have a look if we can cut it down further.
> - Are we talking of removing the init() entirely and to add the code to the constructor directly ?
>
> Raju Bairishetti wrote:
> @Yash It would be better if we do not include listing logic in the constructor.
>
> Yash Sharma wrote:
> Should we have a new method call that computes the matched paths and returns an iterator() ? Thoughts ?
>
> Rajat Khandelwal wrote:
> The current thing looks mostly okay to me.
>
> Rajat Khandelwal wrote:
> The design that you have implemented can be done using lombok's lazy getter. https://projectlombok.org/features/GetterLazy.html
>
> Yash Sharma wrote:
> Implemented. Let me know if everything looks good.
LGTM +1
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review86184
-----------------------------------------------------------
On June 6, 2015, 7:18 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated June 6, 2015, 7:18 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
> lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> New build results -
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.332 s]
> [INFO] Lens ............................................... SUCCESS [ 3.057 s]
> [INFO] Lens API ........................................... SUCCESS [ 17.761 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.353 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:20 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 20.226 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 16.047 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:41 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.681 s]
> [INFO] Lens Server ........................................ SUCCESS [06:20 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.356 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:04 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.522 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.028 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:34 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.640 s]
> [INFO] Lens Regression .................................... SUCCESS [ 6.617 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:01 min
> [INFO] Finished at: 2015-06-02T14:11:56+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
> On June 2, 2015, 9:16 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java, line 49
> > <https://reviews.apache.org/r/34105/diff/9/?file=975201#file975201line49>
> >
> > I think what Raju is trying to say is, that member variables of a class should be the things the class consists of.
> >
> > It doesn't make sense that ScannedPaths should consist of two Strings, one URI, one FileSyste, one Path. Most of these things can be temporary and passed between methods while initializing.
> >
> > Another thing is, everything basically happens in constructor, so functions can be cut down.
> >
> > Also, should the exceptions be propagated?
- I have removed instance variables which can be derrived from other variable. Please have a look if we can cut it down further.
- Are we talking of removing the init() entirely and to add the code to the constructor directly ?
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review86184
-----------------------------------------------------------
On June 2, 2015, 9:29 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 9:29 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
> lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> New build results -
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.332 s]
> [INFO] Lens ............................................... SUCCESS [ 3.057 s]
> [INFO] Lens API ........................................... SUCCESS [ 17.761 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.353 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:20 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 20.226 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 16.047 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:41 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.681 s]
> [INFO] Lens Server ........................................ SUCCESS [06:20 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.356 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:04 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.522 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.028 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:34 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.640 s]
> [INFO] Lens Regression .................................... SUCCESS [ 6.617 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:01 min
> [INFO] Finished at: 2015-06-02T14:11:56+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On June 2, 2015, 2:46 p.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java, line 49
> > <https://reviews.apache.org/r/34105/diff/9/?file=975201#file975201line49>
> >
> > I think what Raju is trying to say is, that member variables of a class should be the things the class consists of.
> >
> > It doesn't make sense that ScannedPaths should consist of two Strings, one URI, one FileSyste, one Path. Most of these things can be temporary and passed between methods while initializing.
> >
> > Another thing is, everything basically happens in constructor, so functions can be cut down.
> >
> > Also, should the exceptions be propagated?
>
> Yash Sharma wrote:
> - I have removed instance variables which can be derrived from other variable. Please have a look if we can cut it down further.
> - Are we talking of removing the init() entirely and to add the code to the constructor directly ?
>
> Raju Bairishetti wrote:
> @Yash It would be better if we do not include listing logic in the constructor.
>
> Yash Sharma wrote:
> Should we have a new method call that computes the matched paths and returns an iterator() ? Thoughts ?
The current thing looks mostly okay to me.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review86184
-----------------------------------------------------------
On June 3, 2015, 2:15 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 2:15 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
> lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> New build results -
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.332 s]
> [INFO] Lens ............................................... SUCCESS [ 3.057 s]
> [INFO] Lens API ........................................... SUCCESS [ 17.761 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.353 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:20 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 20.226 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 16.047 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:41 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.681 s]
> [INFO] Lens Server ........................................ SUCCESS [06:20 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.356 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:04 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.522 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.028 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:34 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.640 s]
> [INFO] Lens Regression .................................... SUCCESS [ 6.617 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:01 min
> [INFO] Finished at: 2015-06-02T14:11:56+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On June 2, 2015, 2:46 p.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java, line 49
> > <https://reviews.apache.org/r/34105/diff/9/?file=975201#file975201line49>
> >
> > I think what Raju is trying to say is, that member variables of a class should be the things the class consists of.
> >
> > It doesn't make sense that ScannedPaths should consist of two Strings, one URI, one FileSyste, one Path. Most of these things can be temporary and passed between methods while initializing.
> >
> > Another thing is, everything basically happens in constructor, so functions can be cut down.
> >
> > Also, should the exceptions be propagated?
>
> Yash Sharma wrote:
> - I have removed instance variables which can be derrived from other variable. Please have a look if we can cut it down further.
> - Are we talking of removing the init() entirely and to add the code to the constructor directly ?
>
> Raju Bairishetti wrote:
> @Yash It would be better if we do not include listing logic in the constructor.
>
> Yash Sharma wrote:
> Should we have a new method call that computes the matched paths and returns an iterator() ? Thoughts ?
>
> Rajat Khandelwal wrote:
> The current thing looks mostly okay to me.
The design that you have implemented can be done using lombok's lazy getter. https://projectlombok.org/features/GetterLazy.html
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review86184
-----------------------------------------------------------
On June 3, 2015, 2:15 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 2:15 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
> lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> New build results -
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.332 s]
> [INFO] Lens ............................................... SUCCESS [ 3.057 s]
> [INFO] Lens API ........................................... SUCCESS [ 17.761 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.353 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:20 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 20.226 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 16.047 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:41 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.681 s]
> [INFO] Lens Server ........................................ SUCCESS [06:20 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.356 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:04 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.522 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.028 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:34 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.640 s]
> [INFO] Lens Regression .................................... SUCCESS [ 6.617 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:01 min
> [INFO] Finished at: 2015-06-02T14:11:56+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
> On June 2, 2015, 9:16 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java, line 49
> > <https://reviews.apache.org/r/34105/diff/9/?file=975201#file975201line49>
> >
> > I think what Raju is trying to say is, that member variables of a class should be the things the class consists of.
> >
> > It doesn't make sense that ScannedPaths should consist of two Strings, one URI, one FileSyste, one Path. Most of these things can be temporary and passed between methods while initializing.
> >
> > Another thing is, everything basically happens in constructor, so functions can be cut down.
> >
> > Also, should the exceptions be propagated?
>
> Yash Sharma wrote:
> - I have removed instance variables which can be derrived from other variable. Please have a look if we can cut it down further.
> - Are we talking of removing the init() entirely and to add the code to the constructor directly ?
>
> Raju Bairishetti wrote:
> @Yash It would be better if we do not include listing logic in the constructor.
Should we have a new method call that computes the matched paths and returns an iterator() ? Thoughts ?
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review86184
-----------------------------------------------------------
On June 2, 2015, 9:29 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 9:29 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
> lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> New build results -
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.332 s]
> [INFO] Lens ............................................... SUCCESS [ 3.057 s]
> [INFO] Lens API ........................................... SUCCESS [ 17.761 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.353 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:20 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 20.226 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 16.047 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:41 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.681 s]
> [INFO] Lens Server ........................................ SUCCESS [06:20 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.356 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:04 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.522 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.028 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:34 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.640 s]
> [INFO] Lens Regression .................................... SUCCESS [ 6.617 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:01 min
> [INFO] Finished at: 2015-06-02T14:11:56+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Raju Bairishetti <ra...@gmail.com>.
> On June 2, 2015, 9:16 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java, line 49
> > <https://reviews.apache.org/r/34105/diff/9/?file=975201#file975201line49>
> >
> > I think what Raju is trying to say is, that member variables of a class should be the things the class consists of.
> >
> > It doesn't make sense that ScannedPaths should consist of two Strings, one URI, one FileSyste, one Path. Most of these things can be temporary and passed between methods while initializing.
> >
> > Another thing is, everything basically happens in constructor, so functions can be cut down.
> >
> > Also, should the exceptions be propagated?
>
> Yash Sharma wrote:
> - I have removed instance variables which can be derrived from other variable. Please have a look if we can cut it down further.
> - Are we talking of removing the init() entirely and to add the code to the constructor directly ?
@Yash It would be better if we do not include listing logic in the constructor.
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review86184
-----------------------------------------------------------
On June 2, 2015, 9:29 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 9:29 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
> lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> New build results -
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.332 s]
> [INFO] Lens ............................................... SUCCESS [ 3.057 s]
> [INFO] Lens API ........................................... SUCCESS [ 17.761 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.353 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:20 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 20.226 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 16.047 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:41 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.681 s]
> [INFO] Lens Server ........................................ SUCCESS [06:20 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.356 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:04 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.522 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.028 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:34 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.640 s]
> [INFO] Lens Regression .................................... SUCCESS [ 6.617 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:01 min
> [INFO] Finished at: 2015-06-02T14:11:56+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review86184
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java
<https://reviews.apache.org/r/34105/#comment138124>
I think what Raju is trying to say is, that member variables of a class should be the things the class consists of.
It doesn't make sense that ScannedPaths should consist of two Strings, one URI, one FileSyste, one Path. Most of these things can be temporary and passed between methods while initializing.
Another thing is, everything basically happens in constructor, so functions can be cut down.
Also, should the exceptions be propagated?
- Rajat Khandelwal
On May 31, 2015, 11:56 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 31, 2015, 11:56 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
> lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
> On June 2, 2015, 2:09 a.m., Raju Bairishetti wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java, line 102
> > <https://reviews.apache.org/r/34105/diff/9/?file=975199#file975199line102>
> >
> > Throws null pointer exception if it is not able to parse the path? It does not fail any tests now as all are passing paths with right scheme.
I was expecting the catch block to handle any exception that might come up in this context. Have added a dedicated null check now as added measure.
> On June 2, 2015, 2:09 a.m., Raju Bairishetti wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java, line 109
> > <https://reviews.apache.org/r/34105/diff/9/?file=975199#file975199line109>
> >
> > Unreachable line?
Merged the return from try and catch blocks as a single statement.
> On June 2, 2015, 2:09 a.m., Raju Bairishetti wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java, line 115
> > <https://reviews.apache.org/r/34105/diff/9/?file=975199#file975199line115>
> >
> > Can we handle null case?
Fixed same as above.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review86141
-----------------------------------------------------------
On June 2, 2015, 9:29 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 9:29 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
> lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> New build results -
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.332 s]
> [INFO] Lens ............................................... SUCCESS [ 3.057 s]
> [INFO] Lens API ........................................... SUCCESS [ 17.761 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.353 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:20 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 20.226 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 16.047 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:41 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.681 s]
> [INFO] Lens Server ........................................ SUCCESS [06:20 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.356 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:04 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.522 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.028 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:34 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.640 s]
> [INFO] Lens Regression .................................... SUCCESS [ 6.617 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:01 min
> [INFO] Finished at: 2015-06-02T14:11:56+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review86141
-----------------------------------------------------------
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java
<https://reviews.apache.org/r/34105/#comment138064>
Throws null pointer exception if it is not able to parse the path? It does not fail any tests now as all are passing paths with right scheme.
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java
<https://reviews.apache.org/r/34105/#comment138063>
Unreachable line?
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java
<https://reviews.apache.org/r/34105/#comment138065>
Can we handle null case?
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java
<https://reviews.apache.org/r/34105/#comment138062>
Unreachable line?
- Raju Bairishetti
On May 31, 2015, 6:26 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 31, 2015, 6:26 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
> lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/
-----------------------------------------------------------
(Updated May 31, 2015, 6:26 p.m.)
Review request for lens.
Changes
-------
Implemented new review comments.
Repository: lens
Description
-------
Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
Jira: https://issues.apache.org/jira/browse/LENS-513
Diffs (updated)
-----
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java PRE-CREATION
Diff: https://reviews.apache.org/r/34105/diff/
Testing
-------
Yes.
Testcases:
New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
Old testcase modified: TestLensConnectionCliCommands#testJarCommands
Test on CLI:
1. -ve test scenario:
lens-shell>add jar /home/yash/Desktop/rt.jarr
No Jars found in the specified path.
lens-shell>add jar /home/yash/Desktop/*.jarr
No Jars found in the specified path.
2. +ve test scenario:
lens-shell>add jar /home/yash/Desktop/*.jar
Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
lens-shell>list resources
type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
type=jar path=/home/yash/Desktop/rt.jar
Complete build with testcases:
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
[INFO] Lens ............................................... SUCCESS [ 3.751 s]
[INFO] Lens API ........................................... SUCCESS [ 19.844 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
[INFO] Lens Cube .......................................... SUCCESS [03:06 min]
[INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
[INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
[INFO] Lens Server ........................................ SUCCESS [06:03 min]
[INFO] Lens client ........................................ SUCCESS [ 41.219 s]
[INFO] Lens CLI ........................................... SUCCESS [02:09 min]
[INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
[INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:46 min
[INFO] Finished at: 2015-05-12T19:44:01+05:30
[INFO] Final Memory: 120M/389M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
> On May 29, 2015, 9:40 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java, line 101
> > <https://reviews.apache.org/r/34105/diff/8/?file=973467#file973467line101>
> >
> > Should we check for existence? Just wondering...
Yes Better. Added check.
> On May 29, 2015, 9:40 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java, line 151
> > <https://reviews.apache.org/r/34105/diff/8/?file=973468#file973468line151>
> >
> > will never come here. explained below.
Have changed the ScannedPath to handle unmatched path and return null for unmatched patterns.
> On May 29, 2015, 9:40 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java, line 44
> > <https://reviews.apache.org/r/34105/diff/8/?file=973469#file973469line44>
> >
> > ScannedPaths is getting used in cli, so cli tests are pretty much integrations tests for this. Let's write unit tests also for this class.
Implemented.
> On May 29, 2015, 9:40 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java, line 184
> > <https://reviews.apache.org/r/34105/diff/8/?file=973469#file973469line184>
> >
> > So you're assuming finalPaths is never null by the time `itertor()` is called.
> >
> > And if so, `iterator()` never returns null. So you don't need to handle that case in its callers.
As mentioned above, iterator will have null value for unmatched patterns.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review85702
-----------------------------------------------------------
On May 31, 2015, 6:26 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 31, 2015, 6:26 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
> lens-server/src/test/java/org/apache/lens/server/util/TestScannedPaths.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review85702
-----------------------------------------------------------
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java
<https://reviews.apache.org/r/34105/#comment137434>
Should we check for existence? Just wondering...
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java
<https://reviews.apache.org/r/34105/#comment137437>
will never come here. explained below.
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java
<https://reviews.apache.org/r/34105/#comment137436>
ScannedPaths is getting used in cli, so cli tests are pretty much integrations tests for this. Let's write unit tests also for this class.
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java
<https://reviews.apache.org/r/34105/#comment137435>
So you're assuming finalPaths is never null by the time `itertor()` is called.
And if so, `iterator()` never returns null. So you don't need to handle that case in its callers.
- Rajat Khandelwal
On May 28, 2015, 2:14 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 2:14 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/
-----------------------------------------------------------
(Updated May 28, 2015, 8:44 a.m.)
Review request for lens.
Changes
-------
Implemented review comments.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.790 s]
[INFO] Lens ............................................... SUCCESS [ 4.371 s]
[INFO] Lens API ........................................... SUCCESS [ 17.194 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 23.262 s]
[INFO] Lens Cube .......................................... SUCCESS [03:04 min]
[INFO] Lens DB storage .................................... SUCCESS [ 20.814 s]
[INFO] Lens Query Library ................................. SUCCESS [ 15.829 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:42 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.726 s]
[INFO] Lens Server ........................................ SUCCESS [05:45 min]
[INFO] Lens client ........................................ SUCCESS [ 34.110 s]
[INFO] Lens CLI ........................................... SUCCESS [02:09 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.406 s]
[INFO] Lens Distribution .................................. SUCCESS [ 7.824 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:31 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.484 s]
[INFO] Lens Regression .................................... SUCCESS [ 7.528 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:15 min
[INFO] Finished at: 2015-05-28T13:45:58+05:30
[INFO] Final Memory: 121M/381M
[INFO] ------------------------------------------------------------------------
Repository: lens
Description
-------
Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
Jira: https://issues.apache.org/jira/browse/LENS-513
Diffs (updated)
-----
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
Diff: https://reviews.apache.org/r/34105/diff/
Testing
-------
Yes.
Testcases:
New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
Old testcase modified: TestLensConnectionCliCommands#testJarCommands
Test on CLI:
1. -ve test scenario:
lens-shell>add jar /home/yash/Desktop/rt.jarr
No Jars found in the specified path.
lens-shell>add jar /home/yash/Desktop/*.jarr
No Jars found in the specified path.
2. +ve test scenario:
lens-shell>add jar /home/yash/Desktop/*.jar
Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
lens-shell>list resources
type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
type=jar path=/home/yash/Desktop/rt.jar
Complete build with testcases:
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
[INFO] Lens ............................................... SUCCESS [ 3.751 s]
[INFO] Lens API ........................................... SUCCESS [ 19.844 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
[INFO] Lens Cube .......................................... SUCCESS [03:06 min]
[INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
[INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
[INFO] Lens Server ........................................ SUCCESS [06:03 min]
[INFO] Lens client ........................................ SUCCESS [ 41.219 s]
[INFO] Lens CLI ........................................... SUCCESS [02:09 min]
[INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
[INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:46 min
[INFO] Finished at: 2015-05-12T19:44:01+05:30
[INFO] Final Memory: 120M/389M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
> On May 27, 2015, 3:07 p.m., Rajat Khandelwal wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java, line 98
> > <https://reviews.apache.org/r/34105/diff/7/?file=971535#file971535line98>
> >
> > I believe the name is misleading. It's neither taking `URI`, nor returning `Path`
Fixed.
This name was a side effect of naming the method similar to existing method ```createNewPath()```
> On May 27, 2015, 3:07 p.m., Rajat Khandelwal wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java, line 203
> > <https://reviews.apache.org/r/34105/diff/7/?file=971535#file971535line203>
> >
> > why does only this have `file://` and others have `file:`?
This is on purpose. I wanted to test file path with both formats.
Have added a comment with the info.
> On May 27, 2015, 3:07 p.m., Rajat Khandelwal wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java, line 258
> > <https://reviews.apache.org/r/34105/diff/7/?file=971535#file971535line258>
> >
> > A lot of code is common in testing jar commands and testing file commands. Can we unify them?
Done.
> On May 27, 2015, 3:07 p.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java, line 44
> > <https://reviews.apache.org/r/34105/diff/7/?file=971537#file971537line44>
> >
> > `Path Scanner`, by name should be able to scan any given path. This is counter-intuitive to the class design here, which says that path scanner only scans one path.
> >
> > With the current design, all use cases will be:
> >
> > `paths = new PathScanner(a, b).getPaths()`
> >
> > Leaving the reader to wonder if `getPaths()` has to be called always, why isn't it part of the constructor.
> >
> > I'd suggest let's have a class like `ScannedPath`(very crude name, I'm sure you can come up with something better), and have it implement `Iterable<String>`. This will allow you to do `for(String path: new ScannedPath(path))`.
Implemented. PLease review.
On May 27, 2015, 3:07 p.m., Yash Sharma wrote:
> > Are we not doing the `jar_order` thing?
Yes we are. Please review the logic in
```
/**
* Filters the matchedPath[] to remove unwanted resources
* and apply ordering to the resources as specified in jar_order or glob_order file.
* Bypasses filtering if none of the files is present in the directory.
*/
public void filterMatchedPathsByOrder()\
```
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review85369
-----------------------------------------------------------
On May 28, 2015, 8:44 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 8:44 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Rajat Khandelwal <ra...@gmail.com>.
On May 27, 2015, 8:37 p.m., Yash Sharma wrote:
> > Are we not doing the `jar_order` thing?
>
> Yash Sharma wrote:
> Yes we are. Please review the logic in
> ```
>
> /**
> * Filters the matchedPath[] to remove unwanted resources
> * and apply ordering to the resources as specified in jar_order or glob_order file.
> * Bypasses filtering if none of the files is present in the directory.
> */
> public void filterMatchedPathsByOrder()\
> ```
Yeah, seems I'd missed it. :)
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review85369
-----------------------------------------------------------
On May 28, 2015, 2:14 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 2:14 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review85369
-----------------------------------------------------------
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java
<https://reviews.apache.org/r/34105/#comment136910>
I believe the name is misleading. It's neither taking `URI`, nor returning `Path`
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java
<https://reviews.apache.org/r/34105/#comment136911>
Same as above.
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java
<https://reviews.apache.org/r/34105/#comment136912>
why does only this have `file://` and others have `file:`?
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java
<https://reviews.apache.org/r/34105/#comment136913>
A lot of code is common in testing jar commands and testing file commands. Can we unify them?
lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java
<https://reviews.apache.org/r/34105/#comment136914>
`Path Scanner`, by name should be able to scan any given path. This is counter-intuitive to the class design here, which says that path scanner only scans one path.
With the current design, all use cases will be:
`paths = new PathScanner(a, b).getPaths()`
Leaving the reader to wonder if `getPaths()` has to be called always, why isn't it part of the constructor.
I'd suggest let's have a class like `ScannedPath`(very crude name, I'm sure you can come up with something better), and have it implement `Iterable<String>`. This will allow you to do `for(String path: new ScannedPath(path))`.
Are we not doing the `jar_order` thing?
- Rajat Khandelwal
On May 26, 2015, 10 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 26, 2015, 10 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/
-----------------------------------------------------------
(Updated May 26, 2015, 4:30 a.m.)
Review request for lens.
Changes
-------
Implemented review comments
Repository: lens
Description
-------
Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
Jira: https://issues.apache.org/jira/browse/LENS-513
Diffs (updated)
-----
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
Diff: https://reviews.apache.org/r/34105/diff/
Testing
-------
Yes.
Testcases:
New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
Old testcase modified: TestLensConnectionCliCommands#testJarCommands
Test on CLI:
1. -ve test scenario:
lens-shell>add jar /home/yash/Desktop/rt.jarr
No Jars found in the specified path.
lens-shell>add jar /home/yash/Desktop/*.jarr
No Jars found in the specified path.
2. +ve test scenario:
lens-shell>add jar /home/yash/Desktop/*.jar
Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
lens-shell>list resources
type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
type=jar path=/home/yash/Desktop/rt.jar
Complete build with testcases:
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
[INFO] Lens ............................................... SUCCESS [ 3.751 s]
[INFO] Lens API ........................................... SUCCESS [ 19.844 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
[INFO] Lens Cube .......................................... SUCCESS [03:06 min]
[INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
[INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
[INFO] Lens Server ........................................ SUCCESS [06:03 min]
[INFO] Lens client ........................................ SUCCESS [ 41.219 s]
[INFO] Lens CLI ........................................... SUCCESS [02:09 min]
[INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
[INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:46 min
[INFO] Finished at: 2015-05-12T19:44:01+05:30
[INFO] Final Memory: 120M/389M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
> On May 26, 2015, 3:47 a.m., Raju Bairishetti wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java, line 202
> > <https://reviews.apache.org/r/34105/diff/6/?file=971354#file971354line202>
> >
> > Can we remove commented code?
My Bad.
> On May 26, 2015, 3:47 a.m., Raju Bairishetti wrote:
> > lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java, line 165
> > <https://reviews.apache.org/r/34105/diff/6/?file=971356#file971356line165>
> >
> > Do we need to enclose it in try finally block?
Moved to finally.
> On May 26, 2015, 3:47 a.m., Raju Bairishetti wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java, line 200
> > <https://reviews.apache.org/r/34105/diff/6/?file=971354#file971354line200>
> >
> > Should we get the project workspace dir by using maven variables ${project.build.directory}?
> >
> > Any way we can handle it in [LENS-260](https://issues.apache.org/jira/browse/LENS-260).
I can pick up LENS-260.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review85144
-----------------------------------------------------------
On May 25, 2015, 6:09 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 25, 2015, 6:09 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review85144
-----------------------------------------------------------
LT
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java
<https://reviews.apache.org/r/34105/#comment136627>
Should we get the project workspace dir by using maven variables ${project.build.directory}?
Any way we can handle it in [LENS-260](https://issues.apache.org/jira/browse/LENS-260).
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java
<https://reviews.apache.org/r/34105/#comment136629>
minor: formatting?
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java
<https://reviews.apache.org/r/34105/#comment136628>
Can we remove commented code?
lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java
<https://reviews.apache.org/r/34105/#comment136630>
Do we need to enclose it in try finally block?
LGTM otherwise.
- Raju Bairishetti
On May 25, 2015, 6:09 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 25, 2015, 6:09 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/
-----------------------------------------------------------
(Updated May 25, 2015, 6:09 a.m.)
Review request for lens.
Changes
-------
Implemented review comments.
Repository: lens
Description
-------
Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
Jira: https://issues.apache.org/jira/browse/LENS-513
Diffs (updated)
-----
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
Diff: https://reviews.apache.org/r/34105/diff/
Testing
-------
Yes.
Testcases:
New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
Old testcase modified: TestLensConnectionCliCommands#testJarCommands
Test on CLI:
1. -ve test scenario:
lens-shell>add jar /home/yash/Desktop/rt.jarr
No Jars found in the specified path.
lens-shell>add jar /home/yash/Desktop/*.jarr
No Jars found in the specified path.
2. +ve test scenario:
lens-shell>add jar /home/yash/Desktop/*.jar
Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
lens-shell>list resources
type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
type=jar path=/home/yash/Desktop/rt.jar
Complete build with testcases:
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
[INFO] Lens ............................................... SUCCESS [ 3.751 s]
[INFO] Lens API ........................................... SUCCESS [ 19.844 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
[INFO] Lens Cube .......................................... SUCCESS [03:06 min]
[INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
[INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
[INFO] Lens Server ........................................ SUCCESS [06:03 min]
[INFO] Lens client ........................................ SUCCESS [ 41.219 s]
[INFO] Lens CLI ........................................... SUCCESS [02:09 min]
[INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
[INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:46 min
[INFO] Finished at: 2015-05-12T19:44:01+05:30
[INFO] Final Memory: 120M/389M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/
-----------------------------------------------------------
(Updated May 24, 2015, 10:36 a.m.)
Review request for lens.
Changes
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.335 s]
[INFO] Lens ............................................... SUCCESS [ 3.110 s]
[INFO] Lens API ........................................... SUCCESS [ 18.882 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 22.904 s]
[INFO] Lens Cube .......................................... SUCCESS [02:57 min]
[INFO] Lens DB storage .................................... SUCCESS [ 20.807 s]
[INFO] Lens Query Library ................................. SUCCESS [ 15.888 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:34 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 32.919 s]
[INFO] Lens Server ........................................ SUCCESS [05:04 min]
[INFO] Lens client ........................................ SUCCESS [ 36.088 s]
[INFO] Lens CLI ........................................... SUCCESS [02:08 min]
[INFO] Lens Examples ...................................... SUCCESS [ 10.708 s]
[INFO] Lens Distribution .................................. SUCCESS [ 7.653 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:20 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.181 s]
[INFO] Lens Regression .................................... SUCCESS [ 7.839 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:07 min
[INFO] Finished at: 2015-05-24T16:01:20+05:30
[INFO] Final Memory: 121M/375M
[INFO] ------------------------------------------------------------------------
Implemented review comments.
Repository: lens
Description
-------
Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
Jira: https://issues.apache.org/jira/browse/LENS-513
Diffs (updated)
-----
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
Diff: https://reviews.apache.org/r/34105/diff/
Testing
-------
Yes.
Testcases:
New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
Old testcase modified: TestLensConnectionCliCommands#testJarCommands
Test on CLI:
1. -ve test scenario:
lens-shell>add jar /home/yash/Desktop/rt.jarr
No Jars found in the specified path.
lens-shell>add jar /home/yash/Desktop/*.jarr
No Jars found in the specified path.
2. +ve test scenario:
lens-shell>add jar /home/yash/Desktop/*.jar
Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
lens-shell>list resources
type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
type=jar path=/home/yash/Desktop/rt.jar
Complete build with testcases:
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
[INFO] Lens ............................................... SUCCESS [ 3.751 s]
[INFO] Lens API ........................................... SUCCESS [ 19.844 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
[INFO] Lens Cube .......................................... SUCCESS [03:06 min]
[INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
[INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
[INFO] Lens Server ........................................ SUCCESS [06:03 min]
[INFO] Lens client ........................................ SUCCESS [ 41.219 s]
[INFO] Lens CLI ........................................... SUCCESS [02:09 min]
[INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
[INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:46 min
[INFO] Finished at: 2015-05-12T19:44:01+05:30
[INFO] Final Memory: 120M/389M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/
-----------------------------------------------------------
(Updated May 18, 2015, 4:15 p.m.)
Review request for lens.
Changes
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.982 s]
[INFO] Lens ............................................... SUCCESS [ 4.806 s]
[INFO] Lens API ........................................... SUCCESS [ 22.389 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 27.561 s]
[INFO] Lens Cube .......................................... SUCCESS [03:26 min]
[INFO] Lens DB storage .................................... SUCCESS [ 21.985 s]
[INFO] Lens Query Library ................................. SUCCESS [ 18.832 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:54 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 40.351 s]
[INFO] Lens Server ........................................ SUCCESS [05:06 min]
[INFO] Lens client ........................................ SUCCESS [ 37.016 s]
[INFO] Lens CLI ........................................... SUCCESS [01:54 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.175 s]
[INFO] Lens Distribution .................................. SUCCESS [ 8.748 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:14 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.788 s]
[INFO] Lens Regression .................................... SUCCESS [ 7.462 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:01 min
[INFO] Finished at: 2015-05-18T21:41:01+05:30
[INFO] Final Memory: 120M/392M
[INFO] ------------------------------------------------------------------------
Repository: lens
Description
-------
Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
Jira: https://issues.apache.org/jira/browse/LENS-513
Diffs (updated)
-----
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
Diff: https://reviews.apache.org/r/34105/diff/
Testing
-------
Yes.
Testcases:
New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
Old testcase modified: TestLensConnectionCliCommands#testJarCommands
Test on CLI:
1. -ve test scenario:
lens-shell>add jar /home/yash/Desktop/rt.jarr
No Jars found in the specified path.
lens-shell>add jar /home/yash/Desktop/*.jarr
No Jars found in the specified path.
2. +ve test scenario:
lens-shell>add jar /home/yash/Desktop/*.jar
Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
lens-shell>list resources
type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
type=jar path=/home/yash/Desktop/rt.jar
Complete build with testcases:
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
[INFO] Lens ............................................... SUCCESS [ 3.751 s]
[INFO] Lens API ........................................... SUCCESS [ 19.844 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
[INFO] Lens Cube .......................................... SUCCESS [03:06 min]
[INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
[INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
[INFO] Lens Server ........................................ SUCCESS [06:03 min]
[INFO] Lens client ........................................ SUCCESS [ 41.219 s]
[INFO] Lens CLI ........................................... SUCCESS [02:09 min]
[INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
[INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:46 min
[INFO] Finished at: 2015-05-12T19:44:01+05:30
[INFO] Final Memory: 120M/389M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
> On May 18, 2015, 4:12 a.m., Amareshwari Sriramadasu wrote:
> > lens-cli/pom.xml, line 128
> > <https://reviews.apache.org/r/34105/diff/3/?file=961457#file961457line128>
> >
> > Why is this dependency required?
>
> Raju Bairishetti wrote:
> I think this is for listing the files using DirectoryScanner. We can remove the dependency if we use FileSystem listStatus/globStatus for listing.
You are right. Has also been removed now.
> On May 18, 2015, 4:12 a.m., Amareshwari Sriramadasu wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java, line 100
> > <https://reviews.apache.org/r/34105/diff/3/?file=961458#file961458line100>
> >
> > I dont think this will work unless HDFS is up and running. We can test with file:/// for unit tests.
Moved to file:///
> On May 18, 2015, 4:12 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/pom.xml, line 245
> > <https://reviews.apache.org/r/34105/diff/3/?file=961459#file961459line245>
> >
> > Why is this dependenchy required?
I guess it got left out. I was using it for some experiment with code.
It has been removed now.
> On May 18, 2015, 4:12 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java, line 289
> > <https://reviews.apache.org/r/34105/diff/3/?file=961460#file961460line289>
> >
> > Shall we move this to SessionService itself?
Fixed. Sessionresource is no longer a service.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review84101
-----------------------------------------------------------
On May 15, 2015, 6:18 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 6:18 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 7b98523
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/pom.xml bb12e00
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Raju Bairishetti <ra...@gmail.com>.
> On May 18, 2015, 4:12 a.m., Amareshwari Sriramadasu wrote:
> > lens-cli/pom.xml, line 128
> > <https://reviews.apache.org/r/34105/diff/3/?file=961457#file961457line128>
> >
> > Why is this dependency required?
I think this is for listing the files using DirectoryScanner. We can remove the dependency if we use FileSystem listStatus/globStatus for listing.
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review84101
-----------------------------------------------------------
On May 15, 2015, 6:18 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 6:18 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 7b98523
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/pom.xml bb12e00
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review84101
-----------------------------------------------------------
lens-cli/pom.xml
<https://reviews.apache.org/r/34105/#comment135216>
Why is this dependency required?
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java
<https://reviews.apache.org/r/34105/#comment135214>
I dont think this will work unless HDFS is up and running. We can test with file:/// for unit tests.
lens-server/pom.xml
<https://reviews.apache.org/r/34105/#comment135212>
Why is this dependenchy required?
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java
<https://reviews.apache.org/r/34105/#comment135208>
Let us not make Resources to be services.
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java
<https://reviews.apache.org/r/34105/#comment135209>
Shall we move this to SessionService itself?
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java
<https://reviews.apache.org/r/34105/#comment135210>
Systsem should not prepend any URI prefix for getting paths.
User himself would give hdfs://host:port/path or file:///path for URI he is passing.
- Amareshwari Sriramadasu
On May 15, 2015, 6:18 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 6:18 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 7b98523
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/pom.xml bb12e00
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 16, 2015, 12:34 a.m., Yash Sharma wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java, line 197
> > <https://reviews.apache.org/r/34105/diff/3/?file=961458#file961458line197>
> >
> > This is BAD.
> > Need better way of using HDFS path in testcases. Suggestions ?
As amareshwari said, let's not rely on hdfs for test cases. `file:///` would be enough for test cases.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review83961
-----------------------------------------------------------
On May 15, 2015, 11:48 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 11:48 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 7b98523
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/pom.xml bb12e00
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
> On May 15, 2015, 7:04 p.m., Yash Sharma wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java, line 197
> > <https://reviews.apache.org/r/34105/diff/3/?file=961458#file961458line197>
> >
> > This is BAD.
> > Need better way of using HDFS path in testcases. Suggestions ?
>
> Rajat Khandelwal wrote:
> As amareshwari said, let's not rely on hdfs for test cases. `file:///` would be enough for test cases.
Implemented with testcase using file:///
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review83961
-----------------------------------------------------------
On May 15, 2015, 6:18 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 6:18 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 7b98523
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/pom.xml bb12e00
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review83961
-----------------------------------------------------------
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java
<https://reviews.apache.org/r/34105/#comment135021>
This is BAD.
Need better way of using HDFS path in testcases. Suggestions ?
- Yash Sharma
On May 15, 2015, 6:18 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 6:18 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 7b98523
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/pom.xml bb12e00
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
> On May 18, 2015, 4:16 a.m., Raju Bairishetti wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java, line 295
> > <https://reviews.apache.org/r/34105/diff/3/?file=961460#file961460line295>
> >
> > Can we import "org.apache.hadoop.fs.Path" instead of mentioning each place?
Conflicting with javax.rs.Path.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review84103
-----------------------------------------------------------
On May 15, 2015, 6:18 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 6:18 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 7b98523
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/pom.xml bb12e00
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review84103
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java
<https://reviews.apache.org/r/34105/#comment135218>
Need to check the nullity of **foundfiles** String array. Returning null incse of file not found exceptions and other io exceptions.
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java
<https://reviews.apache.org/r/34105/#comment135213>
Can we have single implementation for both hdfs and local file system?
Get the file system instance from the given **path**.
FileSystem fs = path.getFileSystem(new Configuration);
Use globStatus(path) method for listing the paths.
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java
<https://reviews.apache.org/r/34105/#comment135215>
Can we import "org.apache.hadoop.fs.Path" instead of mentioning each place?
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java
<https://reviews.apache.org/r/34105/#comment135217>
Can we rename status to statuses? We may need to check the nullity.
- Raju Bairishetti
On May 15, 2015, 6:18 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 6:18 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 7b98523
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/pom.xml bb12e00
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review84116
-----------------------------------------------------------
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java
<https://reviews.apache.org/r/34105/#comment135229>
And can't we import `org.apache.hadoop.fs.Path`?
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java
<https://reviews.apache.org/r/34105/#comment135231>
As others have mentioned, single implementation please! We shouldn't do an `if/else` on what the path starts with.
- Rajat Khandelwal
On May 15, 2015, 11:48 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 11:48 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 7b98523
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/pom.xml bb12e00
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/
-----------------------------------------------------------
(Updated May 15, 2015, 6:18 p.m.)
Review request for lens.
Repository: lens
Description
-------
Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
Jira: https://issues.apache.org/jira/browse/LENS-513
Diffs (updated)
-----
lens-cli/pom.xml 7b98523
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
lens-server/pom.xml bb12e00
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
Diff: https://reviews.apache.org/r/34105/diff/
Testing
-------
Yes.
Testcases:
New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
Old testcase modified: TestLensConnectionCliCommands#testJarCommands
Test on CLI:
1. -ve test scenario:
lens-shell>add jar /home/yash/Desktop/rt.jarr
No Jars found in the specified path.
lens-shell>add jar /home/yash/Desktop/*.jarr
No Jars found in the specified path.
2. +ve test scenario:
lens-shell>add jar /home/yash/Desktop/*.jar
Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
lens-shell>list resources
type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
type=jar path=/home/yash/Desktop/rt.jar
Complete build with testcases:
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
[INFO] Lens ............................................... SUCCESS [ 3.751 s]
[INFO] Lens API ........................................... SUCCESS [ 19.844 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
[INFO] Lens Cube .......................................... SUCCESS [03:06 min]
[INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
[INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
[INFO] Lens Server ........................................ SUCCESS [06:03 min]
[INFO] Lens client ........................................ SUCCESS [ 41.219 s]
[INFO] Lens CLI ........................................... SUCCESS [02:09 min]
[INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
[INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:46 min
[INFO] Finished at: 2015-05-12T19:44:01+05:30
[INFO] Final Memory: 120M/389M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/
-----------------------------------------------------------
(Updated May 15, 2015, 4:51 p.m.)
Review request for lens.
Changes
-------
Implemented review changes.
Repository: lens
Description
-------
Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
Jira: https://issues.apache.org/jira/browse/LENS-513
Diffs (updated)
-----
lens-cli/pom.xml 7b98523
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
lens-server/pom.xml bb12e00
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
Diff: https://reviews.apache.org/r/34105/diff/
Testing
-------
Yes.
Testcases:
New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
Old testcase modified: TestLensConnectionCliCommands#testJarCommands
Test on CLI:
1. -ve test scenario:
lens-shell>add jar /home/yash/Desktop/rt.jarr
No Jars found in the specified path.
lens-shell>add jar /home/yash/Desktop/*.jarr
No Jars found in the specified path.
2. +ve test scenario:
lens-shell>add jar /home/yash/Desktop/*.jar
Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
lens-shell>list resources
type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
type=jar path=/home/yash/Desktop/rt.jar
Complete build with testcases:
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
[INFO] Lens ............................................... SUCCESS [ 3.751 s]
[INFO] Lens API ........................................... SUCCESS [ 19.844 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
[INFO] Lens Cube .......................................... SUCCESS [03:06 min]
[INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
[INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
[INFO] Lens Server ........................................ SUCCESS [06:03 min]
[INFO] Lens client ........................................ SUCCESS [ 41.219 s]
[INFO] Lens CLI ........................................... SUCCESS [02:09 min]
[INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
[INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:46 min
[INFO] Finished at: 2015-05-12T19:44:01+05:30
[INFO] Final Memory: 120M/389M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
> On May 13, 2015, 9:33 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java, line 92
> > <https://reviews.apache.org/r/34105/diff/1/?file=956607#file956607line92>
> >
> > Another thing I have in mind is to add all jars of a directory. This will take a directory path as input, look at all `*jar` files there and add them. Added customizability with `jar_order` file in the directory which will govern which order jars need to be added in.
>
> Rajat Khandelwal wrote:
> Some of the code is already present in org.apache.lens.server.session.DatabaseResourceService. Might need some reshuffling
>
> Yash Sharma wrote:
> Will give it a look and incorporate relevant changes.
Not Implemented.
I had a look at the code and its pretty straight but it gets tricky for regex's which match to multiple directories and we need to fetch the jar_order from multiple dirs. Also the same service method becomes complex.
The backend service Add/Remove resource is used by both File resources and Jar resources and also for regex and simple paths.
Should we have different backend service methods ? Thoughts ?
Will incorporate the changes based on suggestions.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review83579
-----------------------------------------------------------
On May 15, 2015, 4:51 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 4:51 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 7b98523
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/pom.xml bb12e00
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
> On May 13, 2015, 9:33 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java, line 92
> > <https://reviews.apache.org/r/34105/diff/1/?file=956607#file956607line92>
> >
> > Another thing I have in mind is to add all jars of a directory. This will take a directory path as input, look at all `*jar` files there and add them. Added customizability with `jar_order` file in the directory which will govern which order jars need to be added in.
>
> Rajat Khandelwal wrote:
> Some of the code is already present in org.apache.lens.server.session.DatabaseResourceService. Might need some reshuffling
>
> Yash Sharma wrote:
> Will give it a look and incorporate relevant changes.
>
> Yash Sharma wrote:
> Not Implemented.
>
> I had a look at the code and its pretty straight but it gets tricky for regex's which match to multiple directories and we need to fetch the jar_order from multiple dirs. Also the same service method becomes complex.
> The backend service Add/Remove resource is used by both File resources and Jar resources and also for regex and simple paths.
>
> Should we have different backend service methods ? Thoughts ?
> Will incorporate the changes based on suggestions.
>
> Rajat Khandelwal wrote:
> I'm inclined towards something like this:
>
> add(file_path): adds the file
> add(dir_path): opens the dir, decides jar order according to jar_order or if not present, glob order
> add(regex): iterates over all paths matching the regex in glob order, and calls add(x) on them.
>
> Rajat Khandelwal wrote:
> And for different methods, we can have a common method in their base class I'd say. Or here we can have an instance of DatabaseResourceService.
>
> Amareshwari Sriramadasu wrote:
> I would say
> add(dir_path): opens the dir, decides jar order according to jar_order or if not present, glob order
> can be taken up separately. As that requires different effort. Rajat, do you mind creating a separate jira?
Implemented. Please review.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review83579
-----------------------------------------------------------
On May 24, 2015, 10:36 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 24, 2015, 10:36 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
> On May 13, 2015, 9:33 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java, line 92
> > <https://reviews.apache.org/r/34105/diff/1/?file=956607#file956607line92>
> >
> > Another thing I have in mind is to add all jars of a directory. This will take a directory path as input, look at all `*jar` files there and add them. Added customizability with `jar_order` file in the directory which will govern which order jars need to be added in.
>
> Rajat Khandelwal wrote:
> Some of the code is already present in org.apache.lens.server.session.DatabaseResourceService. Might need some reshuffling
Will give it a look and incorporate relevant changes.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review83579
-----------------------------------------------------------
On May 12, 2015, 3:20 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 3:20 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 7b98523
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java d727ecc
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 13, 2015, 3:03 p.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java, line 92
> > <https://reviews.apache.org/r/34105/diff/1/?file=956607#file956607line92>
> >
> > Another thing I have in mind is to add all jars of a directory. This will take a directory path as input, look at all `*jar` files there and add them. Added customizability with `jar_order` file in the directory which will govern which order jars need to be added in.
>
> Rajat Khandelwal wrote:
> Some of the code is already present in org.apache.lens.server.session.DatabaseResourceService. Might need some reshuffling
>
> Yash Sharma wrote:
> Will give it a look and incorporate relevant changes.
>
> Yash Sharma wrote:
> Not Implemented.
>
> I had a look at the code and its pretty straight but it gets tricky for regex's which match to multiple directories and we need to fetch the jar_order from multiple dirs. Also the same service method becomes complex.
> The backend service Add/Remove resource is used by both File resources and Jar resources and also for regex and simple paths.
>
> Should we have different backend service methods ? Thoughts ?
> Will incorporate the changes based on suggestions.
I'm inclined towards something like this:
add(file_path): adds the file
add(dir_path): opens the dir, decides jar order according to jar_order or if not present, glob order
add(regex): iterates over all paths matching the regex in glob order, and calls add(x) on them.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review83579
-----------------------------------------------------------
On May 18, 2015, 9:45 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 9:45 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 13, 2015, 3:03 p.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java, line 92
> > <https://reviews.apache.org/r/34105/diff/1/?file=956607#file956607line92>
> >
> > Another thing I have in mind is to add all jars of a directory. This will take a directory path as input, look at all `*jar` files there and add them. Added customizability with `jar_order` file in the directory which will govern which order jars need to be added in.
>
> Rajat Khandelwal wrote:
> Some of the code is already present in org.apache.lens.server.session.DatabaseResourceService. Might need some reshuffling
>
> Yash Sharma wrote:
> Will give it a look and incorporate relevant changes.
>
> Yash Sharma wrote:
> Not Implemented.
>
> I had a look at the code and its pretty straight but it gets tricky for regex's which match to multiple directories and we need to fetch the jar_order from multiple dirs. Also the same service method becomes complex.
> The backend service Add/Remove resource is used by both File resources and Jar resources and also for regex and simple paths.
>
> Should we have different backend service methods ? Thoughts ?
> Will incorporate the changes based on suggestions.
>
> Rajat Khandelwal wrote:
> I'm inclined towards something like this:
>
> add(file_path): adds the file
> add(dir_path): opens the dir, decides jar order according to jar_order or if not present, glob order
> add(regex): iterates over all paths matching the regex in glob order, and calls add(x) on them.
And for different methods, we can have a common method in their base class I'd say. Or here we can have an instance of DatabaseResourceService.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review83579
-----------------------------------------------------------
On May 18, 2015, 9:45 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 9:45 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On May 13, 2015, 9:33 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java, line 92
> > <https://reviews.apache.org/r/34105/diff/1/?file=956607#file956607line92>
> >
> > Another thing I have in mind is to add all jars of a directory. This will take a directory path as input, look at all `*jar` files there and add them. Added customizability with `jar_order` file in the directory which will govern which order jars need to be added in.
>
> Rajat Khandelwal wrote:
> Some of the code is already present in org.apache.lens.server.session.DatabaseResourceService. Might need some reshuffling
>
> Yash Sharma wrote:
> Will give it a look and incorporate relevant changes.
>
> Yash Sharma wrote:
> Not Implemented.
>
> I had a look at the code and its pretty straight but it gets tricky for regex's which match to multiple directories and we need to fetch the jar_order from multiple dirs. Also the same service method becomes complex.
> The backend service Add/Remove resource is used by both File resources and Jar resources and also for regex and simple paths.
>
> Should we have different backend service methods ? Thoughts ?
> Will incorporate the changes based on suggestions.
>
> Rajat Khandelwal wrote:
> I'm inclined towards something like this:
>
> add(file_path): adds the file
> add(dir_path): opens the dir, decides jar order according to jar_order or if not present, glob order
> add(regex): iterates over all paths matching the regex in glob order, and calls add(x) on them.
>
> Rajat Khandelwal wrote:
> And for different methods, we can have a common method in their base class I'd say. Or here we can have an instance of DatabaseResourceService.
I would say
add(dir_path): opens the dir, decides jar order according to jar_order or if not present, glob order
can be taken up separately. As that requires different effort. Rajat, do you mind creating a separate jira?
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review83579
-----------------------------------------------------------
On May 18, 2015, 4:15 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 4:15 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 01dcf54
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 13, 2015, 3:03 p.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java, line 92
> > <https://reviews.apache.org/r/34105/diff/1/?file=956607#file956607line92>
> >
> > Another thing I have in mind is to add all jars of a directory. This will take a directory path as input, look at all `*jar` files there and add them. Added customizability with `jar_order` file in the directory which will govern which order jars need to be added in.
Some of the code is already present in org.apache.lens.server.session.DatabaseResourceService. Might need some reshuffling
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review83579
-----------------------------------------------------------
On May 12, 2015, 8:50 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 8:50 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 7b98523
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java d727ecc
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review83579
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java
<https://reviews.apache.org/r/34105/#comment134595>
Another thing I have in mind is to add all jars of a directory. This will take a directory path as input, look at all `*jar` files there and add them. Added customizability with `jar_order` file in the directory which will govern which order jars need to be added in.
- Rajat Khandelwal
On May 12, 2015, 8:50 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 8:50 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 7b98523
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java d727ecc
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
> On May 13, 2015, 4:47 a.m., Amareshwari Sriramadasu wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java, line 94
> > <https://reviews.apache.org/r/34105/diff/1/?file=956607#file956607line94>
> >
> > We should be doing this on server side, instead of client. Doing only on cli makes the feature available only for cli client.
Made the changes. Will be posting updated patch soon.
I have tested with both client and server on same box. Not able to test with the processes on separate machines.
> On May 13, 2015, 4:47 a.m., Amareshwari Sriramadasu wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java, line 95
> > <https://reviews.apache.org/r/34105/diff/1/?file=956607#file956607line95>
> >
> > Also, add jar can take hdfs paths as well - with full uri. We should use something like hadoop filesystem api to get all paths matching regex.
While we can support jars from hdfs but should we ? why would anyone put jars on hdfs (small file and un-necesarily replicated) ?
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review83561
-----------------------------------------------------------
On May 12, 2015, 3:20 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 3:20 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 7b98523
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java d727ecc
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
> On May 13, 2015, 4:47 a.m., Amareshwari Sriramadasu wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java, line 95
> > <https://reviews.apache.org/r/34105/diff/1/?file=956607#file956607line95>
> >
> > Also, add jar can take hdfs paths as well - with full uri. We should use something like hadoop filesystem api to get all paths matching regex.
>
> Yash Sharma wrote:
> While we can support jars from hdfs but should we ? why would anyone put jars on hdfs (small file and un-necesarily replicated) ?
Implemented.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review83561
-----------------------------------------------------------
On May 15, 2015, 4:51 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 4:51 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 7b98523
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/pom.xml bb12e00
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On May 13, 2015, 4:47 a.m., Amareshwari Sriramadasu wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java, line 95
> > <https://reviews.apache.org/r/34105/diff/1/?file=956607#file956607line95>
> >
> > Also, add jar can take hdfs paths as well - with full uri. We should use something like hadoop filesystem api to get all paths matching regex.
>
> Yash Sharma wrote:
> While we can support jars from hdfs but should we ? why would anyone put jars on hdfs (small file and un-necesarily replicated) ?
>
> Yash Sharma wrote:
> Implemented.
Sorry for late reply.
We would support jars/files to be added through an URI. URI can be pointing to hdfs://host:port/path or file:///path or s3:/// or whatever - needs to queryable (we can use hadoop filesystem api) for looking at paths in any of the uri passed. Having support for distributed file system makes process to access it the files even if they are not running on same machines
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review83561
-----------------------------------------------------------
On May 15, 2015, 6:18 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 6:18 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 7b98523
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/pom.xml bb12e00
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
> On May 13, 2015, 4:47 a.m., Amareshwari Sriramadasu wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java, line 95
> > <https://reviews.apache.org/r/34105/diff/1/?file=956607#file956607line95>
> >
> > Also, add jar can take hdfs paths as well - with full uri. We should use something like hadoop filesystem api to get all paths matching regex.
>
> Yash Sharma wrote:
> While we can support jars from hdfs but should we ? why would anyone put jars on hdfs (small file and un-necesarily replicated) ?
>
> Yash Sharma wrote:
> Implemented.
>
> Amareshwari Sriramadasu wrote:
> Sorry for late reply.
> We would support jars/files to be added through an URI. URI can be pointing to hdfs://host:port/path or file:///path or s3:/// or whatever - needs to queryable (we can use hadoop filesystem api) for looking at paths in any of the uri passed. Having support for distributed file system makes process to access it the files even if they are not running on same machines
Implemented.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review83561
-----------------------------------------------------------
On May 15, 2015, 6:18 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 6:18 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 7b98523
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/pom.xml bb12e00
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review83561
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java
<https://reviews.apache.org/r/34105/#comment134571>
We should be doing this on server side, instead of client. Doing only on cli makes the feature available only for cli client.
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java
<https://reviews.apache.org/r/34105/#comment134573>
Also, add jar can take hdfs paths as well - with full uri. We should use something like hadoop filesystem api to get all paths matching regex.
- Amareshwari Sriramadasu
On May 12, 2015, 3:20 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 3:20 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 7b98523
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java d727ecc
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
> On May 13, 2015, 2:10 a.m., Raju Bairishetti wrote:
> > Can we implement it for files (**i.e. add file**) as well? Can we remove the jars/files based on the regular expression?
Implemented. Please review.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review83546
-----------------------------------------------------------
On May 15, 2015, 4:51 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 4:51 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 7b98523
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
> lens-server/pom.xml bb12e00
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 5ffc086
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/#review83546
-----------------------------------------------------------
Can we implement it for files (**i.e. add file**) as well? Can we remove the jars/files based on the regular expression?
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java
<https://reviews.apache.org/r/34105/#comment134548>
Do we need to set caseSensitive explicitly? Seems it is turned on by default.
- Raju Bairishetti
On May 12, 2015, 3:20 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34105/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 3:20 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
>
> Jira: https://issues.apache.org/jira/browse/LENS-513
>
>
> Diffs
> -----
>
> lens-cli/pom.xml 7b98523
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java d727ecc
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
>
> Diff: https://reviews.apache.org/r/34105/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Testcases:
> New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
> Old testcase modified: TestLensConnectionCliCommands#testJarCommands
>
> Test on CLI:
>
> 1. -ve test scenario:
> lens-shell>add jar /home/yash/Desktop/rt.jarr
> No Jars found in the specified path.
> lens-shell>add jar /home/yash/Desktop/*.jarr
> No Jars found in the specified path.
>
> 2. +ve test scenario:
> lens-shell>add jar /home/yash/Desktop/*.jar
> Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
>
> lens-shell>list resources
> type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
> type=jar path=/home/yash/Desktop/rt.jar
>
>
> Complete build with testcases:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
> [INFO] Lens ............................................... SUCCESS [ 3.751 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.844 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:06 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
> [INFO] Lens Server ........................................ SUCCESS [06:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 41.219 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:09 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
> [INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:46 min
> [INFO] Finished at: 2015-05-12T19:44:01+05:30
> [INFO] Final Memory: 120M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34105: add jar should be able to take regex path
and should be able to add multiple jars
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34105/
-----------------------------------------------------------
(Updated May 12, 2015, 3:20 p.m.)
Review request for lens.
Changes
-------
Complete build successful with all testcases
Repository: lens
Description
-------
Initial patch for - add jar should be able to take regex path and should be able to add multiple jars.
Jira: https://issues.apache.org/jira/browse/LENS-513
Diffs
-----
lens-cli/pom.xml 7b98523
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java d727ecc
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 3238edb
Diff: https://reviews.apache.org/r/34105/diff/
Testing (updated)
-------
Yes.
Testcases:
New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex
Old testcase modified: TestLensConnectionCliCommands#testJarCommands
Test on CLI:
1. -ve test scenario:
lens-shell>add jar /home/yash/Desktop/rt.jarr
No Jars found in the specified path.
lens-shell>add jar /home/yash/Desktop/*.jarr
No Jars found in the specified path.
2. +ve test scenario:
lens-shell>add jar /home/yash/Desktop/*.jar
Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar /home/yash/Desktop/rt.jar ]
lens-shell>list resources
type=jar path=/home/yash/Desktop/mahout-core-0.9.jar
type=jar path=/home/yash/Desktop/rt.jar
Complete build with testcases:
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 s]
[INFO] Lens ............................................... SUCCESS [ 3.751 s]
[INFO] Lens API ........................................... SUCCESS [ 19.844 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 s]
[INFO] Lens Cube .......................................... SUCCESS [03:06 min]
[INFO] Lens DB storage .................................... SUCCESS [ 22.211 s]
[INFO] Lens Query Library ................................. SUCCESS [ 19.126 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:48 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 s]
[INFO] Lens Server ........................................ SUCCESS [06:03 min]
[INFO] Lens client ........................................ SUCCESS [ 41.219 s]
[INFO] Lens CLI ........................................... SUCCESS [02:09 min]
[INFO] Lens Examples ...................................... SUCCESS [ 11.513 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.081 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 s]
[INFO] Lens Regression .................................... SUCCESS [ 8.067 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:46 min
[INFO] Finished at: 2015-05-12T19:44:01+05:30
[INFO] Final Memory: 120M/389M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma