You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/14 17:54:32 UTC

[GitHub] [incubator-superset] rusackas commented on a change in pull request #10866: ESLint: Re-enable rule control-has-associated-label

rusackas commented on a change in pull request #10866:
URL: https://github.com/apache/incubator-superset/pull/10866#discussion_r488118010



##########
File path: superset-frontend/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -179,6 +179,7 @@ class DatasourceControl extends React.PureComponent {
             <a href="#">
               <i
                 role="button"
+                aria-label="Toggle show datasource"

Review comment:
       ```suggestion
                   aria-label="Toggle datasource visibility"
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org