You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "dweiss (via GitHub)" <gi...@apache.org> on 2024/02/27 16:29:55 UTC
[PR] Add a nightly workflow to run and verify buildAndPushRelease and smokeTestRelease.py [lucene]
dweiss opened a new pull request, #13141:
URL: https://github.com/apache/lucene/pull/13141
This is an initial attempt to run a gh workflow to at least make sure these two scripts work and things are building. For the time being, I've omitted the tests entirely - nightly tests OOM on gh infrastructure and they're run/ verified elsewhere anyway (jenkins jobs). This is just to have a regular check that the python scripts pass.
The workflow is at the moment quite simple:
* it runs a local "release" in dev-mode (so also omits running gradle checks and signing artifacts),
* it then runs the smoke tester against the locally produced release. The smoke tester is run with the minimum default JDK but gradle is run with newer, head-released javas (17, 21 and 22-ea).
The workflow runs nightly, without any other triggers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add a nightly workflow to run and verify buildAndPushRelease.py and smokeTestRelease.py [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss merged PR #13141:
URL: https://github.com/apache/lucene/pull/13141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add a nightly workflow to run and verify buildAndPushRelease and smokeTestRelease.py [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on code in PR #13141:
URL: https://github.com/apache/lucene/pull/13141#discussion_r1504572039
##########
dev-tools/scripts/smokeTestRelease.py:
##########
@@ -158,9 +158,9 @@ def checkJARMetaData(desc, jarFile, gitRevision, version):
break
else:
if len(verify) == 1:
- raise RuntimeError('%s is missing "%s" inside its META-INF/MANIFEST.MF' % (desc, verify[0]))
+ raise RuntimeError('%s is missing "%s" inside its META-INF/MANIFEST.MF: %s' % (desc, verify[0], s))
Review Comment:
I added dumping manifest content here, since I had some trouble getting X-Build-JDK to pass.
##########
dev-tools/scripts/smokeTestRelease.py:
##########
@@ -577,7 +577,7 @@ def verifyUnpacked(java, artifact, unpackPath, gitRevision, version, testArgs):
# raise RuntimeError('lucene: file "%s" is missing from artifact %s' % (fileName, artifact))
# in_root_folder.remove(fileName)
- expected_folders = ['analysis', 'analysis.tests', 'backward-codecs', 'benchmark', 'classification', 'codecs', 'core', 'core.tests',
+ expected_folders = ['analysis', 'analysis.tests', 'backward-codecs', 'benchmark', 'benchmark-jmh', 'classification', 'codecs', 'core', 'core.tests',
Review Comment:
Added benchmark-jmh, not present on branch_9x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add a nightly workflow to run and verify buildAndPushRelease.py and smokeTestRelease.py [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #13141:
URL: https://github.com/apache/lucene/pull/13141#issuecomment-1967128468
This is already working (https://github.com/dweiss/lucene/actions/runs/8067320693) but I need to polish a few things before it's worth of your time to review. Hopefully later tonight or tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add a nightly workflow to run and verify buildAndPushRelease.py and smokeTestRelease.py [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #13141:
URL: https://github.com/apache/lucene/pull/13141#issuecomment-1970518645
I confirm it's working on schedule, as intended:
https://github.com/apache/lucene/actions/runs/8090015214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add a nightly workflow to run and verify buildAndPushRelease.py and smokeTestRelease.py [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #13141:
URL: https://github.com/apache/lucene/pull/13141#issuecomment-1967491480
Ok. I think things can be improved but let's not make it too complicated at the beginning. Everything seems to work:
and since the workflow collects logs from each jvm, it's easy to verify these "runtime" JVMs are used for compilation and testing (even though all tests are actually skipped):
I'd like to merge this in to main and let it run a day or two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org