[PR] core-spec: define OSSIE_SQL_2026 as a dialect [ossie]

["christianeu-db (via GitHub)" <gi...@apache.org>]

christianeu-db opened a new pull request, #439:
URL: https://github.com/apache/ossie/pull/439

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   ## Summary
   
   `core-spec/expression_language.md` defines the portable **OSSIE_SQL_2026**
   expression language and states that it should be registered as a dialect in
   the spec. That registration never landed: `OSSIE_SQL_2026` was absent from the
   `Dialect` enumeration. A document that tagged an expression with
   `dialect: OSSIE_SQL_2026` therefore failed schema validation, and the spec had
   no name for the language it defines.
   
   This PR closes that gap:
   
   - Add `OSSIE_SQL_2026` to the authoritative `Dialect` enum in
     `core-spec/ossie-schema.json` (uppercase, matching the existing enum values
     such as `ANSI_SQL` and `BIGQUERY`).
   - Regenerate the `dialects` block in `core-spec/spec.yaml` with
     `scripts/generate-spec-types.py --apply` (the enum-sync generator introduced
     in #291). `spec.yaml` is a generated artifact; it was not hand-edited.
   - Add the `OSSIE_SQL_2026` row to the Dialects table in `core-spec/spec.md`
     (this table is hand-maintained; the generator does not touch it).
   - Update the `expression_language.md` "Changes to YAML" note so item (1) reads
     as done rather than as a to-do.
   
   Two supporting lines fix pre-existing generator drift: the generator carried no
   `descriptions` entry for `SIGMA` or `DAX`, so `--apply` would have stripped
   their inline comments from `spec.yaml`. Adding those two descriptions makes the
   regeneration lossless, and `scripts/generate-spec-types.py --check` now exits 0.
   
   **Scope note (not a breaking change):** `ANSI_SQL` remains the documented
   default dialect. Making `OSSIE_SQL_2026` the default when none is chosen is the
   second proposal in `expression_language.md` and an open item on the dev@
   discussion; it is intentionally left out of this PR.
   
   ## Related Issues
   
   Discussed on dev@ossie.apache.org — "[DISCUSS] Landing Ossie semantics and
   compliance suites":
   https://lists.apache.org/thread/1jhvnw8vg5fgtct347t62ycc2zkrox6l
   
   ## Checklist
   
   ### Specification
   - [x] Spec changes are included in `core-spec/` and follow the existing structure
   - [x] Spec changes have been discussed on the mailing list or in a linked issue
   - [x] Breaking changes to the spec are clearly called out in the summary <!-- none: purely additive enum value; default unchanged -->
   
   ### Ontology
   - [x] Ontology changes in `ontology/` are consistent with spec changes <!-- N/A: no ontology change -->
   - [x] New or modified terms are defined and documented <!-- N/A -->
   
   ### Converters
   - [x] Converter logic in `converters/` is updated to reflect spec or ontology changes <!-- N/A: additive dialect value; no converter behavior change -->
   - [x] New converters include tests under the converter's test directory <!-- N/A -->
   
   ### Validation
   - [x] Validation rules in `validation/` are updated if the spec changed <!-- N/A: additive enum value; existing rules unchanged -->
   - [x] New validation cases are covered by tests <!-- existing validation suite exercises the Dialect enum; all 39 tests pass -->
   
   ### Documentation
   - [x] `docs/` is updated to reflect any user-facing changes <!-- dialect list lives in core-spec/spec.md, updated here -->
   - [x] New features or behaviors are documented with examples where appropriate
   - [x] `CONTRIBUTING.md` is updated if the contribution process changed <!-- N/A -->
   
   ### Examples
   - [x] `examples/` are added or updated for any new spec constructs or converter support <!-- N/A: no new construct; new value for an existing field -->
   
   ### Tests
   - [x] All existing tests pass (`pytest` / CI green)
   - [x] New functionality is covered by tests
   
   ### Compliance
   - [x] ASF license headers are present on all new source files <!-- no new source files; generator already carries the ASF header -->
   - [x] No third-party dependencies are added without PMC/IPMC approval
   
   This pull request and its description were written by Isaac.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] core-spec: define OSSIE_SQL_2026 as a dialect [ossie]

["khush-bhatia (via GitHub)" <gi...@apache.org>]

khush-bhatia merged PR #439:
URL: https://github.com/apache/ossie/pull/439


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org