You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/06 10:48:43 UTC
[GitHub] [flink] lirui-apache opened a new pull request #10775:
[FLINK-15482][hive] Failed to call Hive functions returning decimal type
lirui-apache opened a new pull request #10775: [FLINK-15482][hive] Failed to call Hive functions returning decimal type
URL: https://github.com/apache/flink/pull/10775
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Fix the issue of calling Hive functions that return decimals
## Brief change log
- Call `TypeInfoDataTypeConverter` to convert data type to type info because it's the recommended way.
- Add test case
## Verifying this change
New test case
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? NA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on issue #10775: [FLINK-15482][hive]
Failed to call Hive functions returning decimal type
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #10775: [FLINK-15482][hive] Failed to call Hive functions returning decimal type
URL: https://github.com/apache/flink/pull/10775#issuecomment-571119882
Added two more commits to fix `DataFormatConverters` and `ScalarFunctionCallGen`, as suggested by @JingsongLi
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10775:
[FLINK-15482][hive] Failed to call Hive functions returning decimal type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10775: [FLINK-15482][hive] Failed to call Hive functions returning decimal type
URL: https://github.com/apache/flink/pull/10775#issuecomment-571103452
<!--
Meta data
Hash:230118fe22abdfa2adae7fabcd4ce6577c92bceb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143229026 TriggerType:PUSH TriggerID:230118fe22abdfa2adae7fabcd4ce6577c92bceb
Hash:230118fe22abdfa2adae7fabcd4ce6577c92bceb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4124 TriggerType:PUSH TriggerID:230118fe22abdfa2adae7fabcd4ce6577c92bceb
Hash:d09f924b8a299087584f822180dd0fd51f50e0c1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4130 TriggerType:PUSH TriggerID:d09f924b8a299087584f822180dd0fd51f50e0c1
Hash:d09f924b8a299087584f822180dd0fd51f50e0c1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143235659 TriggerType:PUSH TriggerID:d09f924b8a299087584f822180dd0fd51f50e0c1
Hash:9f3e87d2f247d4970fdd41e9758f5575710f9cfa Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4136 TriggerType:PUSH TriggerID:9f3e87d2f247d4970fdd41e9758f5575710f9cfa
Hash:9f3e87d2f247d4970fdd41e9758f5575710f9cfa Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143243281 TriggerType:PUSH TriggerID:9f3e87d2f247d4970fdd41e9758f5575710f9cfa
-->
## CI report:
* 230118fe22abdfa2adae7fabcd4ce6577c92bceb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143229026) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4124)
* d09f924b8a299087584f822180dd0fd51f50e0c1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143235659) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4130)
* 9f3e87d2f247d4970fdd41e9758f5575710f9cfa Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143243281) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4136)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on issue #10775: [FLINK-15482][hive]
Failed to call Hive functions returning decimal type
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #10775: [FLINK-15482][hive] Failed to call Hive functions returning decimal type
URL: https://github.com/apache/flink/pull/10775#issuecomment-571406366
cc @bowenli86 @zjuwangg @xuefuz
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #10775:
[FLINK-15482][hive] Failed to call Hive functions returning decimal type
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #10775: [FLINK-15482][hive] Failed to call Hive functions returning decimal type
URL: https://github.com/apache/flink/pull/10775#discussion_r363619388
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/DataFormatConverters.java
##########
@@ -164,9 +164,10 @@ public static DataFormatConverter getConverterForDataType(DataType originDataTyp
Tuple2<Integer, Integer> ps = getPrecision(logicalType);
if (clazz == BigDecimal.class) {
return new BigDecimalConverter(ps.f0, ps.f1);
- } else {
+ } else if (clazz == Decimal.class) {
return new DecimalConverter(ps.f0, ps.f1);
}
+ throw new RuntimeException("Not support class for DECIMAL: " + clazz);
Review comment:
Put it in the `else` branch? Could you help to update other types which have the same problem, e.g. `TIMESTAMP_WITHOUT_TIME_ZONE`, `TIMESTAMP_WITH_LOCAL_TIME_ZONE`, `TIMESTAMP_WITH_LOCAL_TIME_ZONE`...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on issue #10775: [FLINK-15482][hive]
Failed to call Hive functions returning decimal type
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #10775: [FLINK-15482][hive] Failed to call Hive functions returning decimal type
URL: https://github.com/apache/flink/pull/10775#issuecomment-571493761
@JingsongLi @wuchong Thanks for your review. PR updated accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10775:
[FLINK-15482][hive] Failed to call Hive functions returning decimal type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10775: [FLINK-15482][hive] Failed to call Hive functions returning decimal type
URL: https://github.com/apache/flink/pull/10775#issuecomment-571103452
<!--
Meta data
Hash:230118fe22abdfa2adae7fabcd4ce6577c92bceb Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143229026 TriggerType:PUSH TriggerID:230118fe22abdfa2adae7fabcd4ce6577c92bceb
Hash:230118fe22abdfa2adae7fabcd4ce6577c92bceb Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4124 TriggerType:PUSH TriggerID:230118fe22abdfa2adae7fabcd4ce6577c92bceb
Hash:d09f924b8a299087584f822180dd0fd51f50e0c1 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d09f924b8a299087584f822180dd0fd51f50e0c1
-->
## CI report:
* 230118fe22abdfa2adae7fabcd4ce6577c92bceb Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143229026) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4124)
* d09f924b8a299087584f822180dd0fd51f50e0c1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10775:
[FLINK-15482][hive] Failed to call Hive functions returning decimal type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10775: [FLINK-15482][hive] Failed to call Hive functions returning decimal type
URL: https://github.com/apache/flink/pull/10775#issuecomment-571103452
<!--
Meta data
Hash:230118fe22abdfa2adae7fabcd4ce6577c92bceb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143229026 TriggerType:PUSH TriggerID:230118fe22abdfa2adae7fabcd4ce6577c92bceb
Hash:230118fe22abdfa2adae7fabcd4ce6577c92bceb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4124 TriggerType:PUSH TriggerID:230118fe22abdfa2adae7fabcd4ce6577c92bceb
Hash:d09f924b8a299087584f822180dd0fd51f50e0c1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4130 TriggerType:PUSH TriggerID:d09f924b8a299087584f822180dd0fd51f50e0c1
Hash:d09f924b8a299087584f822180dd0fd51f50e0c1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143235659 TriggerType:PUSH TriggerID:d09f924b8a299087584f822180dd0fd51f50e0c1
Hash:9f3e87d2f247d4970fdd41e9758f5575710f9cfa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4136 TriggerType:PUSH TriggerID:9f3e87d2f247d4970fdd41e9758f5575710f9cfa
Hash:9f3e87d2f247d4970fdd41e9758f5575710f9cfa Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143243281 TriggerType:PUSH TriggerID:9f3e87d2f247d4970fdd41e9758f5575710f9cfa
Hash:a219cce89f3c6fa14c063f4f2231b5f9830b68f6 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:a219cce89f3c6fa14c063f4f2231b5f9830b68f6
-->
## CI report:
* 230118fe22abdfa2adae7fabcd4ce6577c92bceb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143229026) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4124)
* d09f924b8a299087584f822180dd0fd51f50e0c1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143235659) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4130)
* 9f3e87d2f247d4970fdd41e9758f5575710f9cfa Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143243281) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4136)
* a219cce89f3c6fa14c063f4f2231b5f9830b68f6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10775:
[FLINK-15482][hive] Failed to call Hive functions returning decimal type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10775: [FLINK-15482][hive] Failed to call Hive functions returning decimal type
URL: https://github.com/apache/flink/pull/10775#issuecomment-571103452
<!--
Meta data
Hash:230118fe22abdfa2adae7fabcd4ce6577c92bceb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143229026 TriggerType:PUSH TriggerID:230118fe22abdfa2adae7fabcd4ce6577c92bceb
Hash:230118fe22abdfa2adae7fabcd4ce6577c92bceb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4124 TriggerType:PUSH TriggerID:230118fe22abdfa2adae7fabcd4ce6577c92bceb
Hash:d09f924b8a299087584f822180dd0fd51f50e0c1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4130 TriggerType:PUSH TriggerID:d09f924b8a299087584f822180dd0fd51f50e0c1
Hash:d09f924b8a299087584f822180dd0fd51f50e0c1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143235659 TriggerType:PUSH TriggerID:d09f924b8a299087584f822180dd0fd51f50e0c1
Hash:9f3e87d2f247d4970fdd41e9758f5575710f9cfa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4136 TriggerType:PUSH TriggerID:9f3e87d2f247d4970fdd41e9758f5575710f9cfa
Hash:9f3e87d2f247d4970fdd41e9758f5575710f9cfa Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143243281 TriggerType:PUSH TriggerID:9f3e87d2f247d4970fdd41e9758f5575710f9cfa
-->
## CI report:
* 230118fe22abdfa2adae7fabcd4ce6577c92bceb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143229026) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4124)
* d09f924b8a299087584f822180dd0fd51f50e0c1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143235659) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4130)
* 9f3e87d2f247d4970fdd41e9758f5575710f9cfa Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143243281) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4136)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10775:
[FLINK-15482][hive] Failed to call Hive functions returning decimal type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10775: [FLINK-15482][hive] Failed to call Hive functions returning decimal type
URL: https://github.com/apache/flink/pull/10775#issuecomment-571103452
<!--
Meta data
Hash:230118fe22abdfa2adae7fabcd4ce6577c92bceb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143229026 TriggerType:PUSH TriggerID:230118fe22abdfa2adae7fabcd4ce6577c92bceb
Hash:230118fe22abdfa2adae7fabcd4ce6577c92bceb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4124 TriggerType:PUSH TriggerID:230118fe22abdfa2adae7fabcd4ce6577c92bceb
Hash:d09f924b8a299087584f822180dd0fd51f50e0c1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4130 TriggerType:PUSH TriggerID:d09f924b8a299087584f822180dd0fd51f50e0c1
Hash:d09f924b8a299087584f822180dd0fd51f50e0c1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143235659 TriggerType:PUSH TriggerID:d09f924b8a299087584f822180dd0fd51f50e0c1
Hash:9f3e87d2f247d4970fdd41e9758f5575710f9cfa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4136 TriggerType:PUSH TriggerID:9f3e87d2f247d4970fdd41e9758f5575710f9cfa
Hash:9f3e87d2f247d4970fdd41e9758f5575710f9cfa Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143243281 TriggerType:PUSH TriggerID:9f3e87d2f247d4970fdd41e9758f5575710f9cfa
Hash:a219cce89f3c6fa14c063f4f2231b5f9830b68f6 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143363406 TriggerType:PUSH TriggerID:a219cce89f3c6fa14c063f4f2231b5f9830b68f6
Hash:a219cce89f3c6fa14c063f4f2231b5f9830b68f6 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4158 TriggerType:PUSH TriggerID:a219cce89f3c6fa14c063f4f2231b5f9830b68f6
-->
## CI report:
* 230118fe22abdfa2adae7fabcd4ce6577c92bceb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143229026) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4124)
* d09f924b8a299087584f822180dd0fd51f50e0c1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143235659) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4130)
* 9f3e87d2f247d4970fdd41e9758f5575710f9cfa Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143243281) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4136)
* a219cce89f3c6fa14c063f4f2231b5f9830b68f6 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143363406) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4158)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10775: [FLINK-15482][hive]
Failed to call Hive functions returning decimal type
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10775: [FLINK-15482][hive] Failed to call Hive functions returning decimal type
URL: https://github.com/apache/flink/pull/10775#issuecomment-571103452
<!--
Meta data
Hash:230118fe22abdfa2adae7fabcd4ce6577c92bceb Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:230118fe22abdfa2adae7fabcd4ce6577c92bceb
-->
## CI report:
* 230118fe22abdfa2adae7fabcd4ce6577c92bceb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10775:
[FLINK-15482][hive] Failed to call Hive functions returning decimal type
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10775: [FLINK-15482][hive] Failed to call Hive functions returning decimal type
URL: https://github.com/apache/flink/pull/10775#discussion_r363618108
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarFunctionCallGen.scala
##########
@@ -79,7 +80,8 @@ class ScalarFunctionCallGen(scalarFunction: ScalarFunction) extends CallGenerato
val boxedResultClass = ExtractionUtils.boxPrimitive(resultClass).asInstanceOf[Class[_]]
val javaTypeTerm = boxedResultClass.getCanonicalName
val resultExternalTypeWithResultClass =
- if (resultExternalType.getLogicalType.supportsOutputConversion(boxedResultClass)) {
+ if (LogicalTypeDataTypeConverter.fromDataTypeToLogicalType(resultExternalType)
Review comment:
Can you add a UDF case like:
```
class MyUdf extends ScalarFunction {
public Object eval(...) {...}
public TypeInformation getResultType() {
return Types.BIG_DECIMAL;
}
}
```
to repeat this bug?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #10775: [FLINK-15482][hive]
Failed to call Hive functions returning decimal type
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10775: [FLINK-15482][hive] Failed to call Hive functions returning decimal type
URL: https://github.com/apache/flink/pull/10775#issuecomment-571385097
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10775:
[FLINK-15482][hive] Failed to call Hive functions returning decimal type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10775: [FLINK-15482][hive] Failed to call Hive functions returning decimal type
URL: https://github.com/apache/flink/pull/10775#issuecomment-571103452
<!--
Meta data
Hash:230118fe22abdfa2adae7fabcd4ce6577c92bceb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143229026 TriggerType:PUSH TriggerID:230118fe22abdfa2adae7fabcd4ce6577c92bceb
Hash:230118fe22abdfa2adae7fabcd4ce6577c92bceb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4124 TriggerType:PUSH TriggerID:230118fe22abdfa2adae7fabcd4ce6577c92bceb
Hash:d09f924b8a299087584f822180dd0fd51f50e0c1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4130 TriggerType:PUSH TriggerID:d09f924b8a299087584f822180dd0fd51f50e0c1
Hash:d09f924b8a299087584f822180dd0fd51f50e0c1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143235659 TriggerType:PUSH TriggerID:d09f924b8a299087584f822180dd0fd51f50e0c1
Hash:9f3e87d2f247d4970fdd41e9758f5575710f9cfa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4136 TriggerType:PUSH TriggerID:9f3e87d2f247d4970fdd41e9758f5575710f9cfa
Hash:9f3e87d2f247d4970fdd41e9758f5575710f9cfa Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143243281 TriggerType:PUSH TriggerID:9f3e87d2f247d4970fdd41e9758f5575710f9cfa
Hash:a219cce89f3c6fa14c063f4f2231b5f9830b68f6 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143363406 TriggerType:PUSH TriggerID:a219cce89f3c6fa14c063f4f2231b5f9830b68f6
Hash:a219cce89f3c6fa14c063f4f2231b5f9830b68f6 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4158 TriggerType:PUSH TriggerID:a219cce89f3c6fa14c063f4f2231b5f9830b68f6
-->
## CI report:
* 230118fe22abdfa2adae7fabcd4ce6577c92bceb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143229026) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4124)
* d09f924b8a299087584f822180dd0fd51f50e0c1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143235659) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4130)
* 9f3e87d2f247d4970fdd41e9758f5575710f9cfa Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143243281) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4136)
* a219cce89f3c6fa14c063f4f2231b5f9830b68f6 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143363406) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4158)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10775:
[FLINK-15482][hive] Failed to call Hive functions returning decimal type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10775: [FLINK-15482][hive] Failed to call Hive functions returning decimal type
URL: https://github.com/apache/flink/pull/10775#issuecomment-571103452
<!--
Meta data
Hash:230118fe22abdfa2adae7fabcd4ce6577c92bceb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143229026 TriggerType:PUSH TriggerID:230118fe22abdfa2adae7fabcd4ce6577c92bceb
Hash:230118fe22abdfa2adae7fabcd4ce6577c92bceb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4124 TriggerType:PUSH TriggerID:230118fe22abdfa2adae7fabcd4ce6577c92bceb
Hash:d09f924b8a299087584f822180dd0fd51f50e0c1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4130 TriggerType:PUSH TriggerID:d09f924b8a299087584f822180dd0fd51f50e0c1
Hash:d09f924b8a299087584f822180dd0fd51f50e0c1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143235659 TriggerType:PUSH TriggerID:d09f924b8a299087584f822180dd0fd51f50e0c1
Hash:9f3e87d2f247d4970fdd41e9758f5575710f9cfa Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:9f3e87d2f247d4970fdd41e9758f5575710f9cfa
-->
## CI report:
* 230118fe22abdfa2adae7fabcd4ce6577c92bceb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143229026) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4124)
* d09f924b8a299087584f822180dd0fd51f50e0c1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143235659) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4130)
* 9f3e87d2f247d4970fdd41e9758f5575710f9cfa UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10775: [FLINK-15482][hive]
Failed to call Hive functions returning decimal type
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10775: [FLINK-15482][hive] Failed to call Hive functions returning decimal type
URL: https://github.com/apache/flink/pull/10775#issuecomment-571094465
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 230118fe22abdfa2adae7fabcd4ce6577c92bceb (Mon Jan 06 10:51:58 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15482).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong merged pull request #10775: [FLINK-15482][hive]
Failed to call Hive functions returning decimal type
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #10775: [FLINK-15482][hive] Failed to call Hive functions returning decimal type
URL: https://github.com/apache/flink/pull/10775
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10775:
[FLINK-15482][hive] Failed to call Hive functions returning decimal type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10775: [FLINK-15482][hive] Failed to call Hive functions returning decimal type
URL: https://github.com/apache/flink/pull/10775#issuecomment-571103452
<!--
Meta data
Hash:230118fe22abdfa2adae7fabcd4ce6577c92bceb Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143229026 TriggerType:PUSH TriggerID:230118fe22abdfa2adae7fabcd4ce6577c92bceb
Hash:230118fe22abdfa2adae7fabcd4ce6577c92bceb Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4124 TriggerType:PUSH TriggerID:230118fe22abdfa2adae7fabcd4ce6577c92bceb
-->
## CI report:
* 230118fe22abdfa2adae7fabcd4ce6577c92bceb Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143229026) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4124)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10775:
[FLINK-15482][hive] Failed to call Hive functions returning decimal type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10775: [FLINK-15482][hive] Failed to call Hive functions returning decimal type
URL: https://github.com/apache/flink/pull/10775#issuecomment-571103452
<!--
Meta data
Hash:230118fe22abdfa2adae7fabcd4ce6577c92bceb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143229026 TriggerType:PUSH TriggerID:230118fe22abdfa2adae7fabcd4ce6577c92bceb
Hash:230118fe22abdfa2adae7fabcd4ce6577c92bceb Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4124 TriggerType:PUSH TriggerID:230118fe22abdfa2adae7fabcd4ce6577c92bceb
Hash:d09f924b8a299087584f822180dd0fd51f50e0c1 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4130 TriggerType:PUSH TriggerID:d09f924b8a299087584f822180dd0fd51f50e0c1
Hash:d09f924b8a299087584f822180dd0fd51f50e0c1 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143235659 TriggerType:PUSH TriggerID:d09f924b8a299087584f822180dd0fd51f50e0c1
-->
## CI report:
* 230118fe22abdfa2adae7fabcd4ce6577c92bceb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143229026) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4124)
* d09f924b8a299087584f822180dd0fd51f50e0c1 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143235659) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4130)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services