You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "AlteredOracle (via GitHub)" <gi...@apache.org> on 2025/02/28 02:38:24 UTC
[PR] Fix MSSQL provider dependency on common-sql [airflow]
AlteredOracle opened a new pull request, #47188:
URL: https://github.com/apache/airflow/pull/47188
The MSSQL provider currently requires common-sql >= 1.20.0, but it's using the dialects module which was only introduced in common-sql 1.23.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix MSSQL provider dependency on common-sql [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #47188:
URL: https://github.com/apache/airflow/pull/47188#issuecomment-2692172547
Fastapi has been pinned temporarily already in main in https://github.com/apache/airflow/pull/47233 . Rebasing to account for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix MSSQL provider dependency on common-sql [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #47188:
URL: https://github.com/apache/airflow/pull/47188#issuecomment-2692169186
> not sure why static is failing. It says Generate the FastAPI API spec...............................................Failed.
Likely because of this:
```diff
> fastapi==0.115.9
---
> fastapi==0.115.10
```
There is a new fastapi generated and it apparently generates new output - you will see the same thing in canary builds https://github.com/apache/airflow/actions/runs/13602495440
Your PR modifies dependencies, so (unlike most other PRs) we will attempt to resolve new dependencies using whatever has been released since the last time we "froze" dependencies in constraints.
You can always see the list of updated dependencies in "summary" of the checks (just scroll down below the graph with the CI jobs and you will see what has been upgraded in your PR.
I will separately fix it in `main` - so once this is merged, you should be able to rebase and this one should be green then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix MSSQL provider dependency on common-sql [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #47188:
URL: https://github.com/apache/airflow/pull/47188#issuecomment-2692279807
FINALLY :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix MSSQL provider dependency on common-sql [airflow]
Posted by "AlteredOracle (via GitHub)" <gi...@apache.org>.
AlteredOracle commented on PR #47188:
URL: https://github.com/apache/airflow/pull/47188#issuecomment-2691912379
not sure why static is failing. It says Generate the FastAPI API spec...............................................Failed.
But is passes in local
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix MSSQL provider dependency on common-sql [airflow]
Posted by "AlteredOracle (via GitHub)" <gi...@apache.org>.
AlteredOracle commented on PR #47188:
URL: https://github.com/apache/airflow/pull/47188#issuecomment-2690331754
> Nice. But can you please install pre-commit and `commit --amend` ? This will auto-generate the rest of changes resulting from it? BTW. I will update the contributing docs to make it clearer :)
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix MSSQL provider dependency on common-sql [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #47188:
URL: https://github.com/apache/airflow/pull/47188#issuecomment-2692244993
Another badly merged main failure fixed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix MSSQL provider dependency on common-sql [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #47188:
URL: https://github.com/apache/airflow/pull/47188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix MSSQL provider dependency on common-sql [airflow]
Posted by "AlteredOracle (via GitHub)" <gi...@apache.org>.
AlteredOracle commented on PR #47188:
URL: https://github.com/apache/airflow/pull/47188#issuecomment-2692281883
yeah finally its done!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix MSSQL provider dependency on common-sql [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #47188:
URL: https://github.com/apache/airflow/pull/47188#issuecomment-2690054866
Nce. But can you please install pre-commit and `commit --amend` ? This will auto-generate the rest of changes resulting from it? BTW. I will update the contributing docs to make it clearer :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix MSSQL provider dependency on common-sql [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #47188:
URL: https://github.com/apache/airflow/pull/47188#issuecomment-2691620957
`breeze static-checks --only-my-changes` should do the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix MSSQL provider dependency on common-sql [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #47188:
URL: https://github.com/apache/airflow/pull/47188#issuecomment-2691411132
Static checks are still failing. Could you please run the following and commit?
`pre-commit run --al-files`
You can run `pre-commit install` this will make the hooks run in each commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix MSSQL provider dependency on common-sql [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #47188:
URL: https://github.com/apache/airflow/pull/47188#issuecomment-2690222559
I improved contributor's doc and pyproject.toml comments here explaining what you need to do https://github.com/apache/airflow/pull/47203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org