You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by sijie <gi...@git.apache.org> on 2017/06/22 01:50:17 UTC

[GitHub] bookkeeper pull request #204: Issue 203: TestFencing is failing due to LAC p...

GitHub user sijie opened a pull request:

    https://github.com/apache/bookkeeper/pull/204

    Issue 203: TestFencing is failing due to LAC piggyback changes

    Descriptions of the changes in this PR:
    
    Problem:
    
    TestFencing is failing after merging LAC piggyback changes. Because LAC piggyback will advance last add confirmed when reading entries.
    
    Solution:
    
    Move the addEntry verification to after reading entries.
    
    At the same time, add more logging to #testManyOpen 
    
    ---
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
    - [x] Make sure the PR title is formatted like:
        `<Issue #>: Description of pull request`
        `e.g. Issue 123: Description ...`
    - [x] Make sure tests pass via `mvn clean apache-rat:check install findbugs:check`.
    - [x] Replace `<Issue #>` in the title with the actual Issue number, if there is one.
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sijie/bookkeeper fix_test_fencing

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bookkeeper/pull/204.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #204
    
----
commit 05acb9a6ca48327b1bceb80b17bd1ed9edac4e7e
Author: Sijie Guo <si...@apache.org>
Date:   2017-06-22T01:46:39Z

    Issue 203: TestFencing is failing due to LAC piggyback changes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bookkeeper pull request #204: Issue 203: TestFencing is failing due to LAC p...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/bookkeeper/pull/204


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---