You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "lukaszwawrzyk (via GitHub)" <gi...@apache.org> on 2023/05/05 14:30:00 UTC
[GitHub] [rocketmq] lukaszwawrzyk opened a new pull request, #6695: Introduce Bazel Steward - a tool for keeping dependencies up to date in Bazel
lukaszwawrzyk opened a new pull request, #6695:
URL: https://github.com/apache/rocketmq/pull/6695
### Which Issue(s) This PR Fixes
I am happy to create a Github issue if you find Bazel Steward useful.
### Brief Description
Hello everyone,
As one of developers I am submitting this pull request to introduce our new tool for Bazel repositories. [Bazel Steward](https://github.com/VirtusLab/bazel-steward) simplifies the process of checking and updating dependencies in your Bazel projects, making it more efficient to keep them up-to-date.
We hope that this tool will be useful to the Bazel community, and we look forward to your feedback.
This pull request integrates Bazel Steward through Github Actions which is currently the easiest way to do this. It will run every day at 12 and create new PRs or resolve conflicts on existing if necessary. You can preview how it looks in [a fork](https://github.com/lukaszwawrzyk/rocketmq/pulls) that I used to test it. For more details, you can check [the project readme](https://github.com/VirtusLab/bazel-steward#readme).
Bazel Steward is able to correctly update all your maven dependencies, version of Bazel itself as well as Bazel rules.
We hope that Bazel Steward will make it easier for you to manage dependencies. If you have any questions, encounter any issues or have any feedback, please don't hesitate to reach out to me. Thank you!
Changes:
* Added GitHub Action Workflow for Bazel Steward
* Made rules_jvm_external url explicit - so that Bazel Steward can replace it reliably (as url scheme sometimes changes)
* Added config for Bazel Steward to limit concurrently open PRs to 10 to make it more manageable as I think there are 45 outdated dependencies here.
### How Did You Test This Change?
I run Bazel Steward on a fork that I mentioned earlier. I had to allow Github Actions for write access and managing PRs in repository settings. Additionally, in order to be able to have workflows triggered on Bazel Steward PRs, you'd need to follow this guide: https://github.com/VirtusLab/bazel-steward#triggering-workflows-for-pull-requests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ShadowySpirits commented on pull request #6695: Introduce Bazel Steward - a tool for keeping dependencies up to date in Bazel
Posted by "ShadowySpirits (via GitHub)" <gi...@apache.org>.
ShadowySpirits commented on PR #6695:
URL: https://github.com/apache/rocketmq/pull/6695#issuecomment-1537101299
I am afraid your action `VirtusLab/bazel-steward ` may not be introduced in RocketMQ due to the ASF limit. But I think Bazel Steward is a helpful tool, can you open a [discussion](https://github.com/apache/rocketmq/discussions) before submitting the pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lukaszwawrzyk closed pull request #6695: Introduce Bazel Steward - a tool for keeping dependencies up to date in Bazel
Posted by "lukaszwawrzyk (via GitHub)" <gi...@apache.org>.
lukaszwawrzyk closed pull request #6695: Introduce Bazel Steward - a tool for keeping dependencies up to date in Bazel
URL: https://github.com/apache/rocketmq/pull/6695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lukaszwawrzyk commented on pull request #6695: Introduce Bazel Steward - a tool for keeping dependencies up to date in Bazel
Posted by "lukaszwawrzyk (via GitHub)" <gi...@apache.org>.
lukaszwawrzyk commented on PR #6695:
URL: https://github.com/apache/rocketmq/pull/6695#issuecomment-1537104154
@ShadowySpirits Thanks for response! I opened a discussion here: https://github.com/apache/rocketmq/discussions/6711
Also, could you elaborate a bit on this ASF limit? Maybe something can be done about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #6695: Introduce Bazel Steward - a tool for keeping dependencies up to date in Bazel
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6695:
URL: https://github.com/apache/rocketmq/pull/6695#issuecomment-1537032176
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/6695?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6695](https://app.codecov.io/gh/apache/rocketmq/pull/6695?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e1484f7) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/57642bc630d5ee42cca026ae389ae3016a61bb9c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (57642bc) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## develop #6695 +/- ##
=============================================
- Coverage 43.02% 42.99% -0.03%
+ Complexity 9023 9017 -6
=============================================
Files 1109 1109
Lines 78631 78630 -1
Branches 10234 10233 -1
=============================================
- Hits 33830 33808 -22
- Misses 40568 40587 +19
- Partials 4233 4235 +2
```
[see 20 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/6695/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org