[GitHub] [tvm] yelite opened a new pull request, #14350: [Unity][BYOC] Check leaked intermediate variables in cutlass patterns

["yelite (via GitHub)" <gi...@apache.org>]

yelite opened a new pull request, #14350:
URL: https://github.com/apache/tvm/pull/14350

   This PR adds new check logic to the BYOC patterns for cutlass, to ensure intermediate variables in the fused region aren't used outside.
   
   For example, 
   ```python
   @R.function
   def main(x: R.Tensor((128, 128), "float16"), w: R.Tensor((128, 128), "float16")):
       with R.dataflow():
           lv = R.matmul(x, w)
           lv1 = R.power(lv, R.const(2.0, "float16"))
           lv2 = R.add(lv, lv1)
           R.output(lv2)
       return lv2
   ```
   Without the new check logic, this function would be fused as biased matmul, which isn't correct because the bias (`lv1`) depends on the result of matmul.
   
   cc @vinx13 @masahi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi merged pull request #14350: [Unity][BYOC] Check leaked intermediate variables in cutlass patterns

["masahi (via GitHub)" <gi...@apache.org>]

masahi merged PR #14350:
URL: https://github.com/apache/tvm/pull/14350


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #14350: [Unity][BYOC] Check leaked intermediate variables in cutlass patterns

["tvm-bot (via GitHub)" <gi...@apache.org>]

tvm-bot commented on PR #14350:
URL: https://github.com/apache/tvm/pull/14350#issuecomment-1477229870

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @billishyahao, @quic-sanirudh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org