You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/20 07:07:34 UTC
[GitHub] [flink] simenliuxing opened a new pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
simenliuxing opened a new pull request #18414:
URL: https://github.com/apache/flink/pull/18414
## What is the purpose of the change
Aliases need to be used under Cascading Window Aggregation, otherwise an error will be reported, but there is no such thing in the documentation, so I fixed it
## Brief change log
Fix errors in documentation, add aliases
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] simenliuxing commented on a change in pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
simenliuxing commented on a change in pull request #18414:
URL: https://github.com/apache/flink/pull/18414#discussion_r789382619
##########
File path: docs/content.zh/docs/dev/table/sql/queries/window-agg.md
##########
@@ -199,7 +199,7 @@ The following shows a cascading window aggregation where the first window aggreg
```sql
-- tumbling 5 minutes for each supplier_id
CREATE VIEW window1 AS
-SELECT window_start, window_end, window_time as rowtime, SUM(price) as partial_price
+SELECT window_start as window1_start, window_end as window1_end, window_time as rowtime, SUM(price) as partial_price
Review comment:
Thanks for your suggestion, I have revised
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on a change in pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on a change in pull request #18414:
URL: https://github.com/apache/flink/pull/18414#discussion_r789292974
##########
File path: docs/content.zh/docs/dev/table/sql/queries/window-agg.md
##########
@@ -199,7 +199,7 @@ The following shows a cascading window aggregation where the first window aggreg
```sql
-- tumbling 5 minutes for each supplier_id
CREATE VIEW window1 AS
-SELECT window_start, window_end, window_time as rowtime, SUM(price) as partial_price
+SELECT window_start as window1_start, window_end as window1_end, window_time as rowtime, SUM(price) as partial_price
Review comment:
Could you add some comments here to explain that we need alias here to avoid name conflict?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18414:
URL: https://github.com/apache/flink/pull/18414#issuecomment-1017182067
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762",
"triggerID" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"triggerType" : "PUSH"
}, {
"hash" : "e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29856",
"triggerID" : "e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f",
"triggerType" : "PUSH"
}, {
"hash" : "2d7b1b7425be2b9cfb9020d92cf08cc6d5596ef6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2d7b1b7425be2b9cfb9020d92cf08cc6d5596ef6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c3aedefda07bea1b5cf7223b4f0305f469d9e15 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762)
* e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29856)
* 2d7b1b7425be2b9cfb9020d92cf08cc6d5596ef6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] simenliuxing commented on a change in pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
simenliuxing commented on a change in pull request #18414:
URL: https://github.com/apache/flink/pull/18414#discussion_r790426803
##########
File path: docs/content.zh/docs/dev/table/sql/queries/window-agg.md
##########
@@ -199,7 +199,8 @@ The following shows a cascading window aggregation where the first window aggreg
```sql
-- tumbling 5 minutes for each supplier_id
CREATE VIEW window1 AS
-SELECT window_start, window_end, window_time as rowtime, SUM(price) as partial_price
+-- under the Cascading Window Aggregation to avoid field ambiguity window_start and window_end need to be renamed
Review comment:
Looks good to me, I have revised
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18414:
URL: https://github.com/apache/flink/pull/18414#issuecomment-1017182067
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762",
"triggerID" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"triggerType" : "PUSH"
}, {
"hash" : "e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29856",
"triggerID" : "e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f",
"triggerType" : "PUSH"
}, {
"hash" : "2d7b1b7425be2b9cfb9020d92cf08cc6d5596ef6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29864",
"triggerID" : "2d7b1b7425be2b9cfb9020d92cf08cc6d5596ef6",
"triggerType" : "PUSH"
}, {
"hash" : "e59d3cd9b63b0fef051a3b02094eb05bd1c58d12",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29985",
"triggerID" : "e59d3cd9b63b0fef051a3b02094eb05bd1c58d12",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2d7b1b7425be2b9cfb9020d92cf08cc6d5596ef6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29864)
* e59d3cd9b63b0fef051a3b02094eb05bd1c58d12 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29985)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on a change in pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on a change in pull request #18414:
URL: https://github.com/apache/flink/pull/18414#discussion_r790381192
##########
File path: docs/content.zh/docs/dev/table/sql/queries/window-agg.md
##########
@@ -199,7 +199,8 @@ The following shows a cascading window aggregation where the first window aggreg
```sql
-- tumbling 5 minutes for each supplier_id
CREATE VIEW window1 AS
-SELECT window_start, window_end, window_time as rowtime, SUM(price) as partial_price
+-- under the Cascading Window Aggregation to avoid field ambiguity window_start and window_end need to be renamed
Review comment:
```suggestion
-- Note: The window start and window end fields of inner Window TVF are optional in the select clause. However, if they appear in the clause, they need to be aliased to prevent name conflicting with the window start and window end of the outer Window TVF.
```
WDTY?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] simenliuxing commented on a change in pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
simenliuxing commented on a change in pull request #18414:
URL: https://github.com/apache/flink/pull/18414#discussion_r789396137
##########
File path: docs/content.zh/docs/dev/table/sql/queries/window-agg.md
##########
@@ -199,7 +199,7 @@ The following shows a cascading window aggregation where the first window aggreg
```sql
-- tumbling 5 minutes for each supplier_id
CREATE VIEW window1 AS
-SELECT window_start, window_end, window_time as rowtime, SUM(price) as partial_price
+SELECT window_start as window1_start, window_end as window1_end, window_time as rowtime, SUM(price) as partial_price
Review comment:
@beyond1920
Sorry for misunderstanding, I have added the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 merged pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
beyond1920 merged pull request #18414:
URL: https://github.com/apache/flink/pull/18414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18414:
URL: https://github.com/apache/flink/pull/18414#issuecomment-1017182067
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762",
"triggerID" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c3aedefda07bea1b5cf7223b4f0305f469d9e15 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] simenliuxing commented on a change in pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
simenliuxing commented on a change in pull request #18414:
URL: https://github.com/apache/flink/pull/18414#discussion_r789333463
##########
File path: docs/content.zh/docs/dev/table/sql/queries/window-agg.md
##########
@@ -199,7 +199,7 @@ The following shows a cascading window aggregation where the first window aggreg
```sql
-- tumbling 5 minutes for each supplier_id
CREATE VIEW window1 AS
-SELECT window_start, window_end, window_time as rowtime, SUM(price) as partial_price
+SELECT window_start as window1_start, window_end as window1_end, window_time as rowtime, SUM(price) as partial_price
Review comment:
When i use sql as below:
```
-- tumbling 5 minutes for each supplier_id
CREATE VIEW window1 AS
SELECT window_start as window1_start, window_end as window1_end, window_time as rowtime, SUM(price) as partial_price
FROM TABLE(
TUMBLE(TABLE Bid, DESCRIPTOR(bidtime), INTERVAL '5' MINUTES))
GROUP BY supplier_id, window_start, window_end, window_time;
-- tumbling 10 minutes on the first window
SELECT window_start, window_end, SUM(partial_price) as total_price
FROM TABLE(
TUMBLE(TABLE window1, DESCRIPTOR(rowtime), INTERVAL '10' MINUTES))
GROUP BY window_start, window_end;
```
The following exception occurs:
```
Caused by: org.apache.calcite.sql.validate.SqlValidatorException: Column 'window_start' is ambiguous
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at org.apache.calcite.runtime.Resources$ExInstWithCause.ex(Resources.java:467)
at org.apache.calcite.runtime.Resources$ExInst.ex(Resources.java:560)
... 41 more
```
I think the following piece of sql cannot identify whether window_start is from window1 or from built-in.
But the following sql is for Group Window Aggregation, the required window_start and window_end are not from window1, So I renamed window_start and window_end in the above sql.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] simenliuxing commented on a change in pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
simenliuxing commented on a change in pull request #18414:
URL: https://github.com/apache/flink/pull/18414#discussion_r789375653
##########
File path: docs/content.zh/docs/dev/table/sql/queries/window-agg.md
##########
@@ -199,7 +199,7 @@ The following shows a cascading window aggregation where the first window aggreg
```sql
-- tumbling 5 minutes for each supplier_id
CREATE VIEW window1 AS
-SELECT window_start, window_end, window_time as rowtime, SUM(price) as partial_price
+SELECT window_start as window1_start, window_end as window1_end, window_time as rowtime, SUM(price) as partial_price
Review comment:
ok i see. this is the result of other communication with me
https://issues.apache.org/jira/browse/FLINK-25700?filter=-2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18414:
URL: https://github.com/apache/flink/pull/18414#issuecomment-1017182067
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762",
"triggerID" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"triggerType" : "PUSH"
}, {
"hash" : "e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29856",
"triggerID" : "e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c3aedefda07bea1b5cf7223b4f0305f469d9e15 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762)
* e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29856)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] simenliuxing removed a comment on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
simenliuxing removed a comment on pull request #18414:
URL: https://github.com/apache/flink/pull/18414#issuecomment-1017183560
@wenlong88 hello, can you help me review the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #18414:
URL: https://github.com/apache/flink/pull/18414#discussion_r789377665
##########
File path: docs/content.zh/docs/dev/table/sql/queries/window-agg.md
##########
@@ -199,7 +199,7 @@ The following shows a cascading window aggregation where the first window aggreg
```sql
-- tumbling 5 minutes for each supplier_id
CREATE VIEW window1 AS
-SELECT window_start, window_end, window_time as rowtime, SUM(price) as partial_price
+SELECT window_start as window1_start, window_end as window1_end, window_time as rowtime, SUM(price) as partial_price
Review comment:
I see. If that's the case, then I guess we should indeed update this documentation :) I would then only slightly modify the alias to make it more clearer, something like:
```suggestion
SELECT window_start as window_5mintumble_start, window_end as window_5mintumble_end, window_time as rowtime, SUM(price) as partial_price
```
or
```suggestion
SELECT window_start as window_5mintumblepersupplier_start, window_end as window_5mintumblepersupplier_end, window_time as rowtime, SUM(price) as partial_price
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #18414:
URL: https://github.com/apache/flink/pull/18414#discussion_r789383574
##########
File path: docs/content.zh/docs/dev/table/sql/queries/window-agg.md
##########
@@ -199,7 +199,7 @@ The following shows a cascading window aggregation where the first window aggreg
```sql
-- tumbling 5 minutes for each supplier_id
CREATE VIEW window1 AS
-SELECT window_start, window_end, window_time as rowtime, SUM(price) as partial_price
+SELECT window_start as window1_start, window_end as window1_end, window_time as rowtime, SUM(price) as partial_price
Review comment:
Looks good to me, what do you think @beyond1920 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #18414:
URL: https://github.com/apache/flink/pull/18414#discussion_r789373449
##########
File path: docs/content.zh/docs/dev/table/sql/queries/window-agg.md
##########
@@ -199,7 +199,7 @@ The following shows a cascading window aggregation where the first window aggreg
```sql
-- tumbling 5 minutes for each supplier_id
CREATE VIEW window1 AS
-SELECT window_start, window_end, window_time as rowtime, SUM(price) as partial_price
+SELECT window_start as window1_start, window_end as window1_end, window_time as rowtime, SUM(price) as partial_price
Review comment:
I'm not sure if that a proper fix is changing the documentation. I would expect that we should address the issue to avoid getting the exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] simenliuxing commented on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
simenliuxing commented on pull request #18414:
URL: https://github.com/apache/flink/pull/18414#issuecomment-1018086655
@MartijnVisser Can you review it for me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18414:
URL: https://github.com/apache/flink/pull/18414#issuecomment-1017182067
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c3aedefda07bea1b5cf7223b4f0305f469d9e15 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on a change in pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on a change in pull request #18414:
URL: https://github.com/apache/flink/pull/18414#discussion_r789384222
##########
File path: docs/content.zh/docs/dev/table/sql/queries/window-agg.md
##########
@@ -199,7 +199,7 @@ The following shows a cascading window aggregation where the first window aggreg
```sql
-- tumbling 5 minutes for each supplier_id
CREATE VIEW window1 AS
-SELECT window_start, window_end, window_time as rowtime, SUM(price) as partial_price
+SELECT window_start as window1_start, window_end as window1_end, window_time as rowtime, SUM(price) as partial_price
Review comment:
@simenliuxing Thanks for explain.
I mean to add some comments in documents to explain that we need alias here to avoid name conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18414:
URL: https://github.com/apache/flink/pull/18414#issuecomment-1017182067
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762",
"triggerID" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"triggerType" : "PUSH"
}, {
"hash" : "e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29856",
"triggerID" : "e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f",
"triggerType" : "PUSH"
}, {
"hash" : "2d7b1b7425be2b9cfb9020d92cf08cc6d5596ef6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29864",
"triggerID" : "2d7b1b7425be2b9cfb9020d92cf08cc6d5596ef6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c3aedefda07bea1b5cf7223b4f0305f469d9e15 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762)
* e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29856)
* 2d7b1b7425be2b9cfb9020d92cf08cc6d5596ef6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29864)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18414:
URL: https://github.com/apache/flink/pull/18414#issuecomment-1017182067
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762",
"triggerID" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"triggerType" : "PUSH"
}, {
"hash" : "e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29856",
"triggerID" : "e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f",
"triggerType" : "PUSH"
}, {
"hash" : "2d7b1b7425be2b9cfb9020d92cf08cc6d5596ef6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2d7b1b7425be2b9cfb9020d92cf08cc6d5596ef6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c3aedefda07bea1b5cf7223b4f0305f469d9e15 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762)
* e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29856)
* 2d7b1b7425be2b9cfb9020d92cf08cc6d5596ef6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] simenliuxing commented on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
simenliuxing commented on pull request #18414:
URL: https://github.com/apache/flink/pull/18414#issuecomment-1017183560
@wenlong88 hello, can you help me review the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18414:
URL: https://github.com/apache/flink/pull/18414#issuecomment-1017182067
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762",
"triggerID" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"triggerType" : "PUSH"
}, {
"hash" : "e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29856",
"triggerID" : "e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f",
"triggerType" : "PUSH"
}, {
"hash" : "2d7b1b7425be2b9cfb9020d92cf08cc6d5596ef6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29864",
"triggerID" : "2d7b1b7425be2b9cfb9020d92cf08cc6d5596ef6",
"triggerType" : "PUSH"
}, {
"hash" : "e59d3cd9b63b0fef051a3b02094eb05bd1c58d12",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e59d3cd9b63b0fef051a3b02094eb05bd1c58d12",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2d7b1b7425be2b9cfb9020d92cf08cc6d5596ef6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29864)
* e59d3cd9b63b0fef051a3b02094eb05bd1c58d12 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18414:
URL: https://github.com/apache/flink/pull/18414#issuecomment-1017182067
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762",
"triggerID" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"triggerType" : "PUSH"
}, {
"hash" : "e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29856",
"triggerID" : "e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c3aedefda07bea1b5cf7223b4f0305f469d9e15 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762)
* e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29856)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18414:
URL: https://github.com/apache/flink/pull/18414#issuecomment-1017182067
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762",
"triggerID" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"triggerType" : "PUSH"
}, {
"hash" : "e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c3aedefda07bea1b5cf7223b4f0305f469d9e15 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762)
* e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18414:
URL: https://github.com/apache/flink/pull/18414#issuecomment-1017182067
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762",
"triggerID" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"triggerType" : "PUSH"
}, {
"hash" : "e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29856",
"triggerID" : "e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c3aedefda07bea1b5cf7223b4f0305f469d9e15 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762)
* e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29856)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18414:
URL: https://github.com/apache/flink/pull/18414#issuecomment-1017182067
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762",
"triggerID" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"triggerType" : "PUSH"
}, {
"hash" : "e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29856",
"triggerID" : "e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f",
"triggerType" : "PUSH"
}, {
"hash" : "2d7b1b7425be2b9cfb9020d92cf08cc6d5596ef6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29864",
"triggerID" : "2d7b1b7425be2b9cfb9020d92cf08cc6d5596ef6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2d7b1b7425be2b9cfb9020d92cf08cc6d5596ef6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29864)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on pull request #18414:
URL: https://github.com/apache/flink/pull/18414#issuecomment-1019837686
Merged. Thanks for contribution @simenliuxing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] simenliuxing commented on a change in pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
simenliuxing commented on a change in pull request #18414:
URL: https://github.com/apache/flink/pull/18414#discussion_r789333463
##########
File path: docs/content.zh/docs/dev/table/sql/queries/window-agg.md
##########
@@ -199,7 +199,7 @@ The following shows a cascading window aggregation where the first window aggreg
```sql
-- tumbling 5 minutes for each supplier_id
CREATE VIEW window1 AS
-SELECT window_start, window_end, window_time as rowtime, SUM(price) as partial_price
+SELECT window_start as window1_start, window_end as window1_end, window_time as rowtime, SUM(price) as partial_price
Review comment:
@beyond1920
When i use sql as below:
```
-- tumbling 5 minutes for each supplier_id
CREATE VIEW window1 AS
SELECT window_start as window1_start, window_end as window1_end, window_time as rowtime, SUM(price) as partial_price
FROM TABLE(
TUMBLE(TABLE Bid, DESCRIPTOR(bidtime), INTERVAL '5' MINUTES))
GROUP BY supplier_id, window_start, window_end, window_time;
-- tumbling 10 minutes on the first window
SELECT window_start, window_end, SUM(partial_price) as total_price
FROM TABLE(
TUMBLE(TABLE window1, DESCRIPTOR(rowtime), INTERVAL '10' MINUTES))
GROUP BY window_start, window_end;
```
The following exception occurs:
```
Caused by: org.apache.calcite.sql.validate.SqlValidatorException: Column 'window_start' is ambiguous
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at org.apache.calcite.runtime.Resources$ExInstWithCause.ex(Resources.java:467)
at org.apache.calcite.runtime.Resources$ExInst.ex(Resources.java:560)
... 41 more
```
I think the following piece of sql cannot identify whether window_start is from window1 or from built-in.
But the following sql is for Group Window Aggregation, the required window_start and window_end are not from window1, So I renamed window_start and window_end in the above sql.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18414:
URL: https://github.com/apache/flink/pull/18414#issuecomment-1017180731
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 3c3aedefda07bea1b5cf7223b4f0305f469d9e15 (Thu Jan 20 07:11:16 UTC 2022)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18414:
URL: https://github.com/apache/flink/pull/18414#issuecomment-1017182067
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762",
"triggerID" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c3aedefda07bea1b5cf7223b4f0305f469d9e15 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18414:
URL: https://github.com/apache/flink/pull/18414#issuecomment-1017182067
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762",
"triggerID" : "3c3aedefda07bea1b5cf7223b4f0305f469d9e15",
"triggerType" : "PUSH"
}, {
"hash" : "e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29856",
"triggerID" : "e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f",
"triggerType" : "PUSH"
}, {
"hash" : "2d7b1b7425be2b9cfb9020d92cf08cc6d5596ef6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2d7b1b7425be2b9cfb9020d92cf08cc6d5596ef6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c3aedefda07bea1b5cf7223b4f0305f469d9e15 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29762)
* e44c4ea4af2af963a9d80bc4ea20d2dd671ef48f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29856)
* 2d7b1b7425be2b9cfb9020d92cf08cc6d5596ef6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org