You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@streams.apache.org by steveblackmon <gi...@git.apache.org> on 2015/10/14 23:10:09 UTC

[GitHub] incubator-streams pull request: resolves STREAMS-370

GitHub user steveblackmon opened a pull request:

    https://github.com/apache/incubator-streams/pull/262

    resolves STREAMS-370

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/steveblackmon/incubator-streams STREAMS-370

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-streams/pull/262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #262
    
----
commit 5a2b143a195c21093a351cac86675b6f4514669e
Author: Steve Blackmon <sb...@apache.org>
Date:   2015-10-14T19:25:31Z

    resolves STREAMS-370

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams pull request: resolves STREAMS-370

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-streams/pull/262


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams pull request: resolves STREAMS-370

Posted by steveblackmon <gi...@git.apache.org>.

Github user steveblackmon commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/262#discussion_r42794801
  
    --- Diff: streams-contrib/streams-persist-graph/src/main/java/org/apache/streams/graph/GraphHttpPersistWriter.java ---
    @@ -218,7 +217,7 @@ protected ObjectNode executePost(HttpPost httpPost) {
         @Override
         public void prepare(Object configurationObject) {
    --- End diff --
    
    I created https://issues.apache.org/jira/browse/STREAMS-375 to address this project-wide.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams pull request: resolves STREAMS-370

Posted by eponvert <gi...@git.apache.org>.

Github user eponvert commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/262#discussion_r42530508
  
    --- Diff: streams-contrib/streams-persist-graph/src/main/java/org/apache/streams/graph/GraphHttpPersistWriter.java ---
    @@ -218,7 +217,7 @@ protected ObjectNode executePost(HttpPost httpPost) {
         @Override
         public void prepare(Object configurationObject) {
    --- End diff --
    
    but in the event the method caller *does* pass in an object, do you want to try to do something with it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams pull request: resolves STREAMS-370

Posted by steveblackmon <gi...@git.apache.org>.

Github user steveblackmon commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/262#discussion_r42417751
  
    --- Diff: streams-contrib/streams-persist-graph/src/main/java/org/apache/streams/graph/GraphHttpPersistWriter.java ---
    @@ -218,7 +217,7 @@ protected ObjectNode executePost(HttpPost httpPost) {
         @Override
         public void prepare(Object configurationObject) {
    --- End diff --
    
    prepare(Object) is defined by the interface and thus has to be implemented, but exact implementation details vary.  Most modules source component configurations at component creation (constructor) time as the runtimes are for the most part not set up to supply useful configurationObjects.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams pull request: resolves STREAMS-370

Posted by eponvert <gi...@git.apache.org>.

Github user eponvert commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/262#discussion_r42377148
  
    --- Diff: streams-contrib/streams-persist-graph/src/main/java/org/apache/streams/graph/GraphHttpPersistWriter.java ---
    @@ -218,7 +217,7 @@ protected ObjectNode executePost(HttpPost httpPost) {
         @Override
         public void prepare(Object configurationObject) {
    --- End diff --
    
    This method effectively ignores the `configurationObject` parameter -- should the parameter be removed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---