You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2009/06/23 14:00:15 UTC
svn commit: r787648 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt
Date: Tue Jun 23 12:00:14 2009
New Revision: 787648
URL: http://svn.apache.org/viewvc?rev=787648&view=rev
Log:
Improved, single patch
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=787648&r1=787647&r2=787648&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Jun 23 12:00:14 2009
@@ -198,12 +198,8 @@
+1: kkolinko, markt
-1:
-* Make diagnosing broken requests a little easier. Having to copy the values is
- a pain but I can't see an alternative. On balance I think it is worth it but I
- appreciate others may disagree.
- http://svn.apache.org/viewvc?rev=783724&view=rev
- http://svn.apache.org/viewvc?rev=786468&view=rev
- http://svn.apache.org/viewvc?rev=786667&view=rev
+* Make diagnosing broken requests a little easier.
+ http://people.apache.org/~markt/patches/2009-06-23-parameters.patch
+1: markt
-1:
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r787648 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Mark Thomas <ma...@apache.org>.
Konstantin Kolinko wrote:
> 2009/6/23 <ma...@apache.org>
>> Author: markt
>> Date: Tue Jun 23 12:00:14 2009
>> New Revision: 787648
>>
>> URL: http://svn.apache.org/viewvc?rev=787648&view=rev
>> Log:
>> Improved, single patch
>>
>> +* Make diagnosing broken requests a little easier.
>> + http://people.apache.org/~markt/patches/2009-06-23-parameters.patch
>>
>
> I'm sorry to bother:
>
> The following line in the first part of the patch:
>
> msg.append(new String(bytes, nameStart, valEnd - nameStart));
>
> This String constructor will use the platform default encoding.
> I suppose it should be ISO-8859-1 here?
Yes, and elsewhere in the class. I'll make the changes.
> Also
> + ByteChunk origName=new ByteChunk();
> + ByteChunk origValue=new ByteChunk();
> can be 'private' here.
Agreed.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r787648 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Konstantin Kolinko <kn...@gmail.com>.
2009/6/23 <ma...@apache.org>
>
> Author: markt
> Date: Tue Jun 23 12:00:14 2009
> New Revision: 787648
>
> URL: http://svn.apache.org/viewvc?rev=787648&view=rev
> Log:
> Improved, single patch
>
> +* Make diagnosing broken requests a little easier.
> + http://people.apache.org/~markt/patches/2009-06-23-parameters.patch
>
I'm sorry to bother:
The following line in the first part of the patch:
msg.append(new String(bytes, nameStart, valEnd - nameStart));
This String constructor will use the platform default encoding.
I suppose it should be ISO-8859-1 here?
Also
+ ByteChunk origName=new ByteChunk();
+ ByteChunk origValue=new ByteChunk();
can be 'private' here.
The rest of it looks good.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org