[GitHub] [accumulo-classloaders] cshannon commented on a diff in pull request #19: Remove usage of deprecated AccessController

["cshannon (via GitHub)" <gi...@apache.org>]

cshannon commented on code in PR #19:
URL: https://github.com/apache/accumulo-classloaders/pull/19#discussion_r1124544458


##########
modules/vfs-class-loader/src/test/java/org/apache/accumulo/classloader/vfs/context/ReloadingVFSContextClassLoaderFactoryTest.java:
##########
@@ -64,43 +62,37 @@ public TestReloadingVFSContextClassLoaderFactory(String dir) {
       this.dir = dir;
     }
 
+    @SuppressFBWarnings(value = "DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED",
+        justification = "Security Manager is deprecated for removal as of JDK 17")

Review Comment:
   I tried that and it did not. There seems to still be open issue for it: https://github.com/spotbugs/spotbugs/issues/1515
   
   Furthermore it caused SpotBugs to throw a bunch more warnings so I figured we'd update it separately.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org