[jira] Commented: (BUILDR-107) compile_task.from(sources) does not support files that are java classes in a named package

["Assaf Arkin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BUILDR-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617489#action_12617489 ] 

Assaf Arkin commented on BUILDR-107:
------------------------------------

Third option, compare the timestamp to the target directory.   The last thing the compiler does is touch the target directory, so after successful compile, target is newer then sources and the next compile will do nothing.  So that's another option to determine if there's work to be done.

However, it also creates the target directory on first run, so it will be newer than sources even if compilation failed, so we need a solution for that.


> compile_task.from(sources) does not support files that are java classes in a named package
> ------------------------------------------------------------------------------------------
>
>                 Key: BUILDR-107
>                 URL: https://issues.apache.org/jira/browse/BUILDR-107
>             Project: Buildr
>          Issue Type: Bug
>          Components: Compilers
>    Affects Versions: 1.3.3
>         Environment: Trunk revision 679935
>            Reporter: Lacton
>            Priority: Minor
>         Attachments: BUILDR-107_specs.patch
>
>
> Compile tasks accepts source files. Yet they do not handle them correctly when the source file is a java class in a named package. Compile tasks believes that "src/main/java/thepackage/Test1.java" should be compiled to "target/classes/Test1.class" instead of "target/classes/thepackage/Test1.class".
> When changing compile_spec.rb to use java source files in a named package, there are two failing tests.
> 1)
> 'Buildr::CompileTask#invoke should not force compilation if sources older than compiled' FAILED
> Expected the tasks foo:compile to not run, but they all ran.
> /buildr-trunk/spec/compile_spec.rb:323:
> 2)
> 'Buildr::CompileTask#invoke should not force compilation if dependencies older than compiled' FAILED
> Expected the tasks foo:compile to not run, but they all ran.
> /buildr-trunk/spec/compile_spec.rb:342:
> I can think of two ways to fix this issue. Either compile tasks should reject source files and accept only source directory. Or they need to be smarter and figure out the package of java source files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.