[GitHub] amansinha100 commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest

[GitBox <gi...@apache.org>]

amansinha100 commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest
URL: https://github.com/apache/drill/pull/1401#discussion_r205918553
 
 

 ##########
 File path: contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcPrel.java
 ##########
 @@ -130,4 +131,10 @@ public SelectionVectorMode getEncoding() {
   public boolean needsFinalColumnReordering() {
     return false;
   }
+
+  @Override
+  public Prel addImplicitRowIDCol(List<RelNode> children) {
 
 Review comment:
   I am thinking a cleaner interface would be to have an additional method `supportsImplicitRIDCol()`  which would return FALSE by default.  You could use the Java 8 feature for default interface methods [1].   Only call `addImplicitRowIdCol()` if adding the rowid is supported.  
   
   [1] https://dzone.com/articles/interface-default-methods-java

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services