You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/03/04 10:12:14 UTC

Review Request: SQOOP-454: Upgrade dependency on HBase version 0.92.0-SNAPSHOT as it was already released

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4169/
-----------------------------------------------------------

Review request for Sqoop, Arvind Prabhakar and Bilung Lee.


Summary
-------

I've changed dependency to 0.92.1-SNAPSHOT.


This addresses bug SQOOP-454.
    https://issues.apache.org/jira/browse/SQOOP-454


Diffs
-----

  /build.xml 1296766 

Diff: https://reviews.apache.org/r/4169/diff


Testing
-------

ant -Dhadoopversion={100,23} test


Thanks,

Jarek


Re: Review Request: SQOOP-454: Upgrade dependency on HBase version 0.92.0-SNAPSHOT as it was already released

Posted by Arvind Prabhakar <ar...@apache.org>.

> On 2012-03-05 17:22:27, Arvind Prabhakar wrote:
> > Thanks for the patch Jarcec. I think it will be better to depend upon 0.92.0 release as opposed to snapshot. I understand that the 0.92.0 does not have it's test artifact deployed on the maven repository yet, but hopefully they will do that soon (I pinged them this morning).
> > 
> > Thanks
> 
> Jarek Cecho wrote:
>     Thank you very much for the ping Arvind. I got an impression that they are not planning to deploy testing jar for 0.92.0 version at all and that they will do that for 0.92.1. I'll be happy to change my patch and retest it once again after they publish it.
>     
>     Jarcec
> 
> Arvind Prabhakar wrote:
>     I raised this as a request on the hbase-dev list [1]. Hopefully they will respond soon - but if they decide not to, then we have no choice but to go with the 0.92.1-SNAPSHOT version as per your patch.
>     
>     [1] http://markmail.org/message/6xmf2xvv6sf37mni
>

Hi Jarcec - the HBase 0.92.0 test artifact is also available via central repository now. Please update your patch and I will be happy to commit it. Thanks for waiting on this.

Thanks


- Arvind


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4169/#review5612
-----------------------------------------------------------


On 2012-03-04 09:12:13, Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4169/
> -----------------------------------------------------------
> 
> (Updated 2012-03-04 09:12:13)
> 
> 
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
> 
> 
> Summary
> -------
> 
> I've changed dependency to 0.92.1-SNAPSHOT.
> 
> 
> This addresses bug SQOOP-454.
>     https://issues.apache.org/jira/browse/SQOOP-454
> 
> 
> Diffs
> -----
> 
>   /build.xml 1296766 
> 
> Diff: https://reviews.apache.org/r/4169/diff
> 
> 
> Testing
> -------
> 
> ant -Dhadoopversion={100,23} test
> 
> 
> Thanks,
> 
> Jarek
> 
>


Re: Review Request: SQOOP-454: Upgrade dependency on HBase version 0.92.0-SNAPSHOT as it was already released

Posted by Jarek Cecho <ja...@apache.org>.

> On 2012-03-05 17:22:27, Arvind Prabhakar wrote:
> > Thanks for the patch Jarcec. I think it will be better to depend upon 0.92.0 release as opposed to snapshot. I understand that the 0.92.0 does not have it's test artifact deployed on the maven repository yet, but hopefully they will do that soon (I pinged them this morning).
> > 
> > Thanks

Thank you very much for the ping Arvind. I got an impression that they are not planning to deploy testing jar for 0.92.0 version at all and that they will do that for 0.92.1. I'll be happy to change my patch and retest it once again after they publish it.

Jarcec


- Jarek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4169/#review5612
-----------------------------------------------------------


On 2012-03-04 09:12:13, Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4169/
> -----------------------------------------------------------
> 
> (Updated 2012-03-04 09:12:13)
> 
> 
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
> 
> 
> Summary
> -------
> 
> I've changed dependency to 0.92.1-SNAPSHOT.
> 
> 
> This addresses bug SQOOP-454.
>     https://issues.apache.org/jira/browse/SQOOP-454
> 
> 
> Diffs
> -----
> 
>   /build.xml 1296766 
> 
> Diff: https://reviews.apache.org/r/4169/diff
> 
> 
> Testing
> -------
> 
> ant -Dhadoopversion={100,23} test
> 
> 
> Thanks,
> 
> Jarek
> 
>


Re: Review Request: SQOOP-454: Upgrade dependency on HBase version 0.92.0-SNAPSHOT as it was already released

Posted by Arvind Prabhakar <ar...@apache.org>.

> On 2012-03-05 17:22:27, Arvind Prabhakar wrote:
> > Thanks for the patch Jarcec. I think it will be better to depend upon 0.92.0 release as opposed to snapshot. I understand that the 0.92.0 does not have it's test artifact deployed on the maven repository yet, but hopefully they will do that soon (I pinged them this morning).
> > 
> > Thanks
> 
> Jarek Cecho wrote:
>     Thank you very much for the ping Arvind. I got an impression that they are not planning to deploy testing jar for 0.92.0 version at all and that they will do that for 0.92.1. I'll be happy to change my patch and retest it once again after they publish it.
>     
>     Jarcec

I raised this as a request on the hbase-dev list [1]. Hopefully they will respond soon - but if they decide not to, then we have no choice but to go with the 0.92.1-SNAPSHOT version as per your patch.

[1] http://markmail.org/message/6xmf2xvv6sf37mni


- Arvind


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4169/#review5612
-----------------------------------------------------------


On 2012-03-04 09:12:13, Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4169/
> -----------------------------------------------------------
> 
> (Updated 2012-03-04 09:12:13)
> 
> 
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
> 
> 
> Summary
> -------
> 
> I've changed dependency to 0.92.1-SNAPSHOT.
> 
> 
> This addresses bug SQOOP-454.
>     https://issues.apache.org/jira/browse/SQOOP-454
> 
> 
> Diffs
> -----
> 
>   /build.xml 1296766 
> 
> Diff: https://reviews.apache.org/r/4169/diff
> 
> 
> Testing
> -------
> 
> ant -Dhadoopversion={100,23} test
> 
> 
> Thanks,
> 
> Jarek
> 
>


Re: Review Request: SQOOP-454: Upgrade dependency on HBase version 0.92.0-SNAPSHOT as it was already released

Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4169/#review5612
-----------------------------------------------------------


Thanks for the patch Jarcec. I think it will be better to depend upon 0.92.0 release as opposed to snapshot. I understand that the 0.92.0 does not have it's test artifact deployed on the maven repository yet, but hopefully they will do that soon (I pinged them this morning).

Thanks

- Arvind


On 2012-03-04 09:12:13, Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4169/
> -----------------------------------------------------------
> 
> (Updated 2012-03-04 09:12:13)
> 
> 
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
> 
> 
> Summary
> -------
> 
> I've changed dependency to 0.92.1-SNAPSHOT.
> 
> 
> This addresses bug SQOOP-454.
>     https://issues.apache.org/jira/browse/SQOOP-454
> 
> 
> Diffs
> -----
> 
>   /build.xml 1296766 
> 
> Diff: https://reviews.apache.org/r/4169/diff
> 
> 
> Testing
> -------
> 
> ant -Dhadoopversion={100,23} test
> 
> 
> Thanks,
> 
> Jarek
> 
>


Re: Review Request: SQOOP-454: Upgrade dependency on HBase version 0.92.0-SNAPSHOT as it was already released

Posted by Jarek Cecho <ja...@apache.org>.

> On 2012-03-06 22:00:13, Arvind Prabhakar wrote:
> > +1. Please attach the patch to the Jira.

Thank you very much sir for the review and ping to HBase team for getting test jar deployed in maven repository.

Jarcec


- Jarek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4169/#review5659
-----------------------------------------------------------


On 2012-03-06 21:53:47, Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4169/
> -----------------------------------------------------------
> 
> (Updated 2012-03-06 21:53:47)
> 
> 
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
> 
> 
> Summary
> -------
> 
> I've changed dependency to 0.92.1-SNAPSHOT.
> 
> 
> This addresses bug SQOOP-454.
>     https://issues.apache.org/jira/browse/SQOOP-454
> 
> 
> Diffs
> -----
> 
>   /build.xml 1296766 
> 
> Diff: https://reviews.apache.org/r/4169/diff
> 
> 
> Testing
> -------
> 
> ant -Dhadoopversion={100,23} test
> 
> 
> Thanks,
> 
> Jarek
> 
>


Re: Review Request: SQOOP-454: Upgrade dependency on HBase version 0.92.0-SNAPSHOT as it was already released

Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4169/#review5659
-----------------------------------------------------------

Ship it!


+1. Please attach the patch to the Jira.

- Arvind


On 2012-03-06 21:53:47, Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4169/
> -----------------------------------------------------------
> 
> (Updated 2012-03-06 21:53:47)
> 
> 
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
> 
> 
> Summary
> -------
> 
> I've changed dependency to 0.92.1-SNAPSHOT.
> 
> 
> This addresses bug SQOOP-454.
>     https://issues.apache.org/jira/browse/SQOOP-454
> 
> 
> Diffs
> -----
> 
>   /build.xml 1296766 
> 
> Diff: https://reviews.apache.org/r/4169/diff
> 
> 
> Testing
> -------
> 
> ant -Dhadoopversion={100,23} test
> 
> 
> Thanks,
> 
> Jarek
> 
>


Re: Review Request: SQOOP-454: Upgrade dependency on HBase version 0.92.0-SNAPSHOT as it was already released

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4169/
-----------------------------------------------------------

(Updated 2012-03-06 21:53:47.347412)


Review request for Sqoop, Arvind Prabhakar and Bilung Lee.


Changes
-------

I've changed the version to 0.92.0 and run tests. It seems to be working.


Summary
-------

I've changed dependency to 0.92.1-SNAPSHOT.


This addresses bug SQOOP-454.
    https://issues.apache.org/jira/browse/SQOOP-454


Diffs (updated)
-----

  /build.xml 1296766 

Diff: https://reviews.apache.org/r/4169/diff


Testing
-------

ant -Dhadoopversion={100,23} test


Thanks,

Jarek