You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/10/15 15:08:15 UTC
[kudu-CR](branch-1.11.x) [docs] Add Flume integration deprecation
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14454
Change subject: [docs] Add Flume integration deprecation
......................................................................
[docs] Add Flume integration deprecation
Adds a note about the Flume integration deprecation to the release notes.
Change-Id: I0d4be25843a7657ba1314939394330053b2287a1
---
M docs/release_notes.adoc
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/14454/1
--
To view, visit http://gerrit.cloudera.org:8080/14454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d4be25843a7657ba1314939394330053b2287a1
Gerrit-Change-Number: 14454
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR](branch-1.11.x) [docs] Add Flume integration deprecation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14454 )
Change subject: [docs] Add Flume integration deprecation
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14454/1/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/14454/1/docs/release_notes.adoc@45
PS1, Line 45: * The Kudu Flume integration is deprecated and may be removed in the
: next minor release. The integration will be moved to the Apache Flume
: project going forward
> This is giving users a heads up that the change is coming more than anythin
OK, thank you for the clarification.
SGTM.
--
To view, visit http://gerrit.cloudera.org:8080/14454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d4be25843a7657ba1314939394330053b2287a1
Gerrit-Change-Number: 14454
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Oct 2019 18:40:50 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.11.x) [docs] Add Flume integration deprecation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14454 )
Change subject: [docs] Add Flume integration deprecation
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14454/1/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/14454/1/docs/release_notes.adoc@45
PS1, Line 45: * The Kudu Flume integration is deprecated and may be removed in the
: next minor release. The integration will be moved to the Apache Flume
: project going forward
I'm not sure I understand the big picture here. FLUME-3345 is not resolved yet, which means the patch hasn't landed into Apache Flume repo, right? Then why to declare obsolescence now? I thought we could declare the Kudu Flume obsolete once the Flume repo starts hosting the package, no?
--
To view, visit http://gerrit.cloudera.org:8080/14454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d4be25843a7657ba1314939394330053b2287a1
Gerrit-Change-Number: 14454
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Oct 2019 16:44:54 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.11.x) [docs] Add Flume integration deprecation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14454 )
Change subject: [docs] Add Flume integration deprecation
......................................................................
[docs] Add Flume integration deprecation
Adds a note about the Flume integration deprecation to the release notes.
Change-Id: I0d4be25843a7657ba1314939394330053b2287a1
Reviewed-on: http://gerrit.cloudera.org:8080/14454
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M docs/release_notes.adoc
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d4be25843a7657ba1314939394330053b2287a1
Gerrit-Change-Number: 14454
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.11.x) [docs] Add Flume integration deprecation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14454 )
Change subject: [docs] Add Flume integration deprecation
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d4be25843a7657ba1314939394330053b2287a1
Gerrit-Change-Number: 14454
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Oct 2019 18:40:51 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.11.x) [docs] Add Flume integration deprecation
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14454 )
Change subject: [docs] Add Flume integration deprecation
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14454/1/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/14454/1/docs/release_notes.adoc@45
PS1, Line 45: * The Kudu Flume integration is deprecated and may be removed in the
: next minor release. The integration will be moved to the Apache Flume
: project going forward
> I'm not sure I understand the big picture here. FLUME-3345 is not resolved
This is giving users a heads up that the change is coming more than anything. We have handled similar changes such as bumping the minimum Java version similarly.
--
To view, visit http://gerrit.cloudera.org:8080/14454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d4be25843a7657ba1314939394330053b2287a1
Gerrit-Change-Number: 14454
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Oct 2019 17:22:53 +0000
Gerrit-HasComments: Yes