You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/07/27 04:34:10 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6717: arch: Call board_reset before up_irq_save and spin_trylock
xiaoxiang781216 opened a new pull request, #6717:
URL: https://github.com/apache/incubator-nuttx/pull/6717
## Summary
since board_reset may call some kernel functions which try to acquire the lock again
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6717: arch: Call board_reset before up_irq_save and spin_trylock
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6717:
URL: https://github.com/apache/incubator-nuttx/pull/6717#issuecomment-1197645511
> @xiaoxiang781216 - if board reset call sys reset how does this work?
It should work as before if the implementation is just simply write some registers. The change is only affected the more complex implementation such as need IPC to other core to request the reset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 merged pull request #6717: arch: Call board_reset before up_irq_save and spin_trylock
Posted by GitBox <gi...@apache.org>.
davids5 merged PR #6717:
URL: https://github.com/apache/incubator-nuttx/pull/6717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6717: arch: Call board_reset before up_irq_save and spin_trylock
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6717:
URL: https://github.com/apache/incubator-nuttx/pull/6717#issuecomment-1198049014
> ```
> 1.3.428 CONFIG_BOARD_RESET_ON_ASSERT: Enable Board Reset after assert
> Type: Integer
> Default: 0
> Dependencies: [CONFIG_LIB_BOARDCTL](https://cwiki.apache.org/confluence/display/NUTTX/Configuration+Variables#CONFIG_LIB_BOARDCTL), [CONFIG_BOARDCTL_RESET](https://cwiki.apache.org/confluence/display/NUTTX/Configuration+Variables#CONFIG_BOARDCTL_RESET)
> Kconfig file: ./boards/Kconfig
> == 0 up_assert never reset the machine >= 1 up_assert from interrupt handler or IDLE thread will reset the
>
> machine
> >= 2 up_assert from user or kernel thread will reset the machine.
> The default behavior is just to kill the asserting thread.
> ```
>
> What happens [here](https://github.com/apache/incubator-nuttx/pull/6717/files#diff-82074957e68b246b0d7fbfb7c73caa7d8d8af2239dbee25e99f80f5fb5bd2e58R470) line for CONFIG_BOARD_RESET_ON_ASSERT
>
> Wouldn't the CPU reset before it tries the lock?
Yes, this is what this patch want, I already high light in the commit message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #6717: arch: Call board_reset before up_irq_save and spin_trylock
Posted by GitBox <gi...@apache.org>.
davids5 commented on PR #6717:
URL: https://github.com/apache/incubator-nuttx/pull/6717#issuecomment-1197938672
```
1.3.428 CONFIG_BOARD_RESET_ON_ASSERT: Enable Board Reset after assert
Type: Integer
Default: 0
Dependencies: [CONFIG_LIB_BOARDCTL](https://cwiki.apache.org/confluence/display/NUTTX/Configuration+Variables#CONFIG_LIB_BOARDCTL), [CONFIG_BOARDCTL_RESET](https://cwiki.apache.org/confluence/display/NUTTX/Configuration+Variables#CONFIG_BOARDCTL_RESET)
Kconfig file: ./boards/Kconfig
== 0 up_assert never reset the machine >= 1 up_assert from interrupt handler or IDLE thread will reset the
machine
>= 2 up_assert from user or kernel thread will reset the machine.
The default behavior is just to kill the asserting thread.
```
What happens [here](https://github.com/apache/incubator-nuttx/pull/6717/files#diff-82074957e68b246b0d7fbfb7c73caa7d8d8af2239dbee25e99f80f5fb5bd2e58R470) line for CONFIG_BOARD_RESET_ON_ASSERT
Wouldn't the CPU reset before it tries the lock?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #6717: arch: Call board_reset before up_irq_save and spin_trylock
Posted by GitBox <gi...@apache.org>.
davids5 commented on PR #6717:
URL: https://github.com/apache/incubator-nuttx/pull/6717#issuecomment-1198065207
OK I was confused by the commit message vs what the Title and Summary says.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #6717: arch: Call board_reset before up_irq_save and spin_trylock
Posted by GitBox <gi...@apache.org>.
davids5 commented on PR #6717:
URL: https://github.com/apache/incubator-nuttx/pull/6717#issuecomment-1197300748
@xiaoxiang781216 - if board reset call sys reset how does this work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org