[GitHub] [pinot] KKcorps commented on a diff in pull request #9413: Add a new API to fix segment date time in metadata

[GitBox <gi...@apache.org>]

KKcorps commented on code in PR #9413:
URL: https://github.com/apache/pinot/pull/9413#discussion_r981965111


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/ZKMetadataUtils.java:
##########
@@ -69,6 +100,13 @@ private static void updateSegmentZKMetadata(String tableNameWithType, SegmentZKM
       segmentZKMetadata.setStartTime(segmentMetadata.getStartTime());
       segmentZKMetadata.setEndTime(segmentMetadata.getEndTime());
       segmentZKMetadata.setTimeUnit(segmentMetadata.getTimeUnit());

Review Comment:
   Makes sense. Closing the PR #9472. I haven't removed the logic to convert timestamp using timeUnit since I am not sure about backward compatibility



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org