You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by kant2002 <gi...@git.apache.org> on 2014/10/24 11:34:56 UTC
[GitHub] cordova-lib pull request: CB-7863 Fixed broken test run on Windows...
GitHub user kant2002 opened a pull request:
https://github.com/apache/cordova-lib/pull/112
CB-7863 Fixed broken test run on Windows 8.1
Replace shelljs.rm with calls to fs-extra.removeSync
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kant2002/cordova-lib CB-7863
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/112.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #112
----
commit 00a8a6f5cd96e888c03f3b1ba9c4f17ea43c2938
Author: Andrey Kurdyumov <ka...@gmail.com>
Date: 2014-10-24T09:29:43Z
Fixed broken test run on Windows 8.1
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7863 Fixed broken test run on Windows...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/112#issuecomment-61009185
Unfortunately, it looks like appveyor is reporting that tests are failing ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7863 Fixed broken test run on Windows...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7863 Fixed broken test run on Windows...
Posted by kant2002 <gi...@git.apache.org>.
Github user kant2002 commented on the pull request:
https://github.com/apache/cordova-lib/pull/112#issuecomment-61050070
just want to clarify - without that patch, running `npm test` crashed and report error. With that fix I have `npm test` running and it is produced similar results as AppVeyor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7863 Fixed broken test run on Windows...
Posted by kant2002 <gi...@git.apache.org>.
Github user kant2002 commented on the pull request:
https://github.com/apache/cordova-lib/pull/112#issuecomment-61049460
I think that AppVeyor broken tests related to the
https://issues.apache.org/jira/browse/CB-7722.
Initially I think that issue related to https://issues.apache.org/jira/browse/CB-7721, but looks like we have two separate issue here.
1. shelljs bug (?) which prevent me from even running test suite.
2. Issue with tests on Windows 8.1 x64 where tests reported as failed.
For item 2 I probably have to create separate issue in JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org