You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/06/16 04:51:35 UTC

[GitHub] [incubator-shenyu] qixiaobo opened a new issue, #3567: [BUG] Curator need upgrade to new version to avoid endless 'ConnectionState.LOST' log

qixiaobo opened a new issue, #3567:
URL: https://github.com/apache/incubator-shenyu/issues/3567

   ### Is there an existing issue for this?
   
   - [X] I have searched the existing issues
   
   ### Current Behavior
   
   You may refer to this https://issues.apache.org/jira/browse/CURATOR-405
   
   > It's unclear how it got into this state, but a client started endlessly logging "Session timeout has elapsed while SUSPENDED". Curator 3.0 is supposed to go to LOST and inject a session expiration but it's not working in this case.
   For our case , shenyu prints lots of log like this 
   ![image](https://user-images.githubusercontent.com/2881751/173993277-7f099263-07cf-46c9-a743-0b1fd238e1a8.png)
   And this cause filebeat using lots of cpu
   ![image](https://user-images.githubusercontent.com/2881751/173993398-7f6e9609-387f-46b3-be9b-9fad4f0073f4.png)
   
   Indeed we should to upgrade Curator to a new version above 4.1.0
   https://github.com/apache/incubator-shenyu/search?l=Maven+POM&q=curator.version
   
   ![Uploading image.png…]()
   
   
   
   
   
   ### Expected Behavior
   
   Never print these endless logs
   
   ### Steps To Reproduce
   
   _No response_
   
   ### Environment
   
   ```markdown
   ShenYu version(s):2.4.0
   ```
   
   
   ### Debug logs
   
   2022-06-15 21:01:23,830 [WARN] [Curator-ConnectionStateManager-0] o.a.c.f.s.ConnectionStateManager:307 Session timeout has elapsed while SUSPENDED. Injecting a session expiration. Elapsed ms: 2851944. Adjusted session timeout ms: 40000
   
   ### Anything else?
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-shenyu] qixiaobo commented on issue #3567: [BUG] Curator need upgrade to new version to avoid endless 'ConnectionState.LOST' log

Posted by GitBox <gi...@apache.org>.
qixiaobo commented on issue #3567:
URL: https://github.com/apache/incubator-shenyu/issues/3567#issuecomment-1157236032

   > Curator 5.0 Breaking Changes
   > Curator 5.0 contains a few non-backward compatible/breaking changes from previous versions.
   > 
   > ZooKeeper 3.4.x is no longer supported (the associated Compatibility classes/methods have been removed). If you still need to use Curator with ZooKeeper 3.4.x you will need to use a previous version. [Click here for details](https://curator.apache.org/zk-compatibility-34.html).
   > The old ListenerContainer classes have been removed so as not to leak Guava classes into Curator APIs. Instead use the new StandardListenerManager.
   > Exhibitor support has been removed.
   > ConnectionHandlingPolicy and related classes have been removed.
   > The Reaper and ChildReaper classes/recipes have been removed. You should use ZooKeeper container nodes instead.
   > newPersistentEphemeralNode() and newPathChildrenCache() were removed from GroupMember.
   > ServiceCacheBuilder<T> executorService(CloseableExecutorService executorService) was removed from ServiceCacheBuilder.
   > ServiceProviderBuilder<T> executorService(CloseableExecutorService executorService) was removed from ServiceProviderBuilder.
   > static boolean shouldRetry(int rc) was removed from RetryLoop.
   > static boolean isRetryException(Throwable exception) was removed from RetryLoop
   
   https://curator.apache.org/breaking-changes.html
   So maybe we should upgrade to 4.3.0
   https://mvnrepository.com/artifact/org.apache.curator/curator-client/4.3.0
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-shenyu] hgaol commented on issue #3567: [BUG] Curator need upgrade to new version to avoid endless 'ConnectionState.LOST' log

Posted by GitBox <gi...@apache.org>.
hgaol commented on issue #3567:
URL: https://github.com/apache/incubator-shenyu/issues/3567#issuecomment-1159439195

   Hi @qixiaobo , the curator version has been updated to 4.3.0, you can pull the newest master branch and try again. You can refer to this PR #3569 . If still any issue, welcome to investigate and contribute~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shenyu] yu199195 closed issue #3567: [BUG] Curator need upgrade to new version to avoid endless 'ConnectionState.LOST' log

Posted by "yu199195 (via GitHub)" <gi...@apache.org>.
yu199195 closed issue #3567: [BUG] Curator need upgrade to new version to avoid endless 'ConnectionState.LOST' log
URL: https://github.com/apache/shenyu/issues/3567


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-shenyu] hgaol commented on issue #3567: [BUG] Curator need upgrade to new version to avoid endless 'ConnectionState.LOST' log

Posted by GitBox <gi...@apache.org>.
hgaol commented on issue #3567:
URL: https://github.com/apache/incubator-shenyu/issues/3567#issuecomment-1157263008

   Hi @qixiaobo , thanks for your advice! we're considering curator version 4.3. We'll do more testing for examples like sofa/dubbo/motan to make sure it works well with them. For now, I've tested it works well with sofa example. More details can refer to this issue #3556 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-shenyu] qixiaobo commented on issue #3567: [BUG] Curator need upgrade to new version to avoid endless 'ConnectionState.LOST' log

Posted by GitBox <gi...@apache.org>.
qixiaobo commented on issue #3567:
URL: https://github.com/apache/incubator-shenyu/issues/3567#issuecomment-1158575330

   > I also met this before, that's may caused by the net issue. If you want to avoid the endless log, you may can also set log level for specific package or class or change the connection/session timeout. Anyway, upgrade to version 4.3 is a good topic, thank you!
   So glad to hear this.
   Since this is not the common case, I just want to follow your step to upgrade curator version.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-shenyu] qixiaobo commented on issue #3567: [BUG] Curator need upgrade to new version to avoid endless 'ConnectionState.LOST' log

Posted by GitBox <gi...@apache.org>.
qixiaobo commented on issue #3567:
URL: https://github.com/apache/incubator-shenyu/issues/3567#issuecomment-1159477688

   > Hi @qixiaobo , the curator version has been updated to 4.3.0, you can pull the newest master branch and try again. You can refer to this PR #3569 . If still any issue, welcome to investigate and contribute~
   
   Thanks for remind, I will try but may not reproduce because it is such a rare case


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-shenyu] hgaol commented on issue #3567: [BUG] Curator need upgrade to new version to avoid endless 'ConnectionState.LOST' log

Posted by GitBox <gi...@apache.org>.
hgaol commented on issue #3567:
URL: https://github.com/apache/incubator-shenyu/issues/3567#issuecomment-1157356626

   I also met this before, that's may caused by the net issue. If you want to avoid the endless log, you may can also set log level for specific package or class. Anyway, upgrade to version 4.3 is a good topic, thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org