[jira] [Commented] (FLINK-6665) Pass a ScheduledExecutorService to the RestartStrategy

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071328#comment-16071328 ] 

ASF GitHub Bot commented on FLINK-6665:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4220#discussion_r125165228
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/ExecutionGraphRestarter.java ---
    @@ -23,9 +23,15 @@
     import org.slf4j.LoggerFactory;
     
     import java.util.concurrent.Callable;
    +import java.util.concurrent.ScheduledExecutorService;
    +import java.util.concurrent.ScheduledFuture;
    +import java.util.concurrent.TimeUnit;
     
     class ExecutionGraphRestarter {
     	private static final Logger LOG = LoggerFactory.getLogger(ExecutionGraphRestarter.class);
    +
    +	/** @deprecated Using {@link #scheduleRestartWithDelay(ExecutionGraph, long, ScheduledExecutorService)} instead. */
    +	@Deprecated
    --- End diff --
    
    Can we remove this method?


> Pass a ScheduledExecutorService to the RestartStrategy
> ------------------------------------------------------
>
>                 Key: FLINK-6665
>                 URL: https://issues.apache.org/jira/browse/FLINK-6665
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: Stephan Ewen
>            Assignee: Fang Yong
>             Fix For: 1.4.0
>
>
> Currently, the {{RestartStrategy}} is called when the {{ExecutionGraph}} should be restarted.
> To facilitate delays before restarting, the strategy simply sleeps, blocking the thread that runs the ExecutionGraph's recovery method.
> I suggest to pass {{ScheduledExecutorService}}) to the {{RestartStrategy}} and let it schedule the restart call that way, avoiding any sleeps.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)