You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/16 00:50:06 UTC

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1798: mmcsd: Allow setting ID Mode SPI frequency vi Kconfig

btashton commented on a change in pull request #1798:
URL: https://github.com/apache/incubator-nuttx/pull/1798#discussion_r489097150



##########
File path: drivers/mmcsd/mmcsd_spi.c
##########
@@ -61,7 +61,9 @@
 #  define CONFIG_MMCSD_NSLOTS 1
 #endif
 
-#define MMCSD_IDMODE_CLOCK           (400000)
+#ifndef CONFIG_MMCSD_IDMODE_CLOCK
+#  define CONFIG_MMCSD_IDMODE_CLOCK 400000
+#endif

Review comment:
       This is a pattern I see in a lot of places, for example right above with `CONFIG_MMCSD_NSLOTS` so I keeping it.  Should I remove that as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org