You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "ThePassionate (via GitHub)" <gi...@apache.org> on 2023/08/25 02:24:00 UTC
[GitHub] [nuttx-apps] ThePassionate opened a new pull request, #1995: mbedtls: mbedtls_selftest depends on MBEDTLS_SSL_DTLS_CONNECTION_ID_COMPAT
ThePassionate opened a new pull request, #1995:
URL: https://github.com/apache/nuttx-apps/pull/1995
when enable MBEDTLS_SLEFTEST it will import parts related to ssl and need to define MBEDTLS_SSL_DTLS_CONNECTION_ID_COMPAT
Signed-off-by: makejian <ma...@xiaomi.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] ThePassionate commented on a diff in pull request #1995: mbedtls: mbedtls_selftest depends on MBEDTLS_SSL_DTLS_CONNECTION_ID_COMPAT
Posted by "ThePassionate (via GitHub)" <gi...@apache.org>.
ThePassionate commented on code in PR #1995:
URL: https://github.com/apache/nuttx-apps/pull/1995#discussion_r1305379490
##########
crypto/mbedtls/Kconfig:
##########
@@ -109,6 +109,15 @@ config MBEDTLS_SSL_DTLS_BADMAC_LIMIT
bool "Enable support for a limit of records with bad MAC."
default n
+config MBEDTLS_SSL_DTLS_CONNECTION_ID
+ bool "Enable the Connection ID extension."
+ default n
+
+config MBEDTLS_SSL_DTLS_CONNECTION_ID_COMPAT
Review Comment:
#ifdef CONFIG_MBEDTLS_SSL_DTLS_CONNECTION_ID
#define MBEDTLS_SSL_DTLS_CONNECTION_ID
#endif
#ifdef CONFIG_MBEDTLS_SSL_DTLS_CONNECTION_ID_COMPAT
#define MBEDTLS_SSL_DTLS_CONNECTION_ID_COMPAT 0
#endif
These two have already be controlled by kconfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1995: mbedtls: mbedtls_selftest depends on MBEDTLS_SSL_DTLS_CONNECTION_ID_COMPAT
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #1995:
URL: https://github.com/apache/nuttx-apps/pull/1995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] ThePassionate commented on a diff in pull request #1995: mbedtls: mbedtls_selftest depends on MBEDTLS_SSL_DTLS_CONNECTION_ID_COMPAT
Posted by "ThePassionate (via GitHub)" <gi...@apache.org>.
ThePassionate commented on code in PR #1995:
URL: https://github.com/apache/nuttx-apps/pull/1995#discussion_r1305379490
##########
crypto/mbedtls/Kconfig:
##########
@@ -109,6 +109,15 @@ config MBEDTLS_SSL_DTLS_BADMAC_LIMIT
bool "Enable support for a limit of records with bad MAC."
default n
+config MBEDTLS_SSL_DTLS_CONNECTION_ID
+ bool "Enable the Connection ID extension."
+ default n
+
+config MBEDTLS_SSL_DTLS_CONNECTION_ID_COMPAT
Review Comment:
#ifdef CONFIG_MBEDTLS_SSL_DTLS_CONNECTION_ID
#define MBEDTLS_SSL_DTLS_CONNECTION_ID
#endif
#ifdef CONFIG_MBEDTLS_SSL_DTLS_CONNECTION_ID_COMPAT
#define MBEDTLS_SSL_DTLS_CONNECTION_ID_COMPAT 0
#endif
These two have already be controlled by kconfig in mbedtls_config.h
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1995: mbedtls: mbedtls_selftest depends on MBEDTLS_SSL_DTLS_CONNECTION_ID_COMPAT
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1995:
URL: https://github.com/apache/nuttx-apps/pull/1995#discussion_r1305128379
##########
crypto/mbedtls/Kconfig:
##########
@@ -109,6 +109,15 @@ config MBEDTLS_SSL_DTLS_BADMAC_LIMIT
bool "Enable support for a limit of records with bad MAC."
default n
+config MBEDTLS_SSL_DTLS_CONNECTION_ID
+ bool "Enable the Connection ID extension."
+ default n
+
+config MBEDTLS_SSL_DTLS_CONNECTION_ID_COMPAT
Review Comment:
do you need change mbedtls_config.h
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org