You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2018/12/25 02:14:30 UTC

[GitHub] cowwoc commented on a change in pull request #15: Don't fail if module source path already exists.

cowwoc commented on a change in pull request #15: Don't fail if module source path already exists.
URL: https://github.com/apache/maven-javadoc-plugin/pull/15#discussion_r243866894
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
 ##########
 @@ -4754,11 +4754,11 @@ private void addJavadocOptions( File javadocOutputDirectory,
                             addArgIfNotEmpty( arguments, "--patch-module", moduleName + '='
                                 + JavadocUtil.quotedPathArgument( getSourcePath( projectSourcepaths.getValue() ) ) );
                             
-                            Files.createDirectory( moduleSourceDir.resolve( moduleName ) );
+                            Files.createDirectories( moduleSourceDir.resolve( moduleName ) );
 
 Review comment:
   Done. I've reworked the fix in terms of `if !Files.isDirectory...createDirectory`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services