You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Prasad Chakka (JIRA)" <ji...@apache.org> on 2008/09/05 23:28:44 UTC

[jira] Created: (HADOOP-4092) Add Hive source directories to hadoop's eclipse project .classpath files

Add Hive source directories to hadoop's eclipse project .classpath files
------------------------------------------------------------------------

                 Key: HADOOP-4092
                 URL: https://issues.apache.org/jira/browse/HADOOP-4092
             Project: Hadoop Core
          Issue Type: Improvement
          Components: contrib/hive
    Affects Versions: 0.19.0
            Reporter: Prasad Chakka
            Assignee: Prasad Chakka
            Priority: Minor
             Fix For: 0.19.0


bring in hive source directories and dependent libs into Hadoop's eclipse project

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4092) Add Hive source directories to hadoop's eclipse project .classpath files

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631386#action_12631386 ] 

Hudson commented on HADOOP-4092:
--------------------------------

Integrated in Hadoop-trunk #605 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/605/])

> Add Hive source directories to hadoop's eclipse project .classpath files
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4092
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4092
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/hive
>    Affects Versions: 0.19.0
>            Reporter: Prasad Chakka
>            Assignee: Prasad Chakka
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: hadoop-4092-1.patch, hadoop-4092-2.patch
>
>
> bring in hive source directories and dependent libs into Hadoop's eclipse project

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4092) Add Hive source directories to hadoop's eclipse project .classpath files

Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Prasad Chakka updated HADOOP-4092:
----------------------------------

    Attachment: hadoop-4092-2.patch

added generated test code path as well

> Add Hive source directories to hadoop's eclipse project .classpath files
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4092
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4092
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/hive
>    Affects Versions: 0.19.0
>            Reporter: Prasad Chakka
>            Assignee: Prasad Chakka
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: hadoop-4092-1.patch, hadoop-4092-2.patch
>
>
> bring in hive source directories and dependent libs into Hadoop's eclipse project

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4092) Add Hive source directories to hadoop's eclipse project .classpath files

Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631110#action_12631110 ] 

Nigel Daley commented on HADOOP-4092:
-------------------------------------

FYI, until this patch is reverted, all patches will get a -1 in the contrib component.



> Add Hive source directories to hadoop's eclipse project .classpath files
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4092
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4092
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/hive
>    Affects Versions: 0.19.0
>            Reporter: Prasad Chakka
>            Assignee: Prasad Chakka
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: hadoop-4092-1.patch, hadoop-4092-2.patch
>
>
> bring in hive source directories and dependent libs into Hadoop's eclipse project

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4092) Add Hive source directories to hadoop's eclipse project .classpath files

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-4092:
--------------------------------

    Fix Version/s:     (was: 0.19.0)

Please mark it as a blocker for 0.19 if required

> Add Hive source directories to hadoop's eclipse project .classpath files
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4092
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4092
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/hive
>    Affects Versions: 0.19.0
>            Reporter: Prasad Chakka
>            Assignee: Prasad Chakka
>            Priority: Minor
>         Attachments: hadoop-4092-1.patch, hadoop-4092-2.patch
>
>
> bring in hive source directories and dependent libs into Hadoop's eclipse project

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4092) Add Hive source directories to hadoop's eclipse project .classpath files

Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631106#action_12631106 ] 

Nigel Daley commented on HADOOP-4092:
-------------------------------------

Dhruba, as you can see, contrib got a -1.  If you look at the console it's because the eclipse jars in the eclipse classpath are different from what test-patch.sh see's in the lib directory.

Please revert this.  The patch should also include a fix to test-patch.sh.

> Add Hive source directories to hadoop's eclipse project .classpath files
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4092
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4092
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/hive
>    Affects Versions: 0.19.0
>            Reporter: Prasad Chakka
>            Assignee: Prasad Chakka
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: hadoop-4092-1.patch, hadoop-4092-2.patch
>
>
> bring in hive source directories and dependent libs into Hadoop's eclipse project

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4092) Add Hive source directories to hadoop's eclipse project .classpath files

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630549#action_12630549 ] 

Hadoop QA commented on HADOOP-4092:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12389767/hadoop-4092-2.patch
  against trunk revision 694562.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 7 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3258/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3258/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3258/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3258/console

This message is automatically generated.

> Add Hive source directories to hadoop's eclipse project .classpath files
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4092
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4092
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/hive
>    Affects Versions: 0.19.0
>            Reporter: Prasad Chakka
>            Assignee: Prasad Chakka
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: hadoop-4092-1.patch, hadoop-4092-2.patch
>
>
> bring in hive source directories and dependent libs into Hadoop's eclipse project

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4092) Add Hive source directories to hadoop's eclipse project .classpath files

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631111#action_12631111 ] 

dhruba borthakur commented on HADOOP-4092:
------------------------------------------

Oops, I looked at the test results and saw that all tests were passing. Did not look at the console output. 

> Add Hive source directories to hadoop's eclipse project .classpath files
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4092
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4092
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/hive
>    Affects Versions: 0.19.0
>            Reporter: Prasad Chakka
>            Assignee: Prasad Chakka
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: hadoop-4092-1.patch, hadoop-4092-2.patch
>
>
> bring in hive source directories and dependent libs into Hadoop's eclipse project

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4092) Add Hive source directories to hadoop's eclipse project .classpath files

Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Prasad Chakka updated HADOOP-4092:
----------------------------------

    Attachment: hadoop-4092-1.patch

> Add Hive source directories to hadoop's eclipse project .classpath files
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4092
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4092
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/hive
>    Affects Versions: 0.19.0
>            Reporter: Prasad Chakka
>            Assignee: Prasad Chakka
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: hadoop-4092-1.patch
>
>
> bring in hive source directories and dependent libs into Hadoop's eclipse project

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4092) Add Hive source directories to hadoop's eclipse project .classpath files

Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Prasad Chakka updated HADOOP-4092:
----------------------------------

    Hadoop Flags: [Reviewed]
          Status: Patch Available  (was: Open)

since this is eclipse template file, there isn't any needed for tests

> Add Hive source directories to hadoop's eclipse project .classpath files
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4092
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4092
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/hive
>    Affects Versions: 0.19.0
>            Reporter: Prasad Chakka
>            Assignee: Prasad Chakka
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: hadoop-4092-1.patch, hadoop-4092-2.patch
>
>
> bring in hive source directories and dependent libs into Hadoop's eclipse project

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4092) Add Hive source directories to hadoop's eclipse project .classpath files

Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629853#action_12629853 ] 

Ashish Thusoo commented on HADOOP-4092:
---------------------------------------

+1
Looks good.


How do we add the test setup?

> Add Hive source directories to hadoop's eclipse project .classpath files
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4092
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4092
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/hive
>    Affects Versions: 0.19.0
>            Reporter: Prasad Chakka
>            Assignee: Prasad Chakka
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: hadoop-4092-1.patch, hadoop-4092-2.patch
>
>
> bring in hive source directories and dependent libs into Hadoop's eclipse project

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4092) Add Hive source directories to hadoop's eclipse project .classpath files

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

dhruba borthakur updated HADOOP-4092:
-------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this. Thanks Prasad!

> Add Hive source directories to hadoop's eclipse project .classpath files
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4092
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4092
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/hive
>    Affects Versions: 0.19.0
>            Reporter: Prasad Chakka
>            Assignee: Prasad Chakka
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: hadoop-4092-1.patch, hadoop-4092-2.patch
>
>
> bring in hive source directories and dependent libs into Hadoop's eclipse project

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (HADOOP-4092) Add Hive source directories to hadoop's eclipse project .classpath files

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

dhruba borthakur reopened HADOOP-4092:
--------------------------------------


Change reverted.

> Add Hive source directories to hadoop's eclipse project .classpath files
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4092
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4092
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/hive
>    Affects Versions: 0.19.0
>            Reporter: Prasad Chakka
>            Assignee: Prasad Chakka
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: hadoop-4092-1.patch, hadoop-4092-2.patch
>
>
> bring in hive source directories and dependent libs into Hadoop's eclipse project

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.