[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2150: IGNITE-19657 Remove schema from BinaryTuple implementation

["sashapolo (via GitHub)" <gi...@apache.org>]

sashapolo commented on code in PR #2150:
URL: https://github.com/apache/ignite-3/pull/2150#discussion_r1222493666


##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##########
@@ -75,17 +71,17 @@ public static BinaryTuplePrefix fromBinaryTuple(BinaryTuple tuple) {
 
         prefixBuffer.put(0, (byte) (flags | PREFIX_FLAG));
 
-        return new BinaryTuplePrefix(tuple.schema(), prefixBuffer);
+        return new BinaryTuplePrefix(tuple.elementCount(), prefixBuffer);
     }
 
     @Override
-    public int count() {
-        return elementCount();
+    public BigDecimal decimalValue(int col) {
+        throw new UnsupportedOperationException("Must never be called, use BinaryTupleSchema#decimalValue instead");
     }
 
     @Override
-    public BigDecimal decimalValue(int index) {
-        return decimalValue(index, schema.element(index).decimalScale);
+    public int count() {
+        return elementCount();

Review Comment:
   I don't know, since I didn't introduce this. Do you want me to remove one of them in this PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org