You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/06/10 17:24:45 UTC
[GitHub] [commons-graph] ameyjadiye opened a new pull request #1: upgrade basic things
ameyjadiye opened a new pull request #1:
URL: https://github.com/apache/commons-graph/pull/1
- Updated parent to the latest available version - 50
- Updated java compiler and source to 1.8
- Updated .gitignore
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-graph] ameyjadiye commented on pull request #1: Update Maven settings, gitignore, and add README
Posted by GitBox <gi...@apache.org>.
ameyjadiye commented on pull request #1:
URL: https://github.com/apache/commons-graph/pull/1#issuecomment-644278890
@kinow , now things look good to close this PR :smiley_cat:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-graph] ameyjadiye commented on pull request #1: Update Maven settings, gitignore, and add README
Posted by GitBox <gi...@apache.org>.
ameyjadiye commented on pull request #1:
URL: https://github.com/apache/commons-graph/pull/1#issuecomment-643646963
@kinow , fixed conflict. looks like these changes merged. what to do with this PR? maybe you can merge fixed conflict :upside_down_face:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-graph] ameyjadiye closed pull request #1: Update Maven settings, gitignore, and add README
Posted by GitBox <gi...@apache.org>.
ameyjadiye closed pull request #1:
URL: https://github.com/apache/commons-graph/pull/1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-graph] kinow commented on pull request #1: Update Maven settings, gitignore, and add README
Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #1:
URL: https://github.com/apache/commons-graph/pull/1#issuecomment-643693096
@ameyjadiye yup, looks like other files were merged. There's still one change here, which removes the `*~` from gitignore. Is that important @ameyjadiye ? If not we can simply close this one as the other commits were already merged, WDYT?
ps: I keep my gitignore settings in `~/.gitignore`, so I don't need to worry about IDE specific files; that's useful for me as each component has a slightly different .gitignore, as well as $work, and other OSS projects
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org