You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/29 15:51:07 UTC

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #1147: stm32h7:stm32_spi Restores internal DMA buffer broken in 574b25 and improvements.

davids5 commented on a change in pull request #1147:
URL: https://github.com/apache/incubator-nuttx/pull/1147#discussion_r432577028



##########
File path: arch/arm/src/stm32h7/stm32_spi.c
##########
@@ -2019,31 +2053,18 @@ static void spi_exchange(FAR struct spi_dev_s *dev, FAR const void *txbuffer,
 
       /* Setup the DMA */
 
-      if (priv->config != SIMPLEX_RX)

Review comment:
       Due to the vanity name change of `up_` to `arm_` on weak symbols. I had no DMA completion interrupts. FUN!  While testing with the DMA interrupts not enabled.  I saw that the the TX DMA is actually completed prior to the `spi_modifyreg(priv, STM32_SPI_CR1_OFFSET, 0, SPI_CR1_CSTART);`  This is because the FIFO can be filed, without the transfer on the SPI bus. I reordered them, in that testing and left them that way. 
   
   I did not think it would be an issue. Do you think it will be an issue? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org