You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "sunjincheng (JIRA)" <ji...@apache.org> on 2019/07/03 11:46:00 UTC
[jira] [Closed] (FLINK-13077) CatalogPartitionAPICompletenessTests
in pyflink failed because of lacking "getComment" method
[ https://issues.apache.org/jira/browse/FLINK-13077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
sunjincheng closed FLINK-13077.
-------------------------------
Resolution: Fixed
Fix Version/s: 1.9.0
Fixed in master: bd5ca420f752a16e9e81a4eda5cc4e23bfad1679
> CatalogPartitionAPICompletenessTests in pyflink failed because of lacking "getComment" method
> ---------------------------------------------------------------------------------------------
>
> Key: FLINK-13077
> URL: https://issues.apache.org/jira/browse/FLINK-13077
> Project: Flink
> Issue Type: Bug
> Components: API / Python, Tests
> Reporter: Wei Zhong
> Assignee: Wei Zhong
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.9.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The following exception will be thrown:
> {code:java}
> self = <pyflink.table.tests.test_catalog_completeness.CatalogPartitionAPICompletenessTests testMethod=test_completeness>
> def test_completeness(self):
> > self.check_methods()
> pyflink/testing/test_case_utils.py:210:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> cls = <class 'pyflink.table.tests.test_catalog_completeness.CatalogPartitionAPICompletenessTests'>
> @classmethod
> def check_methods(cls):
> java_primary_methods = {'getClass', 'notifyAll', 'equals', 'hashCode', 'toString',
> 'notify', 'wait'}
> java_methods = PythonAPICompletenessTestCase.get_java_class_methods(cls.java_class())
> python_methods = cls.get_python_class_methods(cls.python_class())
> missing_methods = java_methods - python_methods - cls.excluded_methods() \
> - java_primary_methods
> if len(missing_methods) > 0:
> raise Exception('Methods: %s in Java class %s have not been added in Python class %s.'
> > % (missing_methods, cls.java_class(), cls.python_class()))
> E Exception: Methods: set([u'getComment']) in Java class org.apache.flink.table.catalog.CatalogPartition have not been added in Python class <class 'pyflink.table.catalog.CatalogPartition'>.
> {code}
> After a quick investigation of this issue, it seem that it is introduced in the commit and PR as follows:
> - [https://github.com/apache/flink/commit/59ff00d71d298fa61a92efa4fecd46f3cefc50f6]
> - [https://github.com/apache/flink/pull/8926]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)