You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/27 07:16:51 UTC
[GitHub] [arrow-datafusion] yjshen opened a new issue, #2349: Move Accumulator trait to physical-expr
yjshen opened a new issue, #2349:
URL: https://github.com/apache/arrow-datafusion/issues/2349
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
`Accumulator` is the state of an aggregate function, and has nothing to do with a logical expression.
The current blocker is AggregateUDF which mixes both the function signature and the function implementation. AggregateUDF exists in `datafusion-expr` because of its signature parts.
**Describe the solution you'd like**
1. Move Accumulator into `datafusion-physical-expr`.
2. Split AggregateUDF into parts, one remains in `datafusion-expr` that represents AggregateUDF's signature, and the other in `datafusion-physical-expr` for its implementation.
**Describe alternatives you've considered**
Don't move.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Move Accumulator trait to physical-expr [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #2349:
URL: https://github.com/apache/arrow-datafusion/issues/2349#issuecomment-1902606251
I am not sure this makes sense anymore given the UDFs are defined in `datafusion_expr` now and they need Acumulators
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #2349: Move Accumulator trait to physical-expr
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #2349:
URL: https://github.com/apache/arrow-datafusion/issues/2349#issuecomment-1113579768
This makes sense to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org