You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "mhenc (via GitHub)" <gi...@apache.org> on 2023/09/01 10:20:27 UTC
[GitHub] [airflow] mhenc opened a new pull request, #34003: AIP-44 Fix serialization in Internal API
mhenc opened a new pull request, #34003:
URL: https://github.com/apache/airflow/pull/34003
There are 2 fixes covered with this PR:
- Pydantic 2 must dump model with "json" mode (as we dump it as JSON to send from/to Internal API). Currently it may throw exception like "datetime is not json-serializable"
- session can't be closed when serializing the object in Internal API - otherwise the lazy-loaded fields throws an exception.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #34003: AIP-44 Fix serialization issues in Internal API.
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #34003:
URL: https://github.com/apache/airflow/pull/34003#issuecomment-1702777275
Nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #34003: AIP-44 Fix serialization issues in Internal API.
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #34003:
URL: https://github.com/apache/airflow/pull/34003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org