[GitHub] [flink] zentol commented on pull request #22313: [FLINK-31660][connector-kafka] fix kafka connector pom so ITCases run in IDE

["zentol (via GitHub)" <gi...@apache.org>]

zentol commented on PR #22313:
URL: https://github.com/apache/flink/pull/22313#issuecomment-1491601098

   This also is arguably not really an IntelliJ issue, but more of how the planner dependencies are organized.
   
   The planner modules apply several relocations (to, for example, jayway) but don't actually bundle these dependencies and rely on flink-table-runtime to provide that. This ordinarily wouldn't be an issue in the IDE, because usually all relocations are ignored by the IDE since it works on the original .class files. This isn't the case here because table-planner-loader forces the relocated classes to be used since it always loads class from the jar.
   
   If the loader were to be more self-contained, e.g. by bundling jayway, then this maybe wouldn't be a problem either.
   
   But as was said in the ticket, post externalization this issue will disappear, so I see no reason to change anything at this time.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org