You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "abeizn (via GitHub)" <gi...@apache.org> on 2023/02/09 09:12:09 UTC
[GitHub] [incubator-devlake] abeizn opened a new pull request, #4369: feat: add sonarqube scope and fix some models
abeizn opened a new pull request, #4369:
URL: https://github.com/apache/incubator-devlake/pull/4369
### Summary
feat: add sonarqube scope and fix some models
### Does this close any open issues?
part of #2305
### Screenshots
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 merged pull request #4369: feat: add sonarqube scope and fix some models
Posted by "warren830 (via GitHub)" <gi...@apache.org>.
warren830 merged PR #4369:
URL: https://github.com/apache/incubator-devlake/pull/4369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #4369: feat: add sonarqube scope and fix some models
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn commented on code in PR #4369:
URL: https://github.com/apache/incubator-devlake/pull/4369#discussion_r1101220250
##########
backend/plugins/sonarqube/models/migrationscripts/archived/sonarqube_file_metrics.go:
##########
@@ -23,27 +23,27 @@ import (
type SonarqubeFileMetrics struct {
ConnectionId uint64 `gorm:"primaryKey"`
- FileMetricsKey string `json:"component_key" gorm:"primaryKey"`
- ProjectKey string `json:"project" gorm:"index"`
- BatchID string `json:"batch_id"`
- FileName string `json:"file_name"`
- FilePath string `json:"file_path"`
- FileLanguage string `json:"file_language"`
- CodeSmells int `json:"code_smells"`
- SqaleIndex string `json:"sqale_index"`
- SqaleRating string `json:"sqale_rating"`
+ FileMetricsKey string `json:"componentKey" gorm:"primaryKey"`
+ ProjectKey string `json:"projectKey" gorm:"index"`
+ BatchID string `json:"batchId"`
+ FileName string `json:"fileName"`
+ FilePath string `json:"filePath"`
+ FileLanguage string `json:"fileLanguage"`
+ CodeSmells int `json:"codeSmells"`
+ SqaleIndex string `json:"sqaleIndex"`
+ SqaleRating string `json:"sqaleRating"`
Review Comment:
deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #4369: feat: add sonarqube scope and fix some models
Posted by "warren830 (via GitHub)" <gi...@apache.org>.
warren830 commented on code in PR #4369:
URL: https://github.com/apache/incubator-devlake/pull/4369#discussion_r1101180370
##########
backend/plugins/sonarqube/models/migrationscripts/archived/sonarqube_file_metrics.go:
##########
@@ -23,27 +23,27 @@ import (
type SonarqubeFileMetrics struct {
ConnectionId uint64 `gorm:"primaryKey"`
- FileMetricsKey string `json:"component_key" gorm:"primaryKey"`
- ProjectKey string `json:"project" gorm:"index"`
- BatchID string `json:"batch_id"`
- FileName string `json:"file_name"`
- FilePath string `json:"file_path"`
- FileLanguage string `json:"file_language"`
- CodeSmells int `json:"code_smells"`
- SqaleIndex string `json:"sqale_index"`
- SqaleRating string `json:"sqale_rating"`
+ FileMetricsKey string `json:"componentKey" gorm:"primaryKey"`
+ ProjectKey string `json:"projectKey" gorm:"index"`
+ BatchID string `json:"batchId"`
+ FileName string `json:"fileName"`
+ FilePath string `json:"filePath"`
+ FileLanguage string `json:"fileLanguage"`
+ CodeSmells int `json:"codeSmells"`
+ SqaleIndex string `json:"sqaleIndex"`
+ SqaleRating string `json:"sqaleRating"`
Review Comment:
why do you change this model?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org